SessionRetriever::retrieve() - Code Metrics - Inspection of "Merge pull request #6 from cgauge/aws-network-issu..." - cgauge/laravel-php-session - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( 8f50ec...27cabb )

by Marco Aurélio

created 2021-01-06 10:23 UTC

SessionRetriever::retrieve() A

↳ Parent: SessionRetriever

Complexity

Conditions	2
Paths	2

Size

Total Lines	24
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	3.9401

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	12
c	1
b	0
f	0
dl	0
loc	24
ccs	3
cts	14
cp	0.2143
rs	9.8666
cc	2
nc	2
nop	0
crap	3.9401

<?php declare(strict_types=1);

namespace CustomerGauge\Session;

final class SessionRetriever
{
    private $path;

    private $domain;

    private $secure = true;

    private $session = null;

    public function __construct(string $path, string $domain)
    {
        $this->path = $path;
        $this->domain = $domain;
    }

    public static function fake(array $session): self
    {
        $instance = new self('', '');

        $instance->session = $session;

        return $instance;
    }

    public function insecure(): self
    {
        $this->secure = false;

        return $this;
    }

    public function retrieve(): array
    {
        if ($this->session !== null) {
            return $this->session;
        }

        ini_set('session.gc_maxlifetime', '1800');
        ini_set('session.save_handler', 'redis');
        ini_set('session.save_path', $this->path);
        ini_set('session.cookie_domain', $this->domain);
        ini_set('session.cookie_secure', (string) $this->secure);
        ini_set('session.cookie_httponly', '1');

        // When AWS Elasticache DNS resolution fails, PHP throws an error
        // session_start(): php_network_getaddresses: getaddrinfo failed: Name or service not known
        // This error is happening on 0.02% of our requests and AWS treat it as transient network
        // issues. Retrying before giving up might mitigate the problem.
        retry(3, function () {
            session_start();
        });

        $this->session = $_SESSION;

        return $this->session;
    }
}


1		<?php declare(strict_types=1);
2
3		namespace CustomerGauge\Session;
4
5		final class SessionRetriever
6		{
7		private $path;
8
9		private $domain;
10
11		private $secure = true;
12
13		private $session = null;
14
15	2	public function __construct(string $path, string $domain)
16		{
17	2	$this->path = $path;
18	2	$this->domain = $domain;
19	2	}
20
21	2	public static function fake(array $session): self
22		{
23	2	$instance = new self('', '');
24
25	2	$instance->session = $session;
26
27	2	return $instance;
28		}
29
30		public function insecure(): self
31		{
32		$this->secure = false;
33
34		return $this;
35		}
36
37	2	public function retrieve(): array
38		{
39	2	if ($this->session !== null) {
40	2	return $this->session;
41		}
42
43		ini_set('session.gc_maxlifetime', '1800');
44		ini_set('session.save_handler', 'redis');
45		ini_set('session.save_path', $this->path);
46		ini_set('session.cookie_domain', $this->domain);
47		ini_set('session.cookie_secure', (string) $this->secure);
48		ini_set('session.cookie_httponly', '1');
49
50		// When AWS Elasticache DNS resolution fails, PHP throws an error
51		// session_start(): php_network_getaddresses: getaddrinfo failed: Name or service not known
52		// This error is happening on 0.02% of our requests and AWS treat it as transient network
53		// issues. Retrying before giving up might mitigate the problem.
54		retry(3, function () {
55		session_start();
56		});
57
58		$this->session = $_SESSION;
59
60		return $this->session;
61		}
62		}
63

cgauge / laravel-php-session

Push — main ( 8f50ec...27cabb )

SessionRetriever::retrieve() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like