SessionRetriever::insecure() - Code Metrics - Inspection of "Add Tests" - cgauge/laravel-php-session - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — main (#2)

by Marco Aurélio

created 2020-10-04 15:15 UTC

SessionRetriever::insecure() A

↳ Parent: SessionRetriever

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
eloc	2
c	0
b	0
f	0
dl	0
loc	5
ccs	0
cts	3
cp	0
rs	10
cc	1
nc	1
nop	0
crap	2

<?php declare(strict_types=1);

namespace CustomerGauge\Session;

final class SessionRetriever
{
    private $path;

    private $domain;

    private $secure = true;

    private $session = null;

    public function __construct(string $path, string $domain)
    {
        $this->path = $path;
        $this->domain = $domain;
    }

    public static function fake(array $session): self
    {
        $instance = new self('', '');

        $instance->session = $session;

        return $instance;
    }

    public function insecure(): self
    {
        $this->secure = false;

        return $this;
    }

    public function retrieve(): array
    {
        if ($this->session !== null) {
            return $this->session;
        }

        ini_set('session.gc_maxlifetime', '1800');
        ini_set('session.save_handler', 'redis');
        ini_set('session.save_path', $this->path);
        ini_set('session.cookie_domain', $this->domain);
        ini_set('session.cookie_secure', (string) $this->secure);
        ini_set('session.cookie_httponly', '1');

        session_start();

        $this->session = $_SESSION;

        return $this->session;
    }
}


1		<?php declare(strict_types=1);
2
3		namespace CustomerGauge\Session;
4
5		final class SessionRetriever
6		{
7		private $path;
8
9		private $domain;
10
11		private $secure = true;
12
13		private $session = null;
14
15	2	public function __construct(string $path, string $domain)
16		{
17	2	$this->path = $path;
18	2	$this->domain = $domain;
19	2	}
20
21	2	public static function fake(array $session): self
22		{
23	2	$instance = new self('', '');
24
25	2	$instance->session = $session;
26
27	2	return $instance;
28		}
29
30		public function insecure(): self
31		{
32		$this->secure = false;
33
34		return $this;
35		}
36
37	2	public function retrieve(): array
38		{
39	2	if ($this->session !== null) {
40	2	return $this->session;
41		}
42
43		ini_set('session.gc_maxlifetime', '1800');
44		ini_set('session.save_handler', 'redis');
45		ini_set('session.save_path', $this->path);
46		ini_set('session.cookie_domain', $this->domain);
47		ini_set('session.cookie_secure', (string) $this->secure);
48		ini_set('session.cookie_httponly', '1');
49
50		session_start();
51
52		$this->session = $_SESSION;
53
54		return $this->session;
55		}
56		}
57

cgauge / laravel-php-session

Pull Request — main (#2)

SessionRetriever::insecure() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like