CognitoUserProvider::retrieveByCredentials() - Code Metrics - Inspection of "Small tweaks" - cgauge/laravel-cognito-provider - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 84533f...cb764e )

by Marco Aurélio

created 2020-03-15 20:54 UTC

CognitoUserProvider::retrieveByCredentials() A

↳ Parent: CognitoUserProvider

Complexity

Conditions	2
Paths	2

Size

Total Lines	17
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	5
c	1
b	0
f	0
nc	2
nop	1
dl	0
loc	17
ccs	5
cts	5
cp	1
crap	2
rs	10

<?php declare(strict_types=1);

namespace CustomerGauge\Cognito;

use CustomerGauge\Cognito\Parsers\ClientAppParser;
use Exception;
use Illuminate\Contracts\Auth\Authenticatable;
use Illuminate\Contracts\Auth\UserProvider;

final class CognitoUserProvider implements UserProvider
{
    private $clientAppParser;

    private $accessTokenParser;


    public function __construct(ClientAppParser $clientAppParser/*, AccessTokenParser $accessTokenParser*/)
    {
        $this->clientAppParser = $clientAppParser;
//        $this->accessTokenParser = $accessTokenParser;
    }

    public function retrieveByCredentials(array $credentials)
    {
        $token = $credentials['cognito_token'];

        try {
            return $this->clientAppParser->parse($token);
        } catch (Exception $e) {


        }
/*
        try {
            return $this->accessTokenParser->parse($token);
        } catch (Exception $e) {

        }
*/
        return null;
    }

    /** @phpstan ignore */
    public function validateCredentials(Authenticatable $user, array $credentials)
    {
    }

    /** @phpstan ignore */
    public function retrieveById($identifier)
    {
    }

    /** @phpstan ignore */
    public function retrieveByToken($identifier, $token)
    {
    }

    /** @phpstan ignore */
    public function updateRememberToken(Authenticatable $user, $token)
    {
    }
}


1		<?php declare(strict_types=1);
2
3		namespace CustomerGauge\Cognito;
4
5		use CustomerGauge\Cognito\Parsers\ClientAppParser;
6		use Exception;
7		use Illuminate\Contracts\Auth\Authenticatable;
8		use Illuminate\Contracts\Auth\UserProvider;
9
10		final class CognitoUserProvider implements UserProvider
11		{
12		private $clientAppParser;
13
14		private $accessTokenParser;
		0 ignored issues – show introduced 2020-03-15 20:24 UTC by Report Bug Copy Issue Report The private property `$accessTokenParser` is not used, and could be removed. Loading history...
15
16	2	public function __construct(ClientAppParser $clientAppParser/, AccessTokenParser $accessTokenParser/)
17		{
18	2	$this->clientAppParser = $clientAppParser;
19		// $this->accessTokenParser = $accessTokenParser;
20	2	}
21
22	2	public function retrieveByCredentials(array $credentials)
23		{
24	2	$token = $credentials['cognito_token'];
25
26		try {
27	2	return $this->clientAppParser->parse($token);
28	1	} catch (Exception $e) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2020-03-15 20:56 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
29
30		}
31		/*
32		try {
33		return $this->accessTokenParser->parse($token);
34		} catch (Exception $e) {
35
36		}
37		*/
38	1	return null;
39		}
40
41		/** @phpstan ignore */
42		public function validateCredentials(Authenticatable $user, array $credentials)
43		{
44		}
45
46		/** @phpstan ignore */
47		public function retrieveById($identifier)
48		{
49		}
50
51		/** @phpstan ignore */
52		public function retrieveByToken($identifier, $token)
53		{
54		}
55
56		/** @phpstan ignore */
57		public function updateRememberToken(Authenticatable $user, $token)
58		{
59		}
60		}
61

cgauge / laravel-cognito-provider

Push — master ( 84533f...cb764e )

CognitoUserProvider::retrieveByCredentials() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like