Workana\AsyncJobs\Console\PingCommand

Complexity

Total Complexity

5

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	configure()	0	10	1
A	execute()	0	13	3

<?php
namespace Workana\AsyncJobs\Console;

use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Workana\AsyncJobs\Util\Ping;
use Workana\AsyncJobs\AsyncAction;
use Workana\AsyncJobs\JobManager;

/**
 * Produces a ping
 *
 * @author Carlos Frutos <charly@workana.com>
 */
class PingCommand extends Command
{
    /**
     * @var JobManager
     */
    protected $jm;

    /**
     * Creates a new Command
     *
     * @param JobManager $jm
     */
    public function __construct(JobManager $jm)
    {
        parent::__construct('ping');

        $this->jm = $jm;
    }

    /**
     * {@inheritDoc}
     */
    public function configure()
    {
        $this->setDescription('Send a ping')
             ->addOption(
                'queues',
                null,
                InputOption::VALUE_REQUIRED,
                'Comma separated names of one or more queues that will be pinned.'
            );
    }

    /**
     * {@inheritdoc}
     */
    public function execute(InputInterface $input, OutputInterface $output)
    {
        $queueNames = array_map('trim', explode(',', $input->getOption('queues')));

$queueNames is not used, you could remove the assignment.

        $queueNames = !empty($queues) ?: $this->jm->getDriver()->listQueues();

The variable $queues seems to never exist, and therefore empty should always return true. Did you maybe rename this variable?

        foreach ($queueNames as $queueName) {

The expression $queueNames of type boolean|array is not guaranteed to be traversable. How about adding an additional type check?

            $action = new AsyncAction(Ping::class, 'ping');
            $action->withPreferredQueueName($queueName);
            $this->jm->dispatch($action);

            $output->writeln('Ping sent to: ' . $queueName);
        }
    }
}