cfoellmann / podlove-subscribe-button-wp-plugin

js/admin.js

(function($) {

This file is missing a doc comment.

	function podlove_init_color_buttons() {
		$(".podlove_subscribe_button_color").spectrum({

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			preferredFormat: 'hex',
			showInput: true,
			palette: [ '#599677' ],
			showPalette: true,
			showSelectionPalette: false,
			chooseText: i18n.select_color,
			cancelText: i18n.cancel,
		});
	}

	$( document ).ready( function() {

		podlove_init_color_buttons();

		$("#Podlove_cover_image_select").on( 'click', function(event) {

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

The parameter event is not used and could be removed.

			podlove_cover_image_selector = wp.media.frames.customHeader = wp.media( {

The variable podlove_cover_image_selector seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.podlove_cover_image_selector.

The variable wp seems to be never declared. If this is a global, consider adding a /** global: wp */ comment.

					title: i18n.media_library,
					library: {
						type: 'image'
					},
					button: {
						text: i18n.use_for
			   		},
			   		multiple: false
			    } );

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

			podlove_cover_image_selector.open();

			podlove_cover_image_selector.on('select', function() {
				var podcast_image_url = podlove_cover_image_selector.state().get('selection').first().toJSON().url;

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

				$("#podlove-button-cover").val(podcast_image_url);

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

				$("#podlove-button-cover").trigger('change');

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			});
		} );

		$(document).ready(function () {

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		    podlove_init_color_buttons();

		    jQuery(document).on('widget-updated', podlove_init_color_buttons);

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		    jQuery(document).on('widget-added', podlove_init_color_buttons);

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		    // re-init after saving configs

Inline comments must end in full-stops, exclamation marks, or question marks

		    jQuery(document).on('ajaxComplete', function(e){

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

The parameter e is not used and could be removed.

		        podlove_init_color_buttons();
		    });
		})

		var feed_counter = 0;
		var source = $("#feed_line_template").html();

Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		$(".add_feed").on( 'click', function () {

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			add_new_feed();
		} );

		if ( window.feeds !== undefined ) {
			$.each( feeds, function (index, feed) {

The variable feeds seems to be never declared. If this is a global, consider adding a /** global: feeds */ comment.

				add_existing_feed(feed);

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			} );
		}

		function add_new_feed() {
			row = source.replace( /\{\{url\}\}/g, '' );

The variable row seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.row.

			row = row.replace( /\{\{itunesfeedid\}\}/g, '' );
			row = row.replace( /\{\{id\}\}/g, feed_counter );

			$("#feeds_table_body").append(row);

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			new_row = $("#feeds_table_body tr:last");

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

The variable new_row seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.new_row.

			new_row.find("input:first").focus();

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			$(".podlove-icon-remove").on( 'click', function () {

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

				$(this).closest("tr").remove();

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			} );

			feed_counter++;
		}

		function add_existing_feed( feed ) {
			row = source.replace( /\{\{url\}\}/g, feed.url );

The variable row seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.row.

			row = row.replace( /\{\{id\}\}/g, feed_counter );
			if ( feed.itunesfeedid == null ) {

Comparing feed.itunesfeedid to null using the == operator is not safe. Consider using === instead.

				row = row.replace( /\{\{itunesfeedid\}\}/g, '' );
			} else {
				row = row.replace( /\{\{itunesfeedid\}\}/g, feed.itunesfeedid );
			}

			$("#feeds_table_body").append(row);

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			new_row = $("#feeds_table_body tr:last");

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

The variable new_row seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.new_row.

			new_row.find('select.podlove-media-format option[value="' + feed.format + '"]').attr('selected',true);

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			$(".podlove-icon-remove").on( 'click', function () {

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

				$(this).closest("tr").remove();

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			} );

			feed_counter++;
		}

	} );

Expected 0 blank lines before closing brace of nested function; 1 found

}(jQuery));