PodloveSubscribeButton::shortcode() - Code Metrics - Inspection of "add stuff" - cfoellmann/podlove-subscribe-button-wp-plugin - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( b818a9...64cd18 )

by Christian

created 2018-09-02 08:18 UTC

PodloveSubscribeButton::shortcode() B

↳ Parent: PodloveSubscribeButton

Complexity

Conditions	8
Paths	10

Size

Total Lines	38
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	8
eloc	24
nc	10
nop	1
dl	0
loc	38
rs	8.4444
c	1
b	0
f	0

<?php

introduced 2018-08-31 12:09 UTC by

Class file names should be based on the class name with "class-" prepended. Expected class-podlovesubscribebutton.php, but found podlove.php.

/**

 * Plugin Name: Podlove Subscribe Button

 * Plugin URI:  http://wordpress.org/extend/plugins/podlove-subscribe-button/

 * Description: Brings the Podlove Subscribe Button to your WordPress installation.

 * Version:     1.3.3

 * Author:      Podlove

 * Author URI:  http://podlove.org

 * License:     MIT

 * License URI: license.txt

 * Text Domain: podlove-subscribe-button

*/

Coding Style Documentation introduced 2018-09-02 08:21 UTC by

Missing @package tag in file comment

$correct_php_version = version_compare( phpversion(), "5.3", ">=" );

Coding Style Comprehensibility introduced 2018-08-31 12:09 UTC by

The string literal 5.3 does not require double quotes, as per coding-style, please use single quotes.

if ( ! $correct_php_version ) {

	_e("Podlove Subscribe Button Plugin requires <strong>PHP 5.3</strong> or higher.<br>", 'podlove-subscribe-button');

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

Coding Style Comprehensibility introduced 2018-08-31 12:09 UTC by

The string literal Podlove Subscribe Button.../strong> or higher.<br> does not require double quotes, as per coding-style, please use single quotes.

introduced 2018-09-02 08:21 UTC by

All output should be run through an escaping function (like esc_html_e() or esc_attr_e()), found '_e'.

	echo __("You are running PHP ", 'podlove-subscribe-button') . phpversion();

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

Coding Style Comprehensibility introduced 2018-08-31 12:09 UTC by

The string literal You are running PHP does not require double quotes, as per coding-style, please use single quotes.

introduced 2018-09-02 08:21 UTC by

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '__'.

introduced 2018-09-02 08:21 UTC by

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'phpversion'.

	exit;

// Constants

Coding Style introduced 2018-09-02 08:21 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

require('constants.php');

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

Coding Style introduced 2018-09-02 08:21 UTC by

"require" is a statement not a function; no parentheses are required

require('settings/buttons.php');

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

Coding Style introduced 2018-09-02 08:21 UTC by

"require" is a statement not a function; no parentheses are required

// Models

Coding Style introduced 2018-09-02 08:21 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

require('model/base.php');

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

Coding Style introduced 2018-09-02 08:21 UTC by

"require" is a statement not a function; no parentheses are required

require('model/button.php');

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

Coding Style introduced 2018-09-02 08:21 UTC by

"require" is a statement not a function; no parentheses are required

require('model/network_button.php');

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

Coding Style introduced 2018-09-02 08:21 UTC by

"require" is a statement not a function; no parentheses are required

// Table

Coding Style introduced 2018-09-02 08:21 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

require('settings/buttons_list_table.php');

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

Coding Style introduced 2018-09-02 08:21 UTC by

"require" is a statement not a function; no parentheses are required

// Media Types

Coding Style introduced 2018-09-02 08:21 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

require('media_types.php');

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

Coding Style introduced 2018-09-02 08:21 UTC by

"require" is a statement not a function; no parentheses are required

// Widget

Coding Style introduced 2018-09-02 08:21 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

require('widget.php');

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

Coding Style introduced 2018-09-02 08:21 UTC by

"require" is a statement not a function; no parentheses are required

// Version control

Coding Style introduced 2018-09-02 08:21 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

require('version.php');

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

Coding Style introduced 2018-09-02 08:21 UTC by

"require" is a statement not a function; no parentheses are required

// Helper functions

Coding Style introduced 2018-09-02 08:21 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

require('helper.php');

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

Coding Style introduced 2018-09-02 08:21 UTC by

"require" is a statement not a function; no parentheses are required

add_action( 'admin_menu', array( 'PodloveSubscribeButton', 'admin_menu') );

introduced 2018-08-31 12:09 UTC by

Missing space before array closer.

if ( is_multisite() )

Coding Style Best Practice introduced 2018-08-31 12:09 UTC by

It is generally a best practice to always use braces with control structures.

	add_action( 'network_admin_menu', array( 'PodloveSubscribeButton', 'admin_network_menu') );

introduced 2018-08-31 12:09 UTC by

Missing space before array closer.

add_action( 'admin_init', array( 'PodloveSubscribeButton\Settings\Buttons', 'process_form' ) );

register_activation_hook( __FILE__, array( 'PodloveSubscribeButton', 'build_models' ) );

add_action( 'admin_enqueue_scripts', function () {

	wp_register_style( 'podlove-subscribe-button', plugin_dir_url(__FILE__).'style.css' );

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Concat operator must be surrounded by a single space

introduced 2018-09-02 08:21 UTC by

Resource version not set in call to wp_register_style(). This means new versions of the style will not always be loaded due to browser caching.

	wp_enqueue_style( 'podlove-subscribe-button' );

	wp_enqueue_style('podlove-subscribe-button-spectrum', plugin_dir_url(__FILE__). 'js/spectrum/spectrum.css');

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Concat operator must be surrounded by a single space

introduced 2018-09-02 08:21 UTC by

Resource version not set in call to wp_enqueue_style(). This means new versions of the style will not always be loaded due to browser caching.

	wp_enqueue_script('podlove-subscribe-button-spectrum', plugin_dir_url(__FILE__). 'js/spectrum/spectrum.js', array('jquery'));

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Concat operator must be surrounded by a single space

introduced 2018-08-31 12:09 UTC by

Missing space after array opener.

introduced 2018-08-31 12:09 UTC by

Missing space before array closer.

introduced 2018-09-02 08:21 UTC by

In footer ($in_footer) is not set explicitly wp_enqueue_script; It is recommended to load scripts in the footer. Please set this value to true to load it in the footer, or explicitly false if it should be loaded in the header.

introduced 2018-09-02 08:21 UTC by

Resource version not set in call to wp_enqueue_script(). This means new versions of the script will not always be loaded due to browser caching.

	wp_enqueue_script('podlove-subscribe-button-admin-tools', plugin_dir_url(__FILE__). 'js/admin.js', array('jquery'));

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Concat operator must be surrounded by a single space

introduced 2018-08-31 12:09 UTC by

Missing space after array opener.

introduced 2018-08-31 12:09 UTC by

Missing space before array closer.

introduced 2018-09-02 08:21 UTC by

Resource version not set in call to wp_enqueue_script(). This means new versions of the script will not always be loaded due to browser caching.

} );

// Register Settings

Coding Style introduced 2018-09-02 08:21 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

add_action( 'admin_init', function () {

	$settings = array('size', 'autowidth', 'style', 'format', 'color');

introduced 2018-08-31 12:09 UTC by

Missing space after array opener.

introduced 2018-08-31 12:09 UTC by

Missing space before array closer.

	foreach ($settings as $setting) {

introduced 2018-08-31 12:09 UTC by

No space after opening parenthesis is prohibited

introduced 2018-08-31 12:09 UTC by

No space before closing parenthesis is prohibited

		register_setting( 'podlove-subscribe-button', 'podlove_subscribe_button_default_' . $setting );

} );

add_shortcode( 'podlove-subscribe-button', array( 'PodloveSubscribeButton', 'shortcode' ) );

add_action( 'plugins_loaded', function () {

	load_plugin_textdomain( 'podlove-subscribe-button' );

} );

class PodloveSubscribeButton {

Coding Style Documentation introduced 2018-09-02 08:21 UTC by

Missing class doc comment

	public static function admin_menu() {

Coding Style introduced 2018-09-02 08:21 UTC by

Method name "PodloveSubscribeButton::admin_menu" is not in camel caps format

Coding Style Documentation introduced 2018-09-02 08:21 UTC by

Missing function doc comment

		add_options_page(

				'Podlove Subscribe Button Options',

Coding Style introduced 2018-08-31 12:09 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

				'Podlove Subscribe Button',

Coding Style introduced 2018-08-31 12:09 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

				'manage_options',

Coding Style introduced 2018-08-31 12:09 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

				'podlove-subscribe-button',

Coding Style introduced 2018-08-31 12:09 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

				array( 'PodloveSubscribeButton\Settings\Buttons', 'page')

Coding Style introduced 2018-08-31 12:09 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

introduced 2018-08-31 12:09 UTC by

Missing space before array closer.

);

Coding Style introduced 2018-08-31 12:09 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 8 spaces, but found 12.

Coding Style introduced 2018-09-02 08:21 UTC by

Expected 1 blank line before closing function brace; 0 found

	public static function admin_network_menu() {

Coding Style introduced 2018-09-02 08:21 UTC by

Method name "PodloveSubscribeButton::admin_network_menu" is not in camel caps format

Coding Style Documentation introduced 2018-09-02 08:21 UTC by

Missing function doc comment

		add_submenu_page(

				'settings.php',

Coding Style introduced 2018-08-31 12:09 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

				'Podlove Subscribe Button Options',

Coding Style introduced 2018-08-31 12:09 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

				'Podlove Subscribe Button',

Coding Style introduced 2018-08-31 12:09 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

				'manage_options',

Coding Style introduced 2018-08-31 12:09 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

				'podlove-subscribe-button',

Coding Style introduced 2018-08-31 12:09 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

				array( 'PodloveSubscribeButton\Settings\Buttons', 'page')

Coding Style introduced 2018-08-31 12:09 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

introduced 2018-08-31 12:09 UTC by

Missing space before array closer.

);

Coding Style introduced 2018-08-31 12:09 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 8 spaces, but found 12.

Coding Style introduced 2018-09-02 08:21 UTC by

Expected 1 blank line before closing function brace; 0 found

	public static function build_models() {

Coding Style introduced 2018-09-02 08:21 UTC by

Method name "PodloveSubscribeButton::build_models" is not in camel caps format

Coding Style Documentation introduced 2018-09-02 08:21 UTC by

Missing function doc comment

		// Build Databases

Coding Style introduced 2018-09-02 08:21 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

		\PodloveSubscribeButton\Model\Button::build();

		if ( is_multisite() )

Coding Style Best Practice introduced 2018-08-31 12:09 UTC by

It is generally a best practice to always use braces with control structures.

			\PodloveSubscribeButton\Model\NetworkButton::build();

100

101

		// Set Button "default" values

Coding Style introduced 2018-09-02 08:21 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

102

		$default_values = array(

103

				'size' => 'big',

introduced 2018-08-31 12:09 UTC by

Array item not aligned correctly; expected 12 spaces but found 16

introduced 2018-08-31 12:09 UTC by

Array double arrow not aligned correctly; expected 6 space(s) between "'size'" and double arrow, but found 1.

104

				'autowidth' => 'on',

introduced 2018-08-31 12:09 UTC by

Array item not aligned correctly; expected 12 spaces but found 16

105

				'color' => '#599677',

introduced 2018-08-31 12:09 UTC by

Array item not aligned correctly; expected 12 spaces but found 16

introduced 2018-08-31 12:09 UTC by

Array double arrow not aligned correctly; expected 5 space(s) between "'color'" and double arrow, but found 1.

106

				'style' => 'filled',

introduced 2018-08-31 12:09 UTC by

Array item not aligned correctly; expected 12 spaces but found 16

introduced 2018-08-31 12:09 UTC by

Array double arrow not aligned correctly; expected 5 space(s) between "'style'" and double arrow, but found 1.

107

				'format' => 'rectangle'

introduced 2018-08-31 12:09 UTC by

Array item not aligned correctly; expected 12 spaces but found 16

introduced 2018-08-31 12:09 UTC by

Array double arrow not aligned correctly; expected 4 space(s) between "'format'" and double arrow, but found 1.

introduced 2018-08-31 12:09 UTC by

Each array item in a multi-line array declaration must end in a comma

108

);

introduced 2018-08-31 12:09 UTC by

Array closer not aligned correctly; expected 8 space(s) but found 12

109

110

		foreach ($default_values as $option => $default_value) {

introduced 2018-08-31 12:09 UTC by

No space after opening parenthesis is prohibited

introduced 2018-08-31 12:09 UTC by

No space before closing parenthesis is prohibited

111

			if ( ! get_option('podlove_subscribe_button_default_' . $option ) ) {

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

112

				update_option('podlove_subscribe_button_default_' . $option, $default_value);

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

113

114

115

Coding Style introduced 2018-09-02 08:21 UTC by

Expected 1 blank line before closing function brace; 0 found

116

117

	public static function shortcode( $args ) {

Coding Style Documentation introduced 2018-09-02 08:21 UTC by

Missing function doc comment

118

		if ( ! $args || ! isset($args['button']) ) {

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

119

			return __('You need to create a Button first and provide its ID.', 'podlove-subscribe-button');

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

120

		} else {

121

			$buttonid = $args['button'];

122

123

124

		// Fetch the (network)button by it's name

Coding Style introduced 2018-09-02 08:21 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

125

		if ( ! $button = \PodloveSubscribeButton\Model\Button::get_button_by_name($args['button']) )

Coding Style Best Practice introduced 2018-08-31 12:09 UTC by

It is generally a best practice to always use braces with control structures.

Coding Style introduced 2018-08-31 12:09 UTC by

Assignments must be the first block of code on a line

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

introduced 2018-09-02 08:21 UTC by

Variable assignment found within a condition. Did you mean to do a comparison?

126

			return sprintf( __('Oops. There is no button with the ID "%s".', 'podlove-subscribe-button'), $args['button'] );

introduced 2018-08-31 12:09 UTC by

A gettext call containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

127

128

		// Get button styling and options

Coding Style introduced 2018-09-02 08:21 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

129

		$autowidth = self::interpret_width_attribute( self::get_array_value_with_fallback($args, 'width') );

Bug introduced 2018-08-31 09:14 UTC by

It seems like self::get_array_value_wi...allback($args, 'width') can also be of type false; however, parameter $width_attribute of PodloveSubscribeButton::...rpret_width_attribute() does only seem to accept string, maybe add an additional type check? ( Ignorable by Annotation )

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

130

		$size = self::get_attribute( 'size', self::get_array_value_with_fallback($args, 'size') );

Bug introduced 2018-08-31 09:14 UTC by

It seems like self::get_array_value_wi...fallback($args, 'size') can also be of type false; however, parameter $attribute_value of PodloveSubscribeButton::get_attribute() does only seem to accept string, maybe add an additional type check? ( Ignorable by Annotation )

Coding Style introduced 2018-08-31 12:09 UTC by

Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

131

		$style = self::get_attribute( 'style', self::get_array_value_with_fallback($args, 'style') );

Coding Style introduced 2018-08-31 12:09 UTC by

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

132

		$format = self::get_attribute( 'format', self::get_array_value_with_fallback($args, 'format') );

Coding Style introduced 2018-08-31 12:09 UTC by

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

133

		$color = self::get_attribute( 'color', self::get_array_value_with_fallback($args, 'color') );

Unused Code introduced 2018-08-31 09:14 UTC by

The assignment to $color is dead and can be removed.

Coding Style introduced 2018-08-31 12:09 UTC by

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

134

135

		if ( isset($args['language']) ) {

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

136

			$language = $args['language'];

137

		} else {

138

			$language = 'en';

139

140

141

		if ( isset($args['color']) ) {

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

142

			$color = $args['color'];

143

		} else {

144

			$color = get_option('podlove_subscribe_button_default_color', '#599677');

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

145

146

147

		if ( isset($args['hide']) && $args['hide'] == 'true' ) {

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

introduced 2018-08-31 12:09 UTC by

Use Yoda Condition checks, you must.

introduced 2018-09-02 08:21 UTC by

Found: ==. Use strict comparisons (=== or !==).

148

			$hide = TRUE;

Coding Style introduced 2018-08-31 12:09 UTC by

TRUE, FALSE and NULL must be lowercase; expected true, but found TRUE.

149

		} else {

150

			$hide = FALSE;

Coding Style introduced 2018-08-31 12:09 UTC by

TRUE, FALSE and NULL must be lowercase; expected false, but found FALSE.

151

152

153

		// Render button

Coding Style introduced 2018-09-02 08:21 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

154

		return $button->render($size, $autowidth, $style, $format, $color, $hide, $buttonid, $language);

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

155

Coding Style introduced 2018-09-02 08:21 UTC by

Expected 1 blank line before closing function brace; 0 found

156

157

	public static function get_array_value_with_fallback($args, $key) {

introduced 2018-08-31 12:09 UTC by

No space after opening parenthesis is prohibited

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces between opening bracket and argument "$args"; 0 found

introduced 2018-08-31 12:09 UTC by

No space before closing parenthesis is prohibited

Coding Style introduced 2018-09-02 08:21 UTC by

Method name "PodloveSubscribeButton::get_array_value_with_fallback" is not in camel caps format

Coding Style Documentation introduced 2018-09-02 08:21 UTC by

Missing function doc comment

158

		if ( isset($args[$key]) )

Coding Style Best Practice introduced 2018-08-31 12:09 UTC by

It is generally a best practice to always use braces with control structures.

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

introduced 2018-08-31 12:09 UTC by

Array keys must be surrounded by spaces unless they contain a string or an integer.

159

			return $args[$key];

introduced 2018-08-31 12:09 UTC by

Array keys must be surrounded by spaces unless they contain a string or an integer.

160

161

		return FALSE;

Coding Style introduced 2018-08-31 12:09 UTC by

TRUE, FALSE and NULL must be lowercase; expected false, but found FALSE.

162

Coding Style introduced 2018-09-02 08:21 UTC by

Expected 1 blank line before closing function brace; 0 found

163

164

/**

Coding Style introduced 2018-09-02 08:21 UTC by

Missing short description in doc comment

165

	 * @param  string $attribute

Coding Style Documentation introduced 2018-09-02 08:21 UTC by

Missing parameter comment

166

	 * @param  string $attribute_value

Coding Style Documentation introduced 2018-09-02 08:21 UTC by

Missing parameter comment

167

	 * @return string

168

*/

169

	private static function get_attribute($attribute=NULL, $attribute_value=NULL) {

introduced 2018-08-31 12:09 UTC by

No space after opening parenthesis is prohibited

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces between opening bracket and argument "$attribute"; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Incorrect spacing between argument "$attribute" and equals sign; expected 1 but found 0

Coding Style introduced 2018-08-31 12:09 UTC by

Incorrect spacing between default value and equals sign for argument "$attribute"; expected 1 but found 0

Coding Style introduced 2018-08-31 12:09 UTC by

TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.

Coding Style introduced 2018-08-31 12:09 UTC by

Incorrect spacing between argument "$attribute_value" and equals sign; expected 1 but found 0

Coding Style introduced 2018-08-31 12:09 UTC by

Incorrect spacing between default value and equals sign for argument "$attribute_value"; expected 1 but found 0

introduced 2018-08-31 12:09 UTC by

No space before closing parenthesis is prohibited

Coding Style introduced 2018-09-02 08:21 UTC by

Method name "PodloveSubscribeButton::get_attribute" is not in camel caps format

170

		if ( isset($attribute_value) && ctype_alnum($attribute_value) && key_exists( $attribute_value, \PodloveSubscribeButton\Model\Button::$$attribute ) ) {

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

171

			return $attribute_value;

172

		} else {

173

			return get_option('podlove_subscribe_button_default_' . $attribute, \PodloveSubscribeButton\Model\Button::$properties[$attribute]);

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

introduced 2018-08-31 12:09 UTC by

Array keys must be surrounded by spaces unless they contain a string or an integer.

174

175

Coding Style introduced 2018-09-02 08:21 UTC by

Expected 1 blank line before closing function brace; 0 found

176

177

/**

178

	 * Interprets the provided width attribute and return either auto- or a specific width

179

	 * @param  string $width_attribute

Coding Style introduced 2018-09-02 08:21 UTC by

There must be exactly one blank line before the tags in a doc comment

Coding Style Documentation introduced 2018-09-02 08:21 UTC by

Missing parameter comment

180

	 * @return string

181

*/

182

	private static function interpret_width_attribute( $width_attribute = NULL ) {

Coding Style introduced 2018-08-31 12:09 UTC by

TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.

Coding Style introduced 2018-09-02 08:21 UTC by

Method name "PodloveSubscribeButton::interpret_width_attribute" is not in camel caps format

183

		if ( $width_attribute == 'auto' )

Coding Style Best Practice introduced 2018-08-31 12:09 UTC by

It is generally a best practice to always use braces with control structures.

introduced 2018-08-31 12:09 UTC by

Use Yoda Condition checks, you must.

introduced 2018-09-02 08:21 UTC by

Found: ==. Use strict comparisons (=== or !==).

184

			return 'on';

185

		if ( $width_attribute && $width_attribute !== 'auto' )

Coding Style Best Practice introduced 2018-08-31 12:09 UTC by

It is generally a best practice to always use braces with control structures.

introduced 2018-08-31 12:09 UTC by

Use Yoda Condition checks, you must.

186

			return 'off';

187

188

		return get_option('podlove_subscribe_button_default_autowidth', 'on');

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces before closing bracket; 0 found

189

Coding Style introduced 2018-09-02 08:21 UTC by

Expected 1 blank line before closing function brace; 0 found

190

cfoellmann / podlove-subscribe-button-wp-plugin

Push — master ( b818a9...64cd18 )

PodloveSubscribeButton::shortcode() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like