cfoellmann / podlove-subscribe-button-wp-plugin

widget.php

<?php

Class file names should be based on the class name with "class-" prepended. Expected class-podlove-subscribe-button-widget.php, but found widget.php.

namespace PodloveSubscribeButton;

include_once( ABSPATH . 'wp-admin/includes/plugin.php' );

class Podlove_Subscribe_Button_Widget extends \WP_Widget {

	public function __construct() {
		parent::__construct(
					'podlove_subscribe_button_wp_plugin_widget',

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 20.

					( self::is_podlove_publisher_active() ? 'Podlove Subscribe Button' : 'Podlove Subscribe Button (WordPress plugin)' ),

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 20.

					array( 'description' => __( 'Adds a Podlove Subscribe Button to your Sidebar', 'podlove-subscribe-button' ), )

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 20.

Comma not allowed after last value in single-line array declaration

				);

This line of the multi-line function call does not seem to be indented correctly. Expected 8 spaces, but found 16.

	}

	public static $widget_settings = array('infotext', 'title', 'size', 'style', 'format', 'autowidth', 'button', 'color');

Missing space after array opener.

Missing space before array closer.

	public static function is_podlove_publisher_active() {
		if ( is_plugin_active("podlove-publisher/plugin.php") )

It is generally a best practice to always use braces with control structures.

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

The string literal podlove-publisher/plugin.php does not require double quotes, as per coding-style, please use single quotes.

			return true;

		return false;
	}

	public function widget( $args, $instance ) {
		// Fetch the (network)button by it's name
		if ( ! $button = \PodloveSubscribeButton\Model\Button::get_button_by_name($instance['button']) )

This code seems to be duplicated across your project.

It is generally a best practice to always use braces with control structures.

Assignments must be the first block of code on a line

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			return sprintf( __('Oops. There is no button with the ID "%s".', 'podlove-subscribe-button'), $args['button'] );

A gettext call containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		echo $args['before_widget'];
		echo $args['before_title'] . apply_filters( 'widget_title', $instance['title'] ). $args['after_title'];

Concat operator must be surrounded by a single space

		echo $button->render(
				\PodloveSubscribeButton::get_array_value_with_fallback($instance, 'size'),

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

				\PodloveSubscribeButton::get_array_value_with_fallback($instance, 'autowidth'),

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

				\PodloveSubscribeButton::get_array_value_with_fallback($instance, 'style'),

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

				\PodloveSubscribeButton::get_array_value_with_fallback($instance, 'format'), 

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

				\PodloveSubscribeButton::get_array_value_with_fallback($instance, 'color')

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			);

This line of the multi-line function call does not seem to be indented correctly. Expected 8 spaces, but found 12.

		
		if ( strlen($instance['infotext']) )

It is generally a best practice to always use braces with control structures.

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			echo wpautop($instance['infotext']);

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		echo $args['after_widget'];
	}	

Spaces must be used for mid-line alignment; tabs are not allowed

	public function form( $instance ) {
		foreach (self::$widget_settings as $setting) {

No space after opening parenthesis is prohibited

No space before closing parenthesis is prohibited

			$$setting = isset( $instance[$setting] ) ? $instance[$setting] : '';

Array keys must be surrounded by spaces unless they contain a string or an integer.

		}

		$buttons = \PodloveSubscribeButton\Model\Button::all();

Equals sign not aligned with surrounding assignments; expected 13 spaces but found 1 space

		if ( is_multisite() )

It is generally a best practice to always use braces with control structures.

			$network_buttons = \PodloveSubscribeButton\Model\NetworkButton::all();

		$buttons_as_options = function ($buttons) {

No space after opening parenthesis is prohibited

Expected 1 spaces between opening bracket and argument "$buttons"; 0 found

No space before closing parenthesis is prohibited

			foreach ($buttons as $subscribebutton) {

No space after opening parenthesis is prohibited

No space before closing parenthesis is prohibited

				echo "<option value='".$subscribebutton->name."' ".( $subscribebutton->name == $button ? 'selected=\"selected\"' : '' )." >".$subscribebutton->title." (".$subscribebutton->name.")</option>";

The variable $button does not exist. Did you mean $buttons?

Concat operator must be surrounded by a single space

The string literal > does not require double quotes, as per coding-style, please use single quotes.

The string literal ( does not require double quotes, as per coding-style, please use single quotes.

The string literal )</option> does not require double quotes, as per coding-style, please use single quotes.

			}
		}
		?>
		<p>
			<label for="<?php echo $this->get_field_id( 'title' ); ?>"><?php _e( 'Title', 'podlove-subscribe-button' ); ?></label> 
			<input class="widefat" id="<?php echo $this->get_field_id( 'title' ); ?>" name="<?php echo $this->get_field_name( 'title' ); ?>" value="<?php echo $title; ?>" />

The variable $title does not exist. Did you forget to declare it?

			<label for="<?php echo $this->get_field_id( 'color' ); ?>"><?php _e( 'Color', 'podlove-subscribe-button' ); ?></label>
			<input class="podlove_subscribe_button_color" id="<?php echo $this->get_field_id( 'color' ); ?>" name="<?php echo $this->get_field_name( 'color' ); ?>" value="<?php echo $color; ?>" />

The variable $color does not exist. Did you forget to declare it?

			<style type="text/css">
				.sp-replacer {
					display: flex;
				}
				.sp-preview {
					flex-grow: 10;
				}
			</style>

			<label for="<?php echo $this->get_field_id( 'button' ); ?>"><?php _e( 'Button', 'podlove-subscribe-button' ); ?></label> 
			<select class="widefat" id="<?php echo $this->get_field_id( 'button' ); ?>"
				      name="<?php echo $this->get_field_name( 'button' ); ?>">

Found precision alignment of 2 spaces.

				<?php if ( isset($network_buttons) && count($network_buttons) > 0 ) : ?>

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

					<optgroup label="<?php _e('Local', 'podlove'); ?>">

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

						<?php $buttons_as_options($buttons); ?>
					</optgroup>
					<optgroup label="<?php _e('Network', 'podlove'); ?>">

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

						<?php $buttons_as_options($network_buttons); ?>
					</optgroup>
				<?php else : 

Opening PHP tag must be on a line by itself

					$buttons_as_options($buttons);
				 endif; ?>

Found precision alignment of 1 spaces.

Closing PHP tag must be on a line by itself

			</select>

			<?php
			$customize_options = array(
					'size' => array(

Array item not aligned correctly; expected 16 spaces but found 20

Array double arrow not aligned correctly; expected 6 space(s) between "'size'" and double arrow, but found 1.

							'name' => 'Size',

Multi-line array item not aligned correctly; expected 24 spaces, but found 28

Array item not aligned correctly; expected 24 spaces but found 28

Array double arrow not aligned correctly; expected 4 space(s) between "'name'" and double arrow, but found 1.

							'options' => \PodloveSubscribeButton\Model\Button::$size

Array item not aligned correctly; expected 24 spaces but found 28

Each array item in a multi-line array declaration must end in a comma

						),

Array closer not aligned correctly; expected 20 space(s) but found 24

					'style' => array(

Array item not aligned correctly; expected 16 spaces but found 20

Array double arrow not aligned correctly; expected 5 space(s) between "'style'" and double arrow, but found 1.

							'name' => 'Style',

Multi-line array item not aligned correctly; expected 24 spaces, but found 28

Array item not aligned correctly; expected 24 spaces but found 28

Array double arrow not aligned correctly; expected 4 space(s) between "'name'" and double arrow, but found 1.

							'options' => \PodloveSubscribeButton\Model\Button::$style

Array item not aligned correctly; expected 24 spaces but found 28

Each array item in a multi-line array declaration must end in a comma

						),

Array closer not aligned correctly; expected 20 space(s) but found 24

					'format' => array(

Array item not aligned correctly; expected 16 spaces but found 20

Array double arrow not aligned correctly; expected 4 space(s) between "'format'" and double arrow, but found 1.

							'name' => 'Format',

Multi-line array item not aligned correctly; expected 24 spaces, but found 28

Array item not aligned correctly; expected 24 spaces but found 28

Array double arrow not aligned correctly; expected 4 space(s) between "'name'" and double arrow, but found 1.

							'options' => \PodloveSubscribeButton\Model\Button::$format

Array item not aligned correctly; expected 24 spaces but found 28

Each array item in a multi-line array declaration must end in a comma

						),

Array closer not aligned correctly; expected 20 space(s) but found 24

					'autowidth' => array(

Array item not aligned correctly; expected 16 spaces but found 20

							'name' => 'Autowidth',

Multi-line array item not aligned correctly; expected 24 spaces, but found 28

Array item not aligned correctly; expected 24 spaces but found 28

Array double arrow not aligned correctly; expected 4 space(s) between "'name'" and double arrow, but found 1.

							'options' => \PodloveSubscribeButton\Model\Button::$width

Array item not aligned correctly; expected 24 spaces but found 28

Each array item in a multi-line array declaration must end in a comma

						)

Each array item in a multi-line array declaration must end in a comma

Array closer not aligned correctly; expected 20 space(s) but found 24

				);

Array closer not aligned correctly; expected 12 space(s) but found 16

			foreach ($customize_options as $slug => $properties) : ?>

No space after opening parenthesis is prohibited

No space before closing parenthesis is prohibited

Closing PHP tag must be on a line by itself

				<label for="<?php echo $this->get_field_id( $slug ); ?>"><?php _e( $properties['name'], 'podlove-subscribe-button' ); ?></label> 

The $text arg must be a single string literal, not "$properties['name']".

				<select class="widefat" id="<?php echo $this->get_field_id( $slug ); ?>" name="<?php echo $this->get_field_name( $slug ); ?>">
					<option value="default" <?php echo ( $$slug == 'default' ? 'selected="selected"' : '' ); ?>><?php _e( 'Default ' . $properties['name'], 'podlove-subscribe-button' ) ?></option>

Use Yoda Condition checks, you must.

Inline PHP statement must end with a semicolon

The $text arg must be a single string literal, not "'Default '.$properties['name']".

					<optgroup>
						<?php foreach ( $properties['options'] as $property => $name ) : ?>
						<option value="<?php echo $property; ?>" <?php echo ( $$slug == $property ? 'selected="selected"' : '' ); ?>><?php _e( $name, 'podlove-subscribe-button' ) ?></option>

Inline PHP statement must end with a semicolon

The $text arg must be a single string literal, not "$name".

						<?php endforeach; ?>
					</optgroup>
				</select>
			<?php endforeach; ?>
		

Found precision alignment of 1 spaces.

			<label for="<?php echo $this->get_field_id( 'infotext' ); ?>"><?php _e( 'Description', 'podlove-subscribe-button' ); ?></label> 
			<textarea class="widefat" rows="10" id="<?php echo $this->get_field_id( 'infotext' ); ?>" name="<?php echo $this->get_field_name( 'infotext' ); ?>"><?php echo $infotext; ?></textarea>

The variable $infotext does not exist. Did you forget to declare it?

		</p>
		<?php 
	}

	public function update( $new_instance, $old_instance ) {
		$instance = array();

		foreach (self::$widget_settings as $setting) {

No space after opening parenthesis is prohibited

No space before closing parenthesis is prohibited

			$instance[$setting]  = ( ! empty( $new_instance[$setting] ) ) ? strip_tags( $new_instance[$setting] ) : '';

Array keys must be surrounded by spaces unless they contain a string or an integer.

Equals sign not aligned correctly; expected 1 space but found 2 spaces

		}

		return $instance;
	}
}
add_action( 'widgets_init', function(){

Expected 1 space before opening brace; found 0

     register_widget( '\PodloveSubscribeButton\Podlove_Subscribe_Button_Widget' );

Found precision alignment of 1 spaces.

});