cfoellmann / podlove-subscribe-button-wp-plugin

podlove.php

<?php

Class file names should be based on the class name with "class-" prepended. Expected class-podlovesubscribebutton.php, but found podlove.php.

/**
 * Plugin Name: Podlove Subscribe Button
 * Plugin URI:  http://wordpress.org/extend/plugins/podlove-subscribe-button/
 * Description: Brings the Podlove Subscribe Button to your WordPress installation.
 * Version:     1.3.3
 * Author:      Podlove
 * Author URI:  http://podlove.org
 * License:     MIT
 * License URI: license.txt
 * Text Domain: podlove-subscribe-button
 */

$correct_php_version = version_compare( phpversion(), "5.3", ">=" );

The string literal 5.3 does not require double quotes, as per coding-style, please use single quotes.

if ( ! $correct_php_version ) {
	_e("Podlove Subscribe Button Plugin requires <strong>PHP 5.3</strong> or higher.<br>", 'podlove-subscribe-button');

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

The string literal Podlove Subscribe Button Plugin requires <strong>PHP 5.3</strong> or higher.<br> does not require double quotes, as per coding-style, please use single quotes.

	echo __("You are running PHP ", 'podlove-subscribe-button') . phpversion();

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

The string literal You are running PHP does not require double quotes, as per coding-style, please use single quotes.

	exit;
}

// Constants
require('constants.php');

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

require('settings/buttons.php');

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

// Models
require('model/base.php');

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

require('model/button.php');

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

require('model/network_button.php');

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

// Table
require('settings/buttons_list_table.php');

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

// Media Types
require('media_types.php');

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

// Widget
require('widget.php');

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

// Version control
require('version.php');

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

// Helper functions
require('helper.php');

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

add_action( 'admin_menu', array( 'PodloveSubscribeButton', 'admin_menu') );

Missing space before array closer.

if ( is_multisite() )

It is generally a best practice to always use braces with control structures.

	add_action( 'network_admin_menu', array( 'PodloveSubscribeButton', 'admin_network_menu') );

Missing space before array closer.

add_action( 'admin_init', array( 'PodloveSubscribeButton\Settings\Buttons', 'process_form' ) );
register_activation_hook( __FILE__, array( 'PodloveSubscribeButton', 'build_models' ) );

add_action( 'admin_enqueue_scripts', function () {
	wp_register_style( 'podlove-subscribe-button', plugin_dir_url(__FILE__).'style.css' );

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

Concat operator must be surrounded by a single space

	wp_enqueue_style( 'podlove-subscribe-button' );

	wp_enqueue_style('podlove-subscribe-button-spectrum', plugin_dir_url(__FILE__). 'js/spectrum/spectrum.css');

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

Concat operator must be surrounded by a single space

	wp_enqueue_script('podlove-subscribe-button-spectrum', plugin_dir_url(__FILE__). 'js/spectrum/spectrum.js', array('jquery'));

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

Concat operator must be surrounded by a single space

Missing space after array opener.

Missing space before array closer.

	wp_enqueue_script('podlove-subscribe-button-admin-tools', plugin_dir_url(__FILE__). 'js/admin.js', array('jquery'));

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

Concat operator must be surrounded by a single space

Missing space after array opener.

Missing space before array closer.

} );

// Register Settings
add_action( 'admin_init', function () {
	$settings = array('size', 'autowidth', 'style', 'format', 'color');

Missing space after array opener.

Missing space before array closer.

	foreach ($settings as $setting) {

No space after opening parenthesis is prohibited

No space before closing parenthesis is prohibited

		register_setting( 'podlove-subscribe-button', 'podlove_subscribe_button_default_' . $setting );
	}
} );

add_shortcode( 'podlove-subscribe-button', array( 'PodloveSubscribeButton', 'shortcode' ) );

add_action( 'plugins_loaded', function () {
	load_plugin_textdomain( 'podlove-subscribe-button' );
} );


class PodloveSubscribeButton {

	public static function admin_menu() {
		add_options_page(
				'Podlove Subscribe Button Options',

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

				'Podlove Subscribe Button',

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

				'manage_options',

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

				'podlove-subscribe-button',

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

				array( 'PodloveSubscribeButton\Settings\Buttons', 'page')

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

Missing space before array closer.

			);

This line of the multi-line function call does not seem to be indented correctly. Expected 8 spaces, but found 12.

	}

	public static function admin_network_menu() {
		add_submenu_page(
				'settings.php',

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

				'Podlove Subscribe Button Options',

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

				'Podlove Subscribe Button',

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

				'manage_options',

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

				'podlove-subscribe-button',

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

				array( 'PodloveSubscribeButton\Settings\Buttons', 'page')

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

Missing space before array closer.

			);

This line of the multi-line function call does not seem to be indented correctly. Expected 8 spaces, but found 12.

	}

	public static function build_models() {
		// Build Databases
		\PodloveSubscribeButton\Model\Button::build();
		if ( is_multisite() )

It is generally a best practice to always use braces with control structures.

			\PodloveSubscribeButton\Model\NetworkButton::build();

		// Set Button "default" values
		$default_values = array(
				'size' => 'big',

Array item not aligned correctly; expected 12 spaces but found 16

Array double arrow not aligned correctly; expected 6 space(s) between "'size'" and double arrow, but found 1.

				'autowidth' => 'on',

Array item not aligned correctly; expected 12 spaces but found 16

				'color' => '#599677',

Array item not aligned correctly; expected 12 spaces but found 16

Array double arrow not aligned correctly; expected 5 space(s) between "'color'" and double arrow, but found 1.

				'style' => 'filled',

Array item not aligned correctly; expected 12 spaces but found 16

Array double arrow not aligned correctly; expected 5 space(s) between "'style'" and double arrow, but found 1.

				'format' => 'rectangle'

Array item not aligned correctly; expected 12 spaces but found 16

Array double arrow not aligned correctly; expected 4 space(s) between "'format'" and double arrow, but found 1.

Each array item in a multi-line array declaration must end in a comma

			);

Array closer not aligned correctly; expected 8 space(s) but found 12

		foreach ($default_values as $option => $default_value) {

No space after opening parenthesis is prohibited

No space before closing parenthesis is prohibited

			if ( ! get_option('podlove_subscribe_button_default_' . $option ) ) {

Expected 1 spaces after opening bracket; 0 found

				update_option('podlove_subscribe_button_default_' . $option, $default_value);

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			}
		}
	}

	public static function shortcode( $args ) {
		if ( ! $args || ! isset($args['button']) ) {

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			return __('You need to create a Button first and provide its ID.', 'podlove-subscribe-button');

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		} else {
			$buttonid = $args['button'];
		}

		// Fetch the (network)button by it's name
		if ( ! $button = \PodloveSubscribeButton\Model\Button::get_button_by_name($args['button']) )

This code seems to be duplicated across your project.

It is generally a best practice to always use braces with control structures.

Assignments must be the first block of code on a line

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			return sprintf( __('Oops. There is no button with the ID "%s".', 'podlove-subscribe-button'), $args['button'] );

A gettext call containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		// Get button styling and options
		$autowidth = self::interpret_width_attribute( self::get_array_value_with_fallback($args, 'width') );

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		$size = self::get_attribute( 'size', self::get_array_value_with_fallback($args, 'size') );

Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		$style = self::get_attribute( 'style', self::get_array_value_with_fallback($args, 'style') );

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		$format = self::get_attribute( 'format', self::get_array_value_with_fallback($args, 'format') );

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		$color = self::get_attribute( 'color', self::get_array_value_with_fallback($args, 'color') );

$color is not used, you could remove the assignment.

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		if ( isset($args['language']) ) {

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			$language = $args['language'];
		} else {
			$language = 'en';
		}

		if ( isset($args['color']) ) {

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			$color = $args['color'];
		} else {
			$color = get_option('podlove_subscribe_button_default_color', '#599677');

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		}

		if ( isset($args['hide']) && $args['hide'] == 'true' ) {

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

Use Yoda Condition checks, you must.

			$hide = TRUE;

TRUE, FALSE and NULL must be lowercase; expected true, but found TRUE.

		} else {
			$hide = FALSE;

TRUE, FALSE and NULL must be lowercase; expected false, but found FALSE.

		}

		// Render button
		return $button->render($size, $autowidth, $style, $format, $color, $hide, $buttonid, $language);

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

	}

	public static function get_array_value_with_fallback($args, $key) {

No space after opening parenthesis is prohibited

Expected 1 spaces between opening bracket and argument "$args"; 0 found

No space before closing parenthesis is prohibited

		if ( isset($args[$key]) )

It is generally a best practice to always use braces with control structures.

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

Array keys must be surrounded by spaces unless they contain a string or an integer.

			return $args[$key];

Array keys must be surrounded by spaces unless they contain a string or an integer.

		return FALSE;

TRUE, FALSE and NULL must be lowercase; expected false, but found FALSE.

	}

	/**
	 * @param  string $attribute
	 * @param  string $attribute_value
	 * @return string
	 */
	private static function get_attribute($attribute=NULL, $attribute_value=NULL) {

No space after opening parenthesis is prohibited

Expected 1 spaces between opening bracket and argument "$attribute"; 0 found

Incorrect spacing between argument "$attribute" and equals sign; expected 1 but found 0

Incorrect spacing between default value and equals sign for argument "$attribute"; expected 1 but found 0

TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.

Incorrect spacing between argument "$attribute_value" and equals sign; expected 1 but found 0

Incorrect spacing between default value and equals sign for argument "$attribute_value"; expected 1 but found 0

No space before closing parenthesis is prohibited

		if ( isset($attribute_value) && ctype_alnum($attribute_value) && key_exists( $attribute_value, \PodloveSubscribeButton\Model\Button::$$attribute ) ) {

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			return $attribute_value;
		} else {
			return get_option('podlove_subscribe_button_default_' . $attribute, \PodloveSubscribeButton\Model\Button::$properties[$attribute]);

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

Array keys must be surrounded by spaces unless they contain a string or an integer.

		}
	}

	/**
	 * Interprets the provided width attribute and return either auto- or a specific width
	 * @param  string $width_attribute
	 * @return string
	 */
	private static function interpret_width_attribute( $width_attribute = NULL ) {

TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.

		if ( $width_attribute == 'auto' )

It is generally a best practice to always use braces with control structures.

Use Yoda Condition checks, you must.

			return 'on';
		if ( $width_attribute && $width_attribute !== 'auto' )

The expression $width_attribute of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

It is generally a best practice to always use braces with control structures.

Use Yoda Condition checks, you must.

			return 'off';

		return get_option('podlove_subscribe_button_default_autowidth', 'on');

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

	}
}