cfoellmann /
podlove-subscribe-button-wp-plugin
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 103 |
| Code Lines | 61 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | (function($) { |
||
| 2 | |||
| 3 | function podlove_init_color_buttons() { |
||
| 4 | $(".podlove_subscribe_button_color").spectrum({ |
||
| 5 | preferredFormat: 'hex', |
||
| 6 | showInput: true, |
||
| 7 | palette: [ '#599677' ], |
||
| 8 | showPalette: true, |
||
| 9 | showSelectionPalette: false, |
||
| 10 | chooseText: "Select Color", |
||
| 11 | cancelText: "Cancel", |
||
| 12 | }); |
||
| 13 | } |
||
| 14 | |||
| 15 | $( document ).ready( function() { |
||
| 16 | |||
| 17 | podlove_init_color_buttons(); |
||
| 18 | |||
| 19 | $("#Podlove_cover_image_select").on( 'click', function(event) { |
||
|
|
|||
| 20 | podlove_cover_image_selector = wp.media.frames.customHeader = wp.media( { |
||
| 21 | title: "Media Library", |
||
| 22 | library: { |
||
| 23 | type: 'image' |
||
| 24 | }, |
||
| 25 | button: { |
||
| 26 | text: "Use for Podcast Cover Art" |
||
| 27 | }, |
||
| 28 | multiple: false |
||
| 29 | } ); |
||
| 30 | podlove_cover_image_selector.open(); |
||
| 31 | |||
| 32 | podlove_cover_image_selector.on('select', function() { |
||
| 33 | var podcast_image_url = podlove_cover_image_selector.state().get('selection').first().toJSON().url; |
||
| 34 | $("#podlove-button-cover").val(podcast_image_url); |
||
| 35 | $("#podlove-button-cover").trigger('change'); |
||
| 36 | }); |
||
| 37 | } ); |
||
| 38 | |||
| 39 | $(document).ready(function () { |
||
| 40 | podlove_init_color_buttons(); |
||
| 41 | |||
| 42 | jQuery(document).on('widget-updated', podlove_init_color_buttons); |
||
| 43 | jQuery(document).on('widget-added', podlove_init_color_buttons); |
||
| 44 | |||
| 45 | // re-init after saving configs |
||
| 46 | jQuery(document).on('ajaxComplete', function(e){ |
||
| 47 | podlove_init_color_buttons(); |
||
| 48 | }); |
||
| 49 | }) |
||
| 50 | |||
| 51 | var feed_counter = 0; |
||
| 52 | var source = $("#feed_line_template").html(); |
||
| 53 | |||
| 54 | $(".add_feed").on( 'click', function () { |
||
| 55 | add_new_feed(); |
||
| 56 | } ); |
||
| 57 | |||
| 58 | if ( window.feeds !== undefined ) { |
||
| 59 | $.each( feeds, function (index, feed) { |
||
| 60 | add_existing_feed(feed); |
||
| 61 | } ); |
||
| 62 | } |
||
| 63 | |||
| 64 | function add_new_feed() { |
||
| 65 | row = source.replace( /\{\{url\}\}/g, '' ); |
||
| 66 | row = row.replace( /\{\{itunesfeedid\}\}/g, '' ); |
||
| 67 | row = row.replace( /\{\{id\}\}/g, feed_counter ); |
||
| 68 | |||
| 69 | $("#feeds_table_body").append(row); |
||
| 70 | |||
| 71 | new_row = $("#feeds_table_body tr:last"); |
||
| 72 | new_row.find("input:first").focus(); |
||
| 73 | |||
| 74 | $(".podlove-icon-remove").on( 'click', function () { |
||
| 75 | $(this).closest("tr").remove(); |
||
| 76 | } ); |
||
| 77 | |||
| 78 | feed_counter++; |
||
| 79 | } |
||
| 80 | |||
| 81 | function add_existing_feed( feed ) { |
||
| 82 | row = source.replace( /\{\{url\}\}/g, feed.url ); |
||
| 83 | row = row.replace( /\{\{id\}\}/g, feed_counter ); |
||
| 84 | if ( feed.itunesfeedid == null ) { |
||
| 85 | row = row.replace( /\{\{itunesfeedid\}\}/g, '' ); |
||
| 86 | } else { |
||
| 87 | row = row.replace( /\{\{itunesfeedid\}\}/g, feed.itunesfeedid ); |
||
| 88 | } |
||
| 89 | |||
| 90 | $("#feeds_table_body").append(row); |
||
| 91 | |||
| 92 | new_row = $("#feeds_table_body tr:last"); |
||
| 93 | new_row.find('select.podlove-media-format option[value="' + feed.format + '"]').attr('selected',true); |
||
| 94 | |||
| 95 | $(".podlove-icon-remove").on( 'click', function () { |
||
| 96 | $(this).closest("tr").remove(); |
||
| 97 | } ); |
||
| 98 | |||
| 99 | feed_counter++; |
||
| 100 | } |
||
| 101 | |||
| 102 | } ); |
||
| 103 | }(jQuery)); |
Loading history...
This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function.