Button::get_button_by_name() - Code Metrics - cfoellmann/podlove-subscribe-button-wp-plugin - Measure and Improve Code Quality continuously with Scrutinizer

Button::get_button_by_name() A
last analyzed 2018-09-02 14:08 UTC

↳ Parent: Button

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	6
nc	3
nop	1
dl	0
loc	11
rs	10
c	0
b	0
f	0

<?php

introduced 2018-09-01 15:32 UTC by

Class file names should be based on the class name with "class-" prepended. Expected class-button.php, but found button.php.

Coding Style introduced 2018-09-01 15:32 UTC by

This file is missing a doc comment.

namespace PodloveSubscribeButton\Model;

class Button extends Base {

Coding Style Documentation introduced 2018-09-02 08:21 UTC by

Missing class doc comment

	public static $properties = array(

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing member variable doc comment

		// $property => $default value

		'size' => 'big',

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 6 space(s) between "'size'" and double arrow, but found 1.

		'color' => '#599677',

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 5 space(s) between "'color'" and double arrow, but found 1.

		'autowidth' => 'on',

		'style' => 'filled',

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 5 space(s) between "'style'" and double arrow, but found 1.

		'format' => 'rectangle',

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 4 space(s) between "'format'" and double arrow, but found 1.

		'hide' => 'false',

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 6 space(s) between "'hide'" and double arrow, but found 1.

		'buttonid' => ''

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 2 space(s) between "'buttonid'" and double arrow, but found 1.

introduced 2018-09-01 15:32 UTC by

Each array item in a multi-line array declaration must end in a comma

		// Note: the fields 'language' and 'json-data' cannot be set here (No function call allowed within class variables)

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

);

	public static $style = array(

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing member variable doc comment

		'filled' => 'Filled',

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 4 space(s) between "'filled'" and double arrow, but found 1.

		'outline' => 'Outline',

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 3 space(s) between "'outline'" and double arrow, but found 1.

		'frameless' => 'Frameless'

introduced 2018-09-01 15:32 UTC by

Each array item in a multi-line array declaration must end in a comma

);

	public static $format = array(

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing member variable doc comment

		'rectangle' => 'Rectangle',

		'square' => 'Square',

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 4 space(s) between "'square'" and double arrow, but found 1.

		'cover' => 'Cover'

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 5 space(s) between "'cover'" and double arrow, but found 1.

introduced 2018-09-01 15:32 UTC by

Each array item in a multi-line array declaration must end in a comma

);

	public static $width = array(

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing member variable doc comment

		'on' => 'Yes',

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 2 space(s) between "'on'" and double arrow, but found 1.

		'off' => 'No'

introduced 2018-09-01 15:32 UTC by

Each array item in a multi-line array declaration must end in a comma

);

	public static $size = array(

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing member variable doc comment

		'small' => 'Small',

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 2 space(s) between "'small'" and double arrow, but found 1.

		'medium' => 'Medium',

		'big' => 'Big'

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 4 space(s) between "'big'" and double arrow, but found 1.

introduced 2018-09-01 15:32 UTC by

Each array item in a multi-line array declaration must end in a comma

);

/**

	 * Fetches a Button or Network Button with a specific name

	 * @param  string $name

Coding Style introduced 2018-09-01 15:32 UTC by

There must be exactly one blank line before the tags in a doc comment

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing parameter comment

	 * @return object||FALSE

Documentation Bug introduced 2018-09-01 15:32 UTC by

The doc comment object||FALSE at position 2 could not be parsed: Unknown type name '|' at position 2 in object||FALSE.

*/

	public static function get_button_by_name($name) {

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces between opening bracket and argument "$name"; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "Button::get_button_by_name" is not in camel caps format

introduced 2018-09-01 15:32 UTC by

No space after opening parenthesis is prohibited

introduced 2018-09-01 15:32 UTC by

No space before closing parenthesis is prohibited

		if ( $button = \PodloveSubscribeButton\Model\Button::find_one_by_property('name', $name) ) {

introduced 2018-09-01 15:32 UTC by

Variable assignment found within a condition. Did you mean to do a comparison?

Coding Style introduced 2018-09-01 15:32 UTC by

Assignments must be the first block of code on a line

Coding Style introduced 2018-09-01 15:32 UTC by

As per coding style, self should be used for accessing local static members.

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

			return $button;

		if ( $network_button = \PodloveSubscribeButton\Model\NetworkButton::find_one_by_property('name', $name) ) {

introduced 2018-09-01 15:32 UTC by

Variable assignment found within a condition. Did you mean to do a comparison?

Coding Style introduced 2018-09-01 15:32 UTC by

Assignments must be the first block of code on a line

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

			$network_button->id = $network_button->id . 'N';

			return $network_button;

		return false;

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

/**

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Doc comment for parameter "$settings" missing

	 * Returns either global buttons settings or the default settings

	 * @param  array

Coding Style introduced 2018-09-01 15:32 UTC by

There must be exactly one blank line before the tags in a doc comment

Coding Style introduced 2018-09-01 15:32 UTC by

Missing parameter name

	 * @return array

*/

	public static function get_global_setting_with_fallback( $settings=array() ) {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "Button::get_global_setting_with_fallback" is not in camel caps format

Coding Style introduced 2018-09-01 15:32 UTC by

Incorrect spacing between argument "$settings" and equals sign; expected 1 but found 0

Coding Style introduced 2018-09-01 15:32 UTC by

Incorrect spacing between default value and equals sign for argument "$settings"; expected 1 but found 0

		foreach (self::$properties as $property => $default) {

introduced 2018-09-01 15:32 UTC by

No space after opening parenthesis is prohibited

introduced 2018-09-01 15:32 UTC by

No space before closing parenthesis is prohibited

			$settings[$property] = ( get_option('podlove_subscribe_button_default_' . $property) ? get_option('podlove_subscribe_button_default_' . $property) : $default );

introduced 2018-09-01 15:32 UTC by

Array keys must be surrounded by spaces unless they contain a string or an integer.

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

		return $settings;

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

/**

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Doc comment for parameter "$language" missing

	 * Gathers all information and renders the Subscribe button.

	 * @param  string  $size

Coding Style introduced 2018-09-01 15:32 UTC by

There must be exactly one blank line before the tags in a doc comment

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing parameter comment

	 * @param  string  $autowidth

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing parameter comment

	 * @param  string  $style

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing parameter comment

	 * @param  string  $format

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing parameter comment

	 * @param  string  $color

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing parameter comment

	 * @param  boolean $hide

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing parameter comment

	 * @param  boolean $buttonid

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing parameter comment

	 * @return string

*/

	public function render( $size='big', $autowidth='on', $style='filled', $format='rectangle', $color='#599677', $hide = false, $buttonid = false, $language='en' ) {

Coding Style introduced 2018-09-01 15:32 UTC by

Incorrect spacing between argument "$size" and equals sign; expected 1 but found 0

Coding Style introduced 2018-09-01 15:32 UTC by

Incorrect spacing between default value and equals sign for argument "$size"; expected 1 but found 0

Coding Style introduced 2018-09-01 15:32 UTC by

Incorrect spacing between argument "$autowidth" and equals sign; expected 1 but found 0

Coding Style introduced 2018-09-01 15:32 UTC by

Incorrect spacing between default value and equals sign for argument "$autowidth"; expected 1 but found 0

Coding Style introduced 2018-09-01 15:32 UTC by

Incorrect spacing between argument "$style" and equals sign; expected 1 but found 0

Coding Style introduced 2018-09-01 15:32 UTC by

Incorrect spacing between default value and equals sign for argument "$style"; expected 1 but found 0

Coding Style introduced 2018-09-01 15:32 UTC by

Incorrect spacing between argument "$format" and equals sign; expected 1 but found 0

Coding Style introduced 2018-09-01 15:32 UTC by

Incorrect spacing between default value and equals sign for argument "$format"; expected 1 but found 0

Coding Style introduced 2018-09-01 15:32 UTC by

Incorrect spacing between argument "$color" and equals sign; expected 1 but found 0

Coding Style introduced 2018-09-01 15:32 UTC by

Incorrect spacing between default value and equals sign for argument "$color"; expected 1 but found 0

Coding Style introduced 2018-09-01 15:32 UTC by

Incorrect spacing between argument "$language" and equals sign; expected 1 but found 0

Coding Style introduced 2018-09-01 15:32 UTC by

Incorrect spacing between default value and equals sign for argument "$language"; expected 1 but found 0

		$button_styling = array_merge(

				$this->get_button_styling($size, $autowidth, $style, $format, $color),

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

				array(

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

						'hide' => $hide,

introduced 2018-09-01 15:32 UTC by

Array item not aligned correctly; expected 20 spaces but found 24

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 5 space(s) between "'hide'" and double arrow, but found 1.

						'buttonid' => $buttonid,

introduced 2018-09-01 15:32 UTC by

Array item not aligned correctly; expected 20 spaces but found 24

						'language' => $language

introduced 2018-09-01 15:32 UTC by

Array item not aligned correctly; expected 20 spaces but found 24

introduced 2018-09-01 15:32 UTC by

Each array item in a multi-line array declaration must end in a comma

introduced 2018-09-01 15:32 UTC by

Array closer not aligned correctly; expected 16 space(s) but found 20

);

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 8 spaces, but found 12.

		return $this->provide_button_html(

			array(

				'title' => $this->title,

Bug Best Practice introduced 2018-09-01 15:32 UTC by

The property title does not exist on PodloveSubscribeButton\Model\Button. Since you implemented __get, consider adding a @property annotation.

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 7 space(s) between "'title'" and double arrow, but found 1.

				'subtitle' => $this->subtitle,

Bug Best Practice introduced 2018-09-01 15:32 UTC by

The property subtitle does not exist on PodloveSubscribeButton\Model\Button. Since you implemented __get, consider adding a @property annotation.

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 4 space(s) between "'subtitle'" and double arrow, but found 1.

				'description' => $this->description,

Bug Best Practice introduced 2018-09-01 15:32 UTC by

The property description does not exist on PodloveSubscribeButton\Model\Button. Since you implemented __get, consider adding a @property annotation.

				'cover' => $this->cover,

Bug Best Practice introduced 2018-09-01 15:32 UTC by

The property cover does not exist on PodloveSubscribeButton\Model\Button. Since you implemented __get, consider adding a @property annotation.

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 7 space(s) between "'cover'" and double arrow, but found 1.

100

				'feeds' => $this->get_feeds_as_array($this->feeds)

Bug Best Practice introduced 2018-09-01 15:32 UTC by

The property feeds does not exist on PodloveSubscribeButton\Model\Button. Since you implemented __get, consider adding a @property annotation.

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 7 space(s) between "'feeds'" and double arrow, but found 1.

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

introduced 2018-09-01 15:32 UTC by

Each array item in a multi-line array declaration must end in a comma

101

			), $button_styling );

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 8 spaces, but found 12.

102

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

103

104

/**

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Doc comment for parameter "$feeds" missing

105

	 * Provides the feed as an array in the required format

106

	 * @return array

Coding Style introduced 2018-09-01 15:32 UTC by

There must be exactly one blank line before the tags in a doc comment

107

*/

108

	private function get_feeds_as_array( $feeds=array() ) {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "Button::get_feeds_as_array" is not in camel caps format

Coding Style introduced 2018-09-01 15:32 UTC by

Incorrect spacing between argument "$feeds" and equals sign; expected 1 but found 0

Coding Style introduced 2018-09-01 15:32 UTC by

Incorrect spacing between default value and equals sign for argument "$feeds"; expected 1 but found 0

109

		foreach ($feeds as $feed) {

introduced 2018-09-01 15:32 UTC by

No space after opening parenthesis is prohibited

introduced 2018-09-01 15:32 UTC by

No space before closing parenthesis is prohibited

110

			if ( isset(\PodloveSubscribeButton\MediaTypes::$audio[$feed['format']]['extension']) ) {

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

introduced 2018-09-01 15:32 UTC by

Array keys must be surrounded by spaces unless they contain a string or an integer.

111

				$new_feed = array(

112

						'type' => 'audio',

introduced 2018-09-01 15:32 UTC by

Array item not aligned correctly; expected 20 spaces but found 24

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 4 space(s) between "'type'" and double arrow, but found 1.

113

						'format' => \PodloveSubscribeButton\MediaTypes::$audio[$feed['format']]['extension'],

introduced 2018-09-01 15:32 UTC by

Array item not aligned correctly; expected 20 spaces but found 24

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 2 space(s) between "'format'" and double arrow, but found 1.

introduced 2018-09-01 15:32 UTC by

Array keys must be surrounded by spaces unless they contain a string or an integer.

114

						'url' => $feed['url'],

introduced 2018-09-01 15:32 UTC by

Array item not aligned correctly; expected 20 spaces but found 24

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 5 space(s) between "'url'" and double arrow, but found 1.

115

						'variant' => 'high'

introduced 2018-09-01 15:32 UTC by

Array item not aligned correctly; expected 20 spaces but found 24

introduced 2018-09-01 15:32 UTC by

Each array item in a multi-line array declaration must end in a comma

116

);

introduced 2018-09-01 15:32 UTC by

Array closer not aligned correctly; expected 16 space(s) but found 20

117

118

				if ( isset($feed['itunesfeedid']) && $feed['itunesfeedid'] > 0 )

Coding Style Best Practice introduced 2018-09-01 15:32 UTC by

It is generally a best practice to always use braces with control structures.

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

119

					$new_feed['directory-url-itunes'] = "https://itunes.apple.com/podcast/id" . $feed['itunesfeedid'];

Coding Style Comprehensibility introduced 2018-09-01 15:32 UTC by

The string literal https://itunes.apple.com/podcast/id does not require double quotes, as per coding-style, please use single quotes.

120

121

				$feeds[] = $new_feed;

122

123

124

125

		return $feeds;

126

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

127

128

/**

129

	 * Provides the HTML source of the Subscribe Button

130

	 * @param  array $podcast_data

Coding Style introduced 2018-09-01 15:32 UTC by

There must be exactly one blank line before the tags in a doc comment

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing parameter comment

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 2 spaces after parameter type; 1 found

131

	 * @param  array $button_styling

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing parameter comment

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 2 spaces after parameter type; 1 found

132

	 * @param  string $data_attributes

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing parameter comment

133

	 * @return string

134

*/

135

	private function provide_button_html($podcast_data, $button_styling, $data_attributes="") {

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces between opening bracket and argument "$podcast_data"; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "Button::provide_button_html" is not in camel caps format

introduced 2018-09-01 15:32 UTC by

No space after opening parenthesis is prohibited

Coding Style introduced 2018-09-01 15:32 UTC by

Incorrect spacing between argument "$data_attributes" and equals sign; expected 1 but found 0

Coding Style introduced 2018-09-01 15:32 UTC by

Incorrect spacing between default value and equals sign for argument "$data_attributes"; expected 1 but found 0

Coding Style Comprehensibility introduced 2018-09-01 15:32 UTC by

The string literal does not require double quotes, as per coding-style, please use single quotes.

introduced 2018-09-01 15:32 UTC by

No space before closing parenthesis is prohibited

136

		// Create data attributes for Button

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

137

		foreach ($button_styling as $attribute => $value) {

introduced 2018-09-01 15:32 UTC by

No space after opening parenthesis is prohibited

introduced 2018-09-01 15:32 UTC by

No space before closing parenthesis is prohibited

138

			$data_attributes .= 'data-' . $attribute . '="' . $value . '" ';

139

140

141

		return"

Coding Style Comprehensibility introduced 2018-08-31 12:09 UTC by

The string literal \n <script>\n... podcastData does not require double quotes, as per coding-style, please use single quotes.

Coding Style introduced 2018-09-01 15:32 UTC by

Language constructs must be followed by a single space; expected "return "
" but found "return"
"

142

			<script>

143

				podcastData".$this->id . " = ".json_encode($podcast_data)."

Coding Style Comprehensibility introduced 2018-08-31 12:09 UTC by

The string literal \n </script>\...n/javascripts/app.js\" does not require double quotes, as per coding-style, please use single quotes.

Coding Style introduced 2018-09-01 15:32 UTC by

Concat operator must be surrounded by a single space

Coding Style Comprehensibility introduced 2018-09-01 15:32 UTC by

The string literal = does not require double quotes, as per coding-style, please use single quotes.

introduced 2018-09-01 15:32 UTC by

json_encode() is discouraged. Use wp_json_encode() instead.

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

144

			</script>

145

			<script

146

				class=\"podlove-subscribe-button\"

147

				src=\"https://cdn.podlove.org/subscribe-button/javascripts/app.js\" " . $data_attributes . ">

Coding Style Comprehensibility introduced 2018-08-31 12:09 UTC by

The string literal >\n </script>\n does not require double quotes, as per coding-style, please use single quotes.

148

			</script>

149

";

150

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

151

152

/**

153

	 * Returns an array with either the set or default values

154

	 * @param  string $size

Coding Style introduced 2018-09-01 15:32 UTC by

There must be exactly one blank line before the tags in a doc comment

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing parameter comment

155

	 * @param  string $autowidth

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing parameter comment

156

	 * @param  string $style

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing parameter comment

157

	 * @param  string $format

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing parameter comment

158

	 * @param  string $color

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing parameter comment

159

	 * @return array

160

*/

161

	public function get_button_styling($size, $autowidth, $style, $format, $color) {

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces between opening bracket and argument "$size"; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "Button::get_button_styling" is not in camel caps format

introduced 2018-09-01 15:32 UTC by

No space after opening parenthesis is prohibited

introduced 2018-09-01 15:32 UTC by

No space before closing parenthesis is prohibited

162

163

		return array(

164

				// $attribute => $value

Unused Code Comprehensibility introduced 2018-09-01 15:32 UTC by

50% of this comment could be valid code. Did you maybe forget this after debugging?

introduced 2018-09-01 15:32 UTC by

Array item not aligned correctly; expected 12 spaces but found 16

165

				'size' => ( $size == 'default' ? get_option('podlove_subscribe_button_default_size', $size) : $size )

Bug introduced 2018-09-01 15:32 UTC by

Are you sure $size == 'default' ? get...t_size', $size) : $size of type mixed|false|string can be used in concatenation? ( Ignorable by Annotation )

introduced 2018-09-01 15:32 UTC by

Multi-line array item not aligned correctly; expected 12 spaces, but found 16

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 6 space(s) between "'size'" and double arrow, but found 1.

introduced 2018-09-01 15:32 UTC by

Found: ==. Use strict comparisons (=== or !==).

introduced 2018-09-01 15:32 UTC by

Use Yoda Condition checks, you must.

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

166

			 	. self::interpret_autowidth_attribute($autowidth),

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

167

				'style' => ( $style == 'default' ? get_option('podlove_subscribe_button_default_style', $style) : $style ),

introduced 2018-09-01 15:32 UTC by

Array item not aligned correctly; expected 12 spaces but found 16

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 5 space(s) between "'style'" and double arrow, but found 1.

introduced 2018-09-01 15:32 UTC by

Found: ==. Use strict comparisons (=== or !==).

introduced 2018-09-01 15:32 UTC by

Use Yoda Condition checks, you must.

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

168

				'format' => ( $format == 'default' ? get_option('podlove_subscribe_button_default_format', $format) : $format ),

introduced 2018-09-01 15:32 UTC by

Array item not aligned correctly; expected 12 spaces but found 16

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 4 space(s) between "'format'" and double arrow, but found 1.

introduced 2018-09-01 15:32 UTC by

Found: ==. Use strict comparisons (=== or !==).

introduced 2018-09-01 15:32 UTC by

Use Yoda Condition checks, you must.

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

169

				'color' => ( isset($color) ? $color : get_option('podlove_subscribe_button_default_color', $color) ),

introduced 2018-09-01 15:32 UTC by

Array item not aligned correctly; expected 12 spaces but found 16

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 5 space(s) between "'color'" and double arrow, but found 1.

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

170

				'json-data' => 'podcastData' . $this->id

introduced 2018-09-01 15:32 UTC by

Array item not aligned correctly; expected 12 spaces but found 16

introduced 2018-09-01 15:32 UTC by

Each array item in a multi-line array declaration must end in a comma

171

);

introduced 2018-09-01 15:32 UTC by

Array closer not aligned correctly; expected 8 space(s) but found 12

172

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

173

174

/**

175

	 * Helper function to interpret the given $autowidth value correctly

176

	 * @param  string $autowidth

Coding Style introduced 2018-09-01 15:32 UTC by

There must be exactly one blank line before the tags in a doc comment

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing parameter comment

177

	 * @return string

178

*/

179

	private static function interpret_autowidth_attribute($autowidth) {

Coding Style introduced 2018-08-31 12:09 UTC by

Expected 1 spaces between opening bracket and argument "$autowidth"; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "Button::interpret_autowidth_attribute" is not in camel caps format

introduced 2018-09-01 15:32 UTC by

No space after opening parenthesis is prohibited

introduced 2018-09-01 15:32 UTC by

No space before closing parenthesis is prohibited

180

		if ( $autowidth == 'default' && get_option('podlove_subscribe_button_default_autowidth') !== 'on' )

Coding Style Best Practice introduced 2018-09-01 15:32 UTC by

It is generally a best practice to always use braces with control structures.

introduced 2018-09-01 15:32 UTC by

Found: ==. Use strict comparisons (=== or !==).

introduced 2018-09-01 15:32 UTC by

Use Yoda Condition checks, you must.

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

181

			return '';

182

183

		if ( $autowidth !== 'default' && $autowidth !== 'on' )

Coding Style Best Practice introduced 2018-09-01 15:32 UTC by

It is generally a best practice to always use braces with control structures.

introduced 2018-09-01 15:32 UTC by

Use Yoda Condition checks, you must.

184

			return '';

185

186

		return ' auto';

187

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

188

189

190

Button::property( 'id', 'INT NOT NULL AUTO_INCREMENT PRIMARY KEY' );

191

Button::property( 'name', 'VARCHAR(255)' );

192

Button::property( 'title', 'VARCHAR(255)' );

193

Button::property( 'subtitle', 'VARCHAR(255)' );

194

Button::property( 'description', 'TEXT' );

195

Button::property( 'cover', 'VARCHAR(255)' );

196

Button::property( 'feeds', 'TEXT' );

cfoellmann / podlove-subscribe-button-wp-plugin

Button::get_button_by_name() A last analyzed 2018-09-02 14:08 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Button::get_button_by_name() A
last analyzed 2018-09-02 14:08 UTC