QueryFilters::applyToQuery() - Code Metrics - Inspection of "Merge branch 'release/1.0.0'" - cerbero90/query-filters - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 49a390...e48438 )

by Andrea Marco

created 2016-04-25 15:09 UTC

QueryFilters::applyToQuery() A

↳ Parent: QueryFilters

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	14
rs	9.4285
cc	3
eloc	7
nc	3
nop	1

<?php

namespace Cerbero\QueryFilters;

use Illuminate\Database\Eloquent\Builder;
use Illuminate\Http\Request;
use Illuminate\Support\Str;

/**
 * Abstract implementation of a query filters applier.
 *
 */
abstract class QueryFilters
{
    /**
     * The current HTTP request.
     *
     * @var Illuminate\Http\Request
     */
    protected $request;

    /**
     * Eloquent query builder.
     *
     * @var     Illuminate\Database\Eloquent\Builder
     */
    protected $query;

    /**
     * Set the dependencies.
     *
     * @param    Request    $request
     * @return    void

     */
    public function __construct(Request $request)

    {
        $this->request = $request;

    }

    /**
     * Apply all the filters to the given query.
     *
     * @param    Illuminate\Database\Eloquent\Builder    $query
     * @return    Illuminate\Database\Eloquent\Builder
     */
    public function applyToQuery(Builder $query)
    {
        $this->query = $query;


        foreach ($this->request->all() as $filter => $value) {
            $method = Str::camel($filter);

            if (method_exists($this, $method)) {
                call_user_func([$this, $method], $value);
            }
        }

        return $query;
    }
}


1			<?php
2
3			namespace Cerbero\QueryFilters;
4
5			use Illuminate\Database\Eloquent\Builder;
6			use Illuminate\Http\Request;
7			use Illuminate\Support\Str;
8
9			/**
10			* Abstract implementation of a query filters applier.
11			*
12			*/
13			abstract class QueryFilters
14			{
15			/**
16			* The current HTTP request.
17			*
18			* @var Illuminate\Http\Request
19			*/
20			protected $request;
21
22			/**
23			* Eloquent query builder.
24			*
25			* @var Illuminate\Database\Eloquent\Builder
26			*/
27			protected $query;
28
29			/**
30			* Set the dependencies.
31			*
32			* @param Request $request
33			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-04-25 15:00 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
34			*/
35			public function __construct(Request $request)
			0 ignored issues – show Bug introduced 2016-04-25 15:00 UTC by Report Bug Copy Issue Report You have injected the Request via parameter `$request`. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via `getCurrentRequest()`. Loading history...
36			{
37			$this->request = $request;
			0 ignored issues – show Documentation Bug introduced 2016-04-25 15:00 UTC by Report Bug Copy Issue Report It seems like `$request` of type `object<Illuminate\Http\Request>` is incompatible with the declared type `object<Cerbero\QueryFilt...lluminate\Http\Request>` of property `$request`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
38			}
39
40			/**
41			* Apply all the filters to the given query.
42			*
43			* @param Illuminate\Database\Eloquent\Builder $query
44			* @return Illuminate\Database\Eloquent\Builder
45			*/
46			public function applyToQuery(Builder $query)
47			{
48			$this->query = $query;
			0 ignored issues – show Documentation Bug introduced 2016-04-25 15:00 UTC by Report Bug Copy Issue Report It seems like `$query` of type `object<Illuminate\Database\Eloquent\Builder>` is incompatible with the declared type `object<Cerbero\QueryFilt...abase\Eloquent\Builder>` of property `$query`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
49
50			foreach ($this->request->all() as $filter => $value) {
51			$method = Str::camel($filter);
52
53			if (method_exists($this, $method)) {
54			call_user_func([$this, $method], $value);
55			}
56			}
57
58			return $query;
59			}
60			}
61

cerbero90 / query-filters

Push — master ( 49a390...e48438 )

QueryFilters::applyToQuery() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like