cerbero90 / octane-testbench

src/Concerns/MakesHttpRequests.php

<?php

namespace Cerbero\OctaneTestbench\Concerns;

use Cerbero\OctaneTestbench\ResponseTestCase;
use Cerbero\OctaneTestbench\Stubs\ApplicationFactoryStub;
use Cerbero\OctaneTestbench\Stubs\ClientStub;
use Cerbero\OctaneTestbench\Stubs\WorkerStub;
use Illuminate\Http\Request;
use Laravel\Octane\Contracts\Client;
use Symfony\Component\HttpFoundation\Request as SymfonyRequest;

/**
 * The trait to make HTTP requests.
 *
 */
trait MakesHttpRequests
{
    /**
     * Call the given URI via Laravel Octane.
     *
     * @param string $method
     * @param string $uri
     * @param array $parameters
     * @param array $cookies
     * @param array $files
     * @param array $server
     * @param string|null $content
     * @return ResponseTestCase
     */
    public function call($method, $uri, $parameters = [], $cookies = [], $files = [], $server = [], $content = null)
    {
        $request = SymfonyRequest::create(
            $this->prepareUrlForRequest($uri),

It seems like prepareUrlForRequest() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $method,
            $parameters,
            $cookies,
            array_merge($files, $this->extractFilesFromDataArray($parameters)),

It seems like extractFilesFromDataArray() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            array_replace($this->serverVariables, $server),
            $content,
        );

        return $this->sendToOctane(Request::createFromBase($request));
    }

    /**
     * Send a request to Laravel Octane.
     *
     * @param Request $request
     * @return ResponseTestCase
     */
    public function sendToOctane(Request $request): ResponseTestCase
    {
        $factory = new ApplicationFactoryStub($this->app);
        $client = new ClientStub($this);

$this of type Cerbero\OctaneTestbench\Concerns\MakesHttpRequests is incompatible with the type PHPUnit\Framework\TestCase expected by parameter $testCase of Cerbero\OctaneTestbench\Stubs\ClientStub::__construct().

        $worker = new WorkerStub($factory, $client);

        $this->app->instance(Client::class, $client);

        $worker->boot();

        return $worker->runRequest($request);
    }
}