cerbero90 / lazy-json-pages

src/Paginations/LastPageAwarePagination.php

<?php

declare(strict_types=1);

namespace Cerbero\LazyJsonPages\Paginations;

use Cerbero\LazyJsonPages\Concerns\YieldsItemsByLength;
use Traversable;

/**
 * The pagination aware of the number of the last page.
 */
class LastPageAwarePagination extends Pagination
{
    use YieldsItemsByLength;

The trait Cerbero\LazyJsonPages\Concerns\YieldsItemsByLength requires some properties which are not provided by Cerbero\LazyJsonPages\Paginations\LastPageAwarePagination: $attempts, $backoff, $firstPage, $async, $rateLimits

    /**
     * Determine whether this pagination matches the configuration.
     */
    public function matches(): bool
    {
        return $this->config->lastPageKey !== null;
    }

    /**
     * Yield the paginated items.
     *
     * @return Traversable<int, mixed>
     */
    public function getIterator(): Traversable
    {
        /** @phpstan-ignore-next-line */
        yield from $this->yieldItemsUntilKey($this->config->lastPageKey, function (int $page) {

It seems like $this->config->lastPageKey can also be of type null; however, parameter $key of Cerbero\LazyJsonPages\Paginations\LastPageAwarePagination::yieldItemsUntilKey() does only seem to accept string, maybe add an additional type check?

            return $this->config->firstPage === 0 ? $page + 1 : $page;
        });
    }
}