DeleteIfForcedTrait::deleteIfForced() - Code Metrics - cerbero90/Workflow - Measure and Improve Code Quality continuously with Scrutinizer

DeleteIfForcedTrait::deleteIfForced() A
last analyzed 2016-07-26 13:50 UTC

↳ Parent: DeleteIfForcedTrait

Complexity

Conditions	4
Paths	4

Size

Total Lines	12
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	12
rs	9.2
cc	4
eloc	5
nc	4
nop	1

<?php namespace Cerbero\Workflow\Console\Commands;

/**
 * Trait to delete files if forced.
 *
 * @author	Andrea Marco Sartori
 */
trait DeleteIfForcedTrait {

	/**
	 * Delete the given files if force is set.
	 *
	 * @author	Andrea Marco Sartori
	 * @return	void
	 */
	protected function deleteIfForced(array $files)
	{
		if( ! $this->option('force')) return;
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

		foreach ($files as $file)
		{
			if($this->files->exists($path = $this->getPath($file)))
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
			{
				$this->files->delete($path);
class MyClass { }

$x = new MyClass();
$x->foo = true;
			}
		}
	}

}


1			<?php namespace Cerbero\Workflow\Console\Commands;
2
3			/**
4			* Trait to delete files if forced.
5			*
6			* @author Andrea Marco Sartori
7			*/
8			trait DeleteIfForcedTrait {
9
10			/**
11			* Delete the given files if force is set.
12			*
13			* @author Andrea Marco Sartori
14			* @return void
15			*/
16			protected function deleteIfForced(array $files)
17			{
18			if( ! $this->option('force')) return;
			0 ignored issues – show Bug introduced 2015-12-22 04:38 UTC by Report Bug Copy Issue Report It seems like `option()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
19
20			foreach ($files as $file)
21			{
22			if($this->files->exists($path = $this->getPath($file)))
			0 ignored issues – show Bug introduced 2015-12-22 04:38 UTC by Report Bug Copy Issue Report It seems like `getPath()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
23			{
24			$this->files->delete($path);
			0 ignored issues – show Bug introduced 2015-12-22 04:38 UTC by Report Bug Copy Issue Report The property `files` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
25			}
26			}
27			}
28
29			}
30

cerbero90 / Workflow

DeleteIfForcedTrait::deleteIfForced() A last analyzed 2016-07-26 13:50 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

DeleteIfForcedTrait::deleteIfForced() A
last analyzed 2016-07-26 13:50 UTC