Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
13 | trait EmphStrongTrait |
||
14 | { |
||
15 | /** |
||
16 | * Parses empathized and strong elements. |
||
17 | * @marker _ |
||
18 | * @marker * |
||
19 | */ |
||
20 | 33 | protected function parseEmphStrong($text) |
|
21 | { |
||
22 | 33 | $marker = $text[0]; |
|
23 | |||
24 | 33 | if (!isset($text[1])) { |
|
25 | 3 | return [['text', $text[0]], 1]; |
|
26 | } |
||
27 | |||
28 | 33 | if ($marker == $text[1]) { // strong |
|
29 | // work around a PHP bug that crashes with a segfault on too much regex backtrack |
||
30 | // check whether the end marker exists in the text |
||
31 | // https://github.com/erusev/parsedown/issues/443 |
||
32 | // https://bugs.php.net/bug.php?id=45735 |
||
33 | 27 | if (strpos($text, $marker . $marker, 2) === false) { |
|
34 | 6 | return [['text', $text[0] . $text[1]], 2]; |
|
35 | } |
||
36 | |||
37 | 21 | View Code Duplication | if ($marker == '*' && preg_match('/^[*]{2}((?:[^*]|[*][^*]*[*])+?)[*]{2}(?![*]{2})/s', $text, $matches) || |
38 | 21 | $marker == '_' && preg_match('/^__((?:[^_]|_[^_]*_)+?)__(?!__)/us', $text, $matches)) { |
|
39 | |||
40 | return [ |
||
41 | [ |
||
42 | 21 | 'strong', |
|
43 | 21 | $this->parseInline($matches[1]), |
|
44 | 21 | ], |
|
45 | 21 | strlen($matches[0]) |
|
46 | 21 | ]; |
|
47 | } |
||
48 | } else { // emph |
||
49 | // work around a PHP bug that crashes with a segfault on too much regex backtrack |
||
50 | // check whether the end marker exists in the text |
||
51 | // https://github.com/erusev/parsedown/issues/443 |
||
52 | // https://bugs.php.net/bug.php?id=45735 |
||
53 | 21 | if (strpos($text, $marker, 1) === false) { |
|
54 | 10 | return [['text', $text[0]], 1]; |
|
55 | } |
||
56 | |||
57 | 16 | View Code Duplication | if ($marker == '*' && preg_match('/^[*]((?:[^*]|[*][*][^*]+?[*][*])+?)[*](?![*][^*])/s', $text, $matches) || |
1 ignored issue
–
show
|
|||
58 | 16 | $marker == '_' && preg_match('/^_((?:[^_]|__[^_]*__)+?)_(?!_[^_])\b/us', $text, $matches)) { |
|
59 | return [ |
||
60 | [ |
||
61 | 15 | 'emph', |
|
62 | 15 | $this->parseInline($matches[1]), |
|
63 | 15 | ], |
|
64 | 15 | strlen($matches[0]) |
|
65 | 15 | ]; |
|
66 | } |
||
67 | } |
||
68 | 5 | return [['text', $text[0]], 1]; |
|
69 | } |
||
70 | |||
71 | 21 | protected function renderStrong($block) |
|
75 | |||
76 | 15 | protected function renderEmph($block) |
|
80 | } |
||
81 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.