FilteredTrait::getFiltered() - Code Metrics - Inspection of "Добавил немного экшенов" - cdek-it/sdk2.0 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#4)

unknown

created 2020-05-03 11:50 UTC

FilteredTrait::getFiltered() A

↳ Parent: FilteredTrait

Complexity

Conditions	5
Paths	3

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	5

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
eloc	9
c	1
b	0
f	1
dl	0
loc	14
ccs	10
cts	10
cp	1
rs	9.6111
cc	5
nc	3
nop	1
crap	5

<?php

declare(strict_types=1);

namespace CdekSDK2\Actions;

use CdekSDK2\Constants;
use CdekSDK2\Http\ApiResponse;

trait FilteredTrait
{
    /**
     * @param array $filter
     * @return ApiResponse
     */
    public function getFiltered(array $filter = []): ApiResponse
    {
        $add_params = '';
        if (!empty($filter)) {
            $filtered = [];
            foreach ($filter as $k => $v) {
                if (array_key_exists($k, Constants::OFFICE_FILTER)) {
                    $filtered[$k] = $v;
                }
            }
            $filter = array_replace(Constants::OFFICE_FILTER, $filtered);
            $add_params = empty($filter) ? '' : http_build_query($filter);
        }
        return $this->get($add_params);
    }

    /**
     * Переиспользуем стандартный метод
     * @param string $filter
     * @return ApiResponse
     */
    public function get(string $filter = ''): ApiResponse
    {
        return $this->http_client->get(self::URL . '?' . $filter);

    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace CdekSDK2\Actions;
6
7		use CdekSDK2\Constants;
8		use CdekSDK2\Http\ApiResponse;
9
10		trait FilteredTrait
11		{
12		/**
13		* @param array $filter
14		* @return ApiResponse
15		*/
16	2	public function getFiltered(array $filter = []): ApiResponse
17		{
18	2	$add_params = '';
19	2	if (!empty($filter)) {
20	2	$filtered = [];
21	2	foreach ($filter as $k => $v) {
22	2	if (array_key_exists($k, Constants::OFFICE_FILTER)) {
23	2	$filtered[$k] = $v;
24		}
25		}
26	2	$filter = array_replace(Constants::OFFICE_FILTER, $filtered);
27	2	$add_params = empty($filter) ? '' : http_build_query($filter);
28		}
29	2	return $this->get($add_params);
30		}
31
32		/**
33		* Переиспользуем стандартный метод
34		* @param string $filter
35		* @return ApiResponse
36		*/
37	4	public function get(string $filter = ''): ApiResponse
38		{
39	4	return $this->http_client->get(self::URL . '?' . $filter);
		0 ignored issues – show Bug introduced 2020-05-03 11:57 UTC by Report Bug Copy Issue Report The constant `CdekSDK2\Actions\FilteredTrait::URL` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
40		}
41		}
42

cdek-it / sdk2.0

Pull Request — master (#4)

FilteredTrait::getFiltered() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like