FilteredTrait::parseFilter() - Code Metrics - Inspection of "Добавлен новый формат ответа, а также: печатные фо..." - cdek-it/sdk2.0 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( a1417a...6e4df4 )

by ihomyak

created 2020-05-12 19:31 UTC

FilteredTrait::parseFilter() A

↳ Parent: FilteredTrait

Complexity

Conditions	4
Paths	4

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	4

Importance

Changes

Metric	Value
eloc	9
c	0
b	0
f	0
dl	0
loc	15
ccs	10
cts	10
cp	1
rs	9.9666
cc	4
nc	4
nop	1
crap	4

<?php

declare(strict_types=1);

namespace CdekSDK2\Actions;

use CdekSDK2\Http\ApiResponse;

trait FilteredTrait
{
    /**
     * @param array $filter
     * @return ApiResponse
     */
    public function getFiltered(array $filter = []): ApiResponse
    {
        $add_params = $this->parseFilter($filter);
        return $this->get($add_params);
    }

    /**
     * @param  array  $filter
     * @return string
     */
    private function parseFilter(array $filter = []): string
    {
        $add_params = '';
        if (empty($filter)) {
            return $add_params;
        }

        $filtered = [];
        foreach ($filter as $k => $v) {
            if (array_key_exists($k, self::FILTER)) {

                $filtered[$k] = $v;
            }
        }
        $add_params = http_build_query($filtered);
        return $add_params;
    }

    /**
     * Переиспользуем стандартный метод
     * @param string $filter
     * @return ApiResponse
     */
    public function get(string $filter = ''): ApiResponse
    {
        return $this->http_client->get(self::URL . '?' . $filter);

    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace CdekSDK2\Actions;
6
7		use CdekSDK2\Http\ApiResponse;
8
9		trait FilteredTrait
10		{
11		/**
12		* @param array $filter
13		* @return ApiResponse
14		*/
15	3	public function getFiltered(array $filter = []): ApiResponse
16		{
17	3	$add_params = $this->parseFilter($filter);
18	3	return $this->get($add_params);
19		}
20
21		/**
22		* @param array $filter
23		* @return string
24		*/
25	6	private function parseFilter(array $filter = []): string
26		{
27	6	$add_params = '';
28	6	if (empty($filter)) {
29	1	return $add_params;
30		}
31
32	5	$filtered = [];
33	5	foreach ($filter as $k => $v) {
34	5	if (array_key_exists($k, self::FILTER)) {
		0 ignored issues – show Bug introduced 2020-05-12 19:38 UTC by Report Bug Copy Issue Report The constant `CdekSDK2\Actions\FilteredTrait::FILTER` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
35	5	$filtered[$k] = $v;
36		}
37		}
38	5	$add_params = http_build_query($filtered);
39	5	return $add_params;
40		}
41
42		/**
43		* Переиспользуем стандартный метод
44		* @param string $filter
45		* @return ApiResponse
46		*/
47	6	public function get(string $filter = ''): ApiResponse
48		{
49	6	return $this->http_client->get(self::URL . '?' . $filter);
		0 ignored issues – show Bug introduced 2020-05-03 11:57 UTC by Report Bug Copy Issue Report The constant `CdekSDK2\Actions\FilteredTrait::URL` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
50		}
51		}
52

cdek-it / sdk2.0

Push — master ( a1417a...6e4df4 )

FilteredTrait::parseFilter() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like