Member - Code Metrics - cdaguerre/php-trello-api - Measure and Improve Code Quality continuously with Scrutinizer

Member C
last analyzed 2018-01-16 14:23 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	489
Duplicated Lines	4.09 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
wmc	55
lcom	1
cbo	4
dl	20
loc	489
rs	6.8
c	0
b	0
f	0

51 Methods

Rating	Name	Duplication	Size	Complexity
A	setAvatarHash()	0	6	1
A	getAvatarHash()	0	4	1
A	setBio()	0	6	1
A	getBio()	0	4	1
A	getBioData()	0	4	1
A	setConfirmed()	0	6	1
A	isConfirmed()	0	4	1
A	setFullName()	0	6	1
A	getFullName()	0	4	1
A	setIdPremOrgsAdmin()	0	6	1
A	getIdPremOrgsAdmin()	0	4	1
A	setInitials()	0	6	1
A	getInitials()	0	4	1
A	setMemberType()	0	13	2
A	getMemberType()	0	4	1
A	setProducts()	0	6	1
A	getProducts()	0	4	1
A	setStatus()	0	6	1
A	getStatus()	0	4	1
A	setUrl()	0	6	1
A	getUrl()	0	4	1
A	setUsername()	0	6	1
A	getUsername()	0	4	1
A	setAvatarSource()	0	6	1
A	getAvatarSource()	0	4	1
A	setEmail()	0	6	1
A	getEmail()	0	4	1
A	setGravatarHash()	0	6	1
A	getGravatarHash()	0	4	1
A	setBoardIds()	0	6	1
A	getBoardIds()	0	4	1
A	getBoards()	10	10	2
A	setPinnedBoardIds()	0	6	1
A	getPinnedBoardIds()	0	4	1
A	getPinnedBoards()	10	10	2
A	setOrganizationIds()	0	6	1
A	getOrganizationIds()	0	4	1
A	getOrganizations()	0	10	2
A	setLoginTypes()	0	6	1
A	getLoginTypes()	0	4	1
A	setNewEmail()	0	6	1
A	setOneTimeMessagesDismissed()	0	6	1
A	getOneTimeMessagesDismissed()	0	4	1
A	setPreferences()	0	6	1
A	getPreferences()	0	4	1
A	setTrophies()	0	6	1
A	getTrophies()	0	4	1
A	setUploadedAvatarHash()	0	6	1
A	getUploadedAvatarHash()	0	4	1
A	setPremiumFeatures()	0	6	1
A	getPremiumFeatures()	0	4	1

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like Member often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use Member, and based on these observations, apply Extract Interface, too.

<?php

namespace Trello\Model;

use Trello\Exception\InvalidArgumentException;

/**
 * @codeCoverageIgnore
 */
class Member extends AbstractObject implements MemberInterface
{
    protected $apiName = 'member';

    protected $loadParams = array(
        'fields' => 'all',
    );

    /**
     * {@inheritdoc}
     */
    public function setAvatarHash($avatarHash)
    {
        $this->data['avatarHash'] = $avatarHash;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getAvatarHash()
    {
        return $this->data['avatarHash'];
    }

    /**
     * {@inheritdoc}
     */
    public function setBio($bio)
    {
        $this->data['bio'] = $bio;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getBio()
    {
        return $this->data['bio'];
    }

    /**
     * {@inheritdoc}
     */
    public function getBioData()
    {
        return $this->data['bioData'];
    }

    /**
     * {@inheritdoc}
     */
    public function setConfirmed($confirmed)
    {
        $this->data['confirmed'] = $confirmed;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function isConfirmed()
    {
        return $this->data['confirmed'];
    }

    /**
     * {@inheritdoc}
     */
    public function setFullName($fullName)
    {
        $this->data['fullName'] = $fullName;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getFullName()
    {
        return $this->data['fullName'];
    }

    /**
     * {@inheritdoc}
     */
    public function setIdPremOrgsAdmin(array $idPremOrgsAdmin)
    {
        $this->data['idPremOrgsAdmin'] = $idPremOrgsAdmin;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getIdPremOrgsAdmin()
    {
        return $this->data['idPremOrgsAdmin'];
    }

    /**
     * {@inheritdoc}
     */
    public function setInitials($initials)
    {
        $this->data['initials'] = $initials;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getInitials()
    {
        return $this->data['initials'];
    }

    /**
     * {@inheritdoc}
     */
    public function setMemberType($memberType)
    {
        if (!in_array($memberType, array('admin', 'normal', 'observer'))) {
            throw new InvalidArgumentException(sprintf(
                'The member type %s does not exist.',
                $memberType
            ));
        }

        $this->data['memberType'] = $memberType;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getMemberType()
    {
        return $this->data['memberType'];
    }

    /**
     * {@inheritdoc}
     */
    public function setProducts(array $products)
    {
        $this->data['products'] = $products;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getProducts()
    {
        return $this->data['products'];
    }

    /**
     * {@inheritdoc}
     */
    public function setStatus($status)
    {
        $this->data['status'] = $status;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getStatus()
    {
        return $this->data['status'];
    }

    /**
     * {@inheritdoc}
     */
    public function setUrl($url)
    {
        $this->data['url'] = $url;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getUrl()
    {
        return $this->data['url'];
    }

    /**
     * {@inheritdoc}
     */
    public function setUsername($username)
    {
        $this->data['username'] = $username;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getUsername()
    {
        return $this->data['username'];
    }

    /**
     * {@inheritdoc}
     */
    public function setAvatarSource($avatarSource)
    {
        $this->data['avatarSource'] = $avatarSource;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getAvatarSource()
    {
        return $this->data['avatarSource'];
    }

    /**
     * {@inheritdoc}
     */
    public function setEmail($email)
    {
        $this->data['email'] = $email;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getEmail()
    {
        return $this->data['email'];
    }

    /**
     * {@inheritdoc}
     */
    public function setGravatarHash($gravatarHash)
    {
        $this->data['gravatarHash'] = $gravatarHash;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getGravatarHash()
    {
        return $this->data['gravatarHash'];
    }

    /**
     * {@inheritdoc}
     */
    public function setBoardIds(array $boardIds)
    {
        $this->data['idBoards'] = $boardIds;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getBoardIds()
    {
        return $this->data['idBoards'];
    }

    /**
     * {@inheritdoc}
     */
    public function getBoards()

    {
        $boards = array();

        foreach ($this->data['idBoards'] as $boardId) {
            $boards[] = new Board($this->client, $boardId);
        }

        return $boards;
    }

    /**
     * {@inheritdoc}
     */
    public function setPinnedBoardIds(array $pinnedBoardIds)
    {
        $this->data['idBoardsPinned'] = $pinnedBoardIds;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getPinnedBoardIds()
    {
        return $this->data['idBoardsPinned'];
    }

    /**
     * {@inheritdoc}
     */
    public function getPinnedBoards()

    {
        $boards = array();

        foreach ($this->data['idBoardsPinned'] as $boardId) {
            $boards[] = new Board($this->client, $boardId);
        }

        return $boards;
    }

    /**
     * {@inheritdoc}
     */
    public function setOrganizationIds(array $organizationIds)
    {
        $this->data['idOrganizations'] = $organizationIds;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getOrganizationIds()
    {
        return $this->data['idOrganizations'];
    }

    /**
     * {@inheritdoc}
     */
    public function getOrganizations()
    {
        $organizations = array();

        foreach ($this->data['idOrganizations'] as $organizationId) {
            $organizations[] = new Organization($this->client, $organizationId);
        }

        return $organizations;
    }

    /**
     * {@inheritdoc}
     */
    public function setLoginTypes($loginTypes)
    {
        $this->data['loginTypes'] = $loginTypes;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getLoginTypes()
    {
        return $this->data['loginTypes'];
    }

    /**
     * {@inheritdoc}
     */
    public function setNewEmail($newEmail)
    {
        $this->data['newEmail'] = $newEmail;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function setOneTimeMessagesDismissed(array $messages)
    {
        $this->data['oneTimeMessagesDismissed'] = $messages;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getOneTimeMessagesDismissed()
    {
        return $this->data['oneTimeMessagesDismissed'];
    }

    /**
     * {@inheritdoc}
     */
    public function setPreferences(array $prefs)
    {
        $this->data['prefs'] = $prefs;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getPreferences()
    {
        return $this->data['prefs'];
    }

    /**
     * {@inheritdoc}
     */
    public function setTrophies(array $trophies)
    {
        $this->data['trophies'] = $trophies;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getTrophies()
    {
        return $this->data['trophies'];
    }

    /**
     * {@inheritdoc}
     */
    public function setUploadedAvatarHash($uploadedAvatarHash)
    {
        $this->data['uploadedAvatarHash'] = $uploadedAvatarHash;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getUploadedAvatarHash()
    {
        return $this->data['uploadedAvatarHash'];
    }

    /**
     * {@inheritdoc}
     */
    public function setPremiumFeatures(array $premiumFeatures)
    {
        $this->data['premiumFeatures'] = $premiumFeatures;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getPremiumFeatures()
    {
        return $this->data['premiumFeatures'];
    }
}


1		<?php
2
3		namespace Trello\Model;
4
5		use Trello\Exception\InvalidArgumentException;
6
7		/**
8		* @codeCoverageIgnore
9		*/
10		class Member extends AbstractObject implements MemberInterface
11		{
12		protected $apiName = 'member';
13
14		protected $loadParams = array(
15		'fields' => 'all',
16		);
17
18		/**
19		* {@inheritdoc}
20		*/
21		public function setAvatarHash($avatarHash)
22		{
23		$this->data['avatarHash'] = $avatarHash;
24
25		return $this;
26		}
27
28		/**
29		* {@inheritdoc}
30		*/
31		public function getAvatarHash()
32		{
33		return $this->data['avatarHash'];
34		}
35
36		/**
37		* {@inheritdoc}
38		*/
39		public function setBio($bio)
40		{
41		$this->data['bio'] = $bio;
42
43		return $this;
44		}
45
46		/**
47		* {@inheritdoc}
48		*/
49		public function getBio()
50		{
51		return $this->data['bio'];
52		}
53
54		/**
55		* {@inheritdoc}
56		*/
57		public function getBioData()
58		{
59		return $this->data['bioData'];
60		}
61
62		/**
63		* {@inheritdoc}
64		*/
65		public function setConfirmed($confirmed)
66		{
67		$this->data['confirmed'] = $confirmed;
68
69		return $this;
70		}
71
72		/**
73		* {@inheritdoc}
74		*/
75		public function isConfirmed()
76		{
77		return $this->data['confirmed'];
78		}
79
80		/**
81		* {@inheritdoc}
82		*/
83		public function setFullName($fullName)
84		{
85		$this->data['fullName'] = $fullName;
86
87		return $this;
88		}
89
90		/**
91		* {@inheritdoc}
92		*/
93		public function getFullName()
94		{
95		return $this->data['fullName'];
96		}
97
98		/**
99		* {@inheritdoc}
100		*/
101		public function setIdPremOrgsAdmin(array $idPremOrgsAdmin)
102		{
103		$this->data['idPremOrgsAdmin'] = $idPremOrgsAdmin;
104
105		return $this;
106		}
107
108		/**
109		* {@inheritdoc}
110		*/
111		public function getIdPremOrgsAdmin()
112		{
113		return $this->data['idPremOrgsAdmin'];
114		}
115
116		/**
117		* {@inheritdoc}
118		*/
119		public function setInitials($initials)
120		{
121		$this->data['initials'] = $initials;
122
123		return $this;
124		}
125
126		/**
127		* {@inheritdoc}
128		*/
129		public function getInitials()
130		{
131		return $this->data['initials'];
132		}
133
134		/**
135		* {@inheritdoc}
136		*/
137		public function setMemberType($memberType)
138		{
139		if (!in_array($memberType, array('admin', 'normal', 'observer'))) {
140		throw new InvalidArgumentException(sprintf(
141		'The member type %s does not exist.',
142		$memberType
143		));
144		}
145
146		$this->data['memberType'] = $memberType;
147
148		return $this;
149		}
150
151		/**
152		* {@inheritdoc}
153		*/
154		public function getMemberType()
155		{
156		return $this->data['memberType'];
157		}
158
159		/**
160		* {@inheritdoc}
161		*/
162		public function setProducts(array $products)
163		{
164		$this->data['products'] = $products;
165
166		return $this;
167		}
168
169		/**
170		* {@inheritdoc}
171		*/
172		public function getProducts()
173		{
174		return $this->data['products'];
175		}
176
177		/**
178		* {@inheritdoc}
179		*/
180		public function setStatus($status)
181		{
182		$this->data['status'] = $status;
183
184		return $this;
185		}
186
187		/**
188		* {@inheritdoc}
189		*/
190		public function getStatus()
191		{
192		return $this->data['status'];
193		}
194
195		/**
196		* {@inheritdoc}
197		*/
198		public function setUrl($url)
199		{
200		$this->data['url'] = $url;
201
202		return $this;
203		}
204
205		/**
206		* {@inheritdoc}
207		*/
208		public function getUrl()
209		{
210		return $this->data['url'];
211		}
212
213		/**
214		* {@inheritdoc}
215		*/
216		public function setUsername($username)
217		{
218		$this->data['username'] = $username;
219
220		return $this;
221		}
222
223		/**
224		* {@inheritdoc}
225		*/
226		public function getUsername()
227		{
228		return $this->data['username'];
229		}
230
231		/**
232		* {@inheritdoc}
233		*/
234		public function setAvatarSource($avatarSource)
235		{
236		$this->data['avatarSource'] = $avatarSource;
237
238		return $this;
239		}
240
241		/**
242		* {@inheritdoc}
243		*/
244		public function getAvatarSource()
245		{
246		return $this->data['avatarSource'];
247		}
248
249		/**
250		* {@inheritdoc}
251		*/
252		public function setEmail($email)
253		{
254		$this->data['email'] = $email;
255
256		return $this;
257		}
258
259		/**
260		* {@inheritdoc}
261		*/
262		public function getEmail()
263		{
264		return $this->data['email'];
265		}
266
267		/**
268		* {@inheritdoc}
269		*/
270		public function setGravatarHash($gravatarHash)
271		{
272		$this->data['gravatarHash'] = $gravatarHash;
273
274		return $this;
275		}
276
277		/**
278		* {@inheritdoc}
279		*/
280		public function getGravatarHash()
281		{
282		return $this->data['gravatarHash'];
283		}
284
285		/**
286		* {@inheritdoc}
287		*/
288		public function setBoardIds(array $boardIds)
289		{
290		$this->data['idBoards'] = $boardIds;
291
292		return $this;
293		}
294
295		/**
296		* {@inheritdoc}
297		*/
298		public function getBoardIds()
299		{
300		return $this->data['idBoards'];
301		}
302
303		/**
304		* {@inheritdoc}
305		*/
306	View Code Duplication	public function getBoards()
		0 ignored issues – show Duplication introduced 2017-08-02 08:06 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
307		{
308		$boards = array();
309
310		foreach ($this->data['idBoards'] as $boardId) {
311		$boards[] = new Board($this->client, $boardId);
312		}
313
314		return $boards;
315		}
316
317		/**
318		* {@inheritdoc}
319		*/
320		public function setPinnedBoardIds(array $pinnedBoardIds)
321		{
322		$this->data['idBoardsPinned'] = $pinnedBoardIds;
323
324		return $this;
325		}
326
327		/**
328		* {@inheritdoc}
329		*/
330		public function getPinnedBoardIds()
331		{
332		return $this->data['idBoardsPinned'];
333		}
334
335		/**
336		* {@inheritdoc}
337		*/
338	View Code Duplication	public function getPinnedBoards()
		0 ignored issues – show Duplication introduced 2017-08-02 08:06 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
339		{
340		$boards = array();
341
342		foreach ($this->data['idBoardsPinned'] as $boardId) {
343		$boards[] = new Board($this->client, $boardId);
344		}
345
346		return $boards;
347		}
348
349		/**
350		* {@inheritdoc}
351		*/
352		public function setOrganizationIds(array $organizationIds)
353		{
354		$this->data['idOrganizations'] = $organizationIds;
355
356		return $this;
357		}
358
359		/**
360		* {@inheritdoc}
361		*/
362		public function getOrganizationIds()
363		{
364		return $this->data['idOrganizations'];
365		}
366
367		/**
368		* {@inheritdoc}
369		*/
370		public function getOrganizations()
371		{
372		$organizations = array();
373
374		foreach ($this->data['idOrganizations'] as $organizationId) {
375		$organizations[] = new Organization($this->client, $organizationId);
376		}
377
378		return $organizations;
379		}
380
381		/**
382		* {@inheritdoc}
383		*/
384		public function setLoginTypes($loginTypes)
385		{
386		$this->data['loginTypes'] = $loginTypes;
387
388		return $this;
389		}
390
391		/**
392		* {@inheritdoc}
393		*/
394		public function getLoginTypes()
395		{
396		return $this->data['loginTypes'];
397		}
398
399		/**
400		* {@inheritdoc}
401		*/
402		public function setNewEmail($newEmail)
403		{
404		$this->data['newEmail'] = $newEmail;
405
406		return $this;
407		}
408
409		/**
410		* {@inheritdoc}
411		*/
412		public function setOneTimeMessagesDismissed(array $messages)
413		{
414		$this->data['oneTimeMessagesDismissed'] = $messages;
415
416		return $this;
417		}
418
419		/**
420		* {@inheritdoc}
421		*/
422		public function getOneTimeMessagesDismissed()
423		{
424		return $this->data['oneTimeMessagesDismissed'];
425		}
426
427		/**
428		* {@inheritdoc}
429		*/
430		public function setPreferences(array $prefs)
431		{
432		$this->data['prefs'] = $prefs;
433
434		return $this;
435		}
436
437		/**
438		* {@inheritdoc}
439		*/
440		public function getPreferences()
441		{
442		return $this->data['prefs'];
443		}
444
445		/**
446		* {@inheritdoc}
447		*/
448		public function setTrophies(array $trophies)
449		{
450		$this->data['trophies'] = $trophies;
451
452		return $this;
453		}
454
455		/**
456		* {@inheritdoc}
457		*/
458		public function getTrophies()
459		{
460		return $this->data['trophies'];
461		}
462
463		/**
464		* {@inheritdoc}
465		*/
466		public function setUploadedAvatarHash($uploadedAvatarHash)
467		{
468		$this->data['uploadedAvatarHash'] = $uploadedAvatarHash;
469
470		return $this;
471		}
472
473		/**
474		* {@inheritdoc}
475		*/
476		public function getUploadedAvatarHash()
477		{
478		return $this->data['uploadedAvatarHash'];
479		}
480
481		/**
482		* {@inheritdoc}
483		*/
484		public function setPremiumFeatures(array $premiumFeatures)
485		{
486		$this->data['premiumFeatures'] = $premiumFeatures;
487
488		return $this;
489		}
490
491		/**
492		* {@inheritdoc}
493		*/
494		public function getPremiumFeatures()
495		{
496		return $this->data['premiumFeatures'];
497		}
498		}
499

cdaguerre / php-trello-api

Member C last analyzed 2018-01-16 14:23 UTC