CCT\Kong\Transformer\Response\ObjectTransformer

Complexity

Total Complexity

4

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	transform()	0	10	1
A	supports()	0	8	3

<?php

namespace CCT\Kong\Transformer\Response;

use CCT\Kong\Http\Response;
use CCT\Kong\Transformer\SerializerTransformer;
use CCT\Kong\Http\ResponseInterface;

class ObjectTransformer extends SerializerTransformer
{
    /**
     * @param ResponseInterface|Response $response
     *
     * {@inheritdoc}
     */
    public function transform(ResponseInterface $response)
    {
        $data = $this->serializer->deserialize(
            $response->getContent(),

The method getContent() does not exist on CCT\Kong\Http\ResponseInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to CCT\Kong\Http\ResponseInterface.

            $this->class,
            'json',
            $this->context

It seems like $this->context can also be of type JMS\Serializer\SerializationContext; however, parameter $context of JMS\Serializer\Serializer::deserialize() does only seem to accept null|JMS\Serializer\DeserializationContext, maybe add an additional type check?

        );

        $response->setData($data);
    }

    /**
     * @param ResponseInterface|Response $response
     *
     * {@inheritdoc}
     */
    public function supports(ResponseInterface $response): bool
    {
        $data = $response->getData();

        return
            false === isset($data['data'])
            && $response->isSuccessful()

The method isSuccessful() does not exist on CCT\Kong\Http\ResponseInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to CCT\Kong\Http\ResponseInterface.

            && !empty($data)
        ;
    }
}