CCT\Kong\Transformer\Response\CollectionObjectTransformer

Complexity

Total Complexity

7

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	supports()	0	10	5
A	transform()	0	15	2

<?php

namespace CCT\Kong\Transformer\Response;

use CCT\Kong\Model\Response\ContentCollection;
use CCT\Kong\Transformer\SerializerTransformer;
use CCT\Kong\Http\ResponseInterface;
use Symfony\Component\HttpFoundation\Response;

class CollectionObjectTransformer extends SerializerTransformer
{
    /**
     * @param ResponseInterface|Response $response
     *
     * {@inheritdoc}
     */
    public function transform(ResponseInterface $response)
    {
        $data = $response->getData();

        foreach ($data['data'] as $k => $object) {
            $data['data'][$k] = $this->serializer->deserialize(
                json_encode($object),
                $this->class,
                'json',
                $this->context

It seems like $this->context can also be of type JMS\Serializer\SerializationContext; however, parameter $context of JMS\Serializer\Serializer::deserialize() does only seem to accept null|JMS\Serializer\DeserializationContext, maybe add an additional type check?

            );
        }

        $data = new ContentCollection($data);
        $response->setData($data);
    }

    /**
     * @param ResponseInterface|Response $response
     *
     * {@inheritdoc}
     */
    public function supports(ResponseInterface $response): bool
    {
        $data = $response->getData();

        return (
            is_array($data)
            && isset($data['data'])
            && isset($data['total'])
            && $response->isSuccessful()

The method isSuccessful() does not exist on CCT\Kong\Http\ResponseInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to CCT\Kong\Http\ResponseInterface.

            && !empty($data)
        );
    }
}