CCT\Component\Rest\Serializer\JMSSerializerAdapter

Complexity

Total Complexity

18

Size/Duplication

Total Lines	140
Duplicated Lines	0 %

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	serialize()	0	5	1
A	toArray()	0	5	1
F	convertContext()	0	40	12
A	__construct()	0	8	1
A	fromArray()	0	5	1
A	deserialize()	0	9	2

<?php

namespace CCT\Component\Rest\Serializer;

use CCT\Component\Rest\Serializer\Context\Context;
use JMS\Serializer\Context as JMSContext;
use JMS\Serializer\ContextFactory\DeserializationContextFactoryInterface;
use JMS\Serializer\ContextFactory\SerializationContextFactoryInterface;
use JMS\Serializer\DeserializationContext;
use JMS\Serializer\SerializationContext;
use JMS\Serializer\Serializer;
use JMS\Serializer\SerializerInterface;

This use statement conflicts with another class in this namespace, CCT\Component\Rest\Serializer\SerializerInterface. Consider defining an alias.

/**
 * Adapter to plug the JMS serializer into the FOSRestBundle Serializer API.
 */
class JMSSerializerAdapter implements \CCT\Component\Rest\Serializer\SerializerInterface
{
    /**
     * @internal
     */
    const SERIALIZATION = 0;

    /**
     * @internal
     */
    const DESERIALIZATION = 1;

    /**
     * @var SerializerInterface|Serializer
     */
    private $serializer;

    /**
     * @var SerializationContextFactoryInterface
     */
    private $serializationContextFactory;

    /**
     * @var DeserializationContextFactoryInterface
     */
    private $deserializationContextFactory;

    public function __construct(
        SerializerInterface $serializer,
        SerializationContextFactoryInterface $serializationContextFactory = null,
        DeserializationContextFactoryInterface $deserializationContextFactory = null
    ) {
        $this->serializer = $serializer;
        $this->serializationContextFactory = $serializationContextFactory;
        $this->deserializationContextFactory = $deserializationContextFactory;
    }

    /**
     * {@inheritdoc}
     */
    public function serialize($data, $format, ContextInterface $context = null)
    {
        $context = $this->convertContext($context, self::SERIALIZATION);

        return $this->serializer->serialize($data, $format, $context);

It seems like $context can also be of type JMS\Serializer\DeserializationContext; however, parameter $context of JMS\Serializer\Serializer::serialize() does only seem to accept JMS\Serializer\SerializationContext|null, maybe add an additional type check?

It seems like $context can also be of type JMS\Serializer\DeserializationContext; however, parameter $context of JMS\Serializer\SerializerInterface::serialize() does only seem to accept JMS\Serializer\SerializationContext|null, maybe add an additional type check?

    }

    /**
     * {@inheritdoc}
     */
    public function deserialize($data, $type, $format, ContextInterface $context = null)
    {
        if (null === $context) {
            $context = $this->deserializationContextFactory->createDeserializationContext();
        }

        $context = $this->convertContext($context, self::DESERIALIZATION);

It seems like $context can also be of type JMS\Serializer\DeserializationContext; however, parameter $context of CCT\Component\Rest\Serializer\JMSSerializerAdapter::convertContext() does only seem to accept null|CCT\Component\Rest\Serializer\Context\Context, maybe add an additional type check?

        return $this->serializer->deserialize($data, $type, $format, $context);

It seems like $context can also be of type JMS\Serializer\SerializationContext; however, parameter $context of JMS\Serializer\SerializerInterface::deserialize() does only seem to accept null|JMS\Serializer\DeserializationContext, maybe add an additional type check?

It seems like $context can also be of type JMS\Serializer\SerializationContext; however, parameter $context of JMS\Serializer\Serializer::deserialize() does only seem to accept null|JMS\Serializer\DeserializationContext, maybe add an additional type check?

    }

    /**
     * @param Context $context
     * @param int $direction {@see self} constants
     *
     * @return JMSContext
     */
    private function convertContext(Context $context = null, $direction)
    {
        if (self::SERIALIZATION === $direction) {
            $jmsContext = $this->serializationContextFactory
                ? $this->serializationContextFactory->createSerializationContext()
                : SerializationContext::create();
        } else {
            $jmsContext = $this->deserializationContextFactory
                ? $this->deserializationContextFactory->createDeserializationContext()
                : DeserializationContext::create();
            $maxDepth = $context->getMaxDepth(false);

The function CCT\Component\Rest\Serializer\Context\Context::getMaxDepth() has been deprecated: since version 2.1, to be removed in 3.0. Use {@link self::isMaxDepthEnabled()} instead

The method getMaxDepth() does not exist on null.

            if (null !== $maxDepth) {

The condition null !== $maxDepth is always true.

                for ($i = 0; $i < $maxDepth; ++$i) {
                    $jmsContext->increaseDepth();
                }
            }
        }

        foreach ($context->getAttributes() as $key => $value) {
            $jmsContext->attributes->set($key, $value);
        }

        if (null !== $context->getVersion()) {
            $jmsContext->setVersion($context->getVersion());
        }
        if (null !== $context->getGroups()) {
            $jmsContext->setGroups($context->getGroups());
        }
        if (null !== $context->isMaxDepthEnabled()) {

The condition null !== $context->isMaxDepthEnabled() is always true.

            $jmsContext->enableMaxDepthChecks();
        }
        if (null !== $context->getSerializeNull()) {

The condition null !== $context->getSerializeNull() is always true.

            $jmsContext->setSerializeNull($context->getSerializeNull());
        }

        foreach ($context->getExclusionStrategies() as $strategy) {
            $jmsContext->addExclusionStrategy($strategy);
        }

        return $jmsContext;
    }

    /**
     * Converts objects to an array structure.
     *
     * This is useful when the data needs to be passed on to other methods which expect array data.
     *
     * @param mixed $data anything that converts to an array, typically an object or an array of objects
     * @param ContextInterface|null $context
     *
     * @return array
     */
    public function toArray($data, ContextInterface $context = null)
    {
        $context = $this->convertContext($context, self::SERIALIZATION);

        $this->serializer->toArray($data, $context);

It seems like $context can also be of type JMS\Serializer\DeserializationContext; however, parameter $context of JMS\Serializer\Serializer::toArray() does only seem to accept JMS\Serializer\SerializationContext|null, maybe add an additional type check?

    }

    /**
     * Restores objects from an array structure.
     *
     * @param array $data
     * @param string $type
     * @param ContextInterface|null $context
     *
     * @return mixed this returns whatever the passed type is, typically an object or an array of objects
     */
    public function fromArray(array $data, $type, ContextInterface $context = null)
    {
        $context = $this->convertContext($context, self::DESERIALIZATION);

        $this->serializer->fromArray($data, $context);
    }
}