QueueDeclarer::__construct() - Code Metrics - Inspection of "Add declarer for queue and exchanges" - ccovey/rabbitmq - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 658390...23e91d )

by Cody

created 2016-11-30 21:35 UTC

QueueDeclarer::__construct() A

↳ Parent: QueueDeclarer

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	5
Ratio	100 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
dl	5
loc	5
ccs	4
cts	4
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	2
crap	1

<?php

namespace Ccovey\RabbitMQ;

use Ccovey\RabbitMQ\Connection\Connection;

class QueueDeclarer

{
    /**
     * @var array
     */
    private $declaredQueues = [];

    /**
     * @var Connection
     */
    private $connection;

    /**
     * @var ChannelInterface
     */
    private $channel;

    public function __construct(Connection $connection, string $channelId = '')
    {
        $this->connection = $connection;
        $this->channel = $this->connection->getChannel($channelId);
    }

    /*
     * This method will be run each time we attempt to queue a message.
     * We will cache locally which queues we have already declared.
     * Declaring a queue on each iteration of a worker consuming from
     * a queue is really slow.
     */
    public function declareQueue(Queue $queue)
    {
        if (!in_array($queue, $this->declaredQueues)) {
            $this->channel->declareQueue($queue);
            $this->declaredQueues[] = $queue;
        }
    }
}


1			<?php
2
3			namespace Ccovey\RabbitMQ;
4
5			use Ccovey\RabbitMQ\Connection\Connection;
6
7		View Code Duplication	class QueueDeclarer
			1 ignored issue – show Duplication introduced 2016-11-30 21:37 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
8			{
9			/**
10			* @var array
11			*/
12			private $declaredQueues = [];
13
14			/**
15			* @var Connection
16			*/
17			private $connection;
18
19			/**
20			* @var ChannelInterface
21			*/
22			private $channel;
23
24	1		public function __construct(Connection $connection, string $channelId = '')
25			{
26	1		$this->connection = $connection;
27	1		$this->channel = $this->connection->getChannel($channelId);
28	1		}
29
30			/*
31			* This method will be run each time we attempt to queue a message.
32			* We will cache locally which queues we have already declared.
33			* Declaring a queue on each iteration of a worker consuming from
34			* a queue is really slow.
35			*/
36	1		public function declareQueue(Queue $queue)
37			{
38	1		if (!in_array($queue, $this->declaredQueues)) {
39	1		$this->channel->declareQueue($queue);
40	1		$this->declaredQueues[] = $queue;
41			}
42	1		}
43			}
44

ccovey / rabbitmq

Push — master ( 658390...23e91d )

QueueDeclarer::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like