Benjafield\LaravelPasswordManager\Traits\CanMakePassword

Complexity

Total Complexity

3

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	setText()	0	4	1
A	make()	0	6	1
A	text()	0	3	1

<?php

namespace Benjafield\LaravelPasswordManager\Traits;

trait CanMakePassword
{
    /**
     * The plain text version of the password.
     *
     * @var string
     */
    protected string $text;

    /**
     * Create a new instance of a password model.
     *
     * @param string $name
     * @param string $dynamic
     * @param string $password
     * @param string|null $text
     * @return self
     */
    public static function make(string $name, string $dynamic, string $password, string $text = null): self
    {
        $attributes = compact('name', 'dynamic', 'password');

        return (new self($attributes))

The call to Benjafield\LaravelPasswordManager\Traits\CanMakePassword::__construct() has too many arguments starting with $attributes.

            ->setText($text);

It seems like $text can also be of type null; however, parameter $value of Benjafield\LaravelPasswordManager\Traits\CanMakePassword::setText() does only seem to accept string, maybe add an additional type check?

    }

    /**
     * Set the plain text version of the password.
     * Not included when serialized.
     *
     * @param string $value
     * @return $this
     */
    public function setText(string $value): self
    {
        $this->text = $value;
        return $this;
    }

    /**
     * Retrieve the plain text version of the password.
     *
     * @return string|null
     */
    public function text(): string|null
    {
        return $this->text;
    }
}