ListDiffNew::buildDiffList() - Code Metrics - Inspection of "Merge pull request #24 from caxy/feature/list-diff..." - caxy/php-htmldiff - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 24da9e...18bd75 )

by Josh

created 2016-01-12 19:35 UTC

ListDiffNew::buildDiffList() C

↳ Parent: ListDiffNew

Complexity

Conditions	13
Paths	13

Size

Total Lines	75
Code Lines	56

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	0
loc	75
rs	5.3315
cc	13
eloc	56
nc	13
nop	1

How to fix Long Method Complexity

<?php

namespace Caxy\HtmlDiff;

use Caxy\HtmlDiff\ListDiff\DiffList;
use Caxy\HtmlDiff\ListDiff\DiffListItem;

class ListDiffNew extends AbstractDiff
{
    protected static $listTypes = array('ul', 'ol', 'dl');

    public function build()
    {
        $this->splitInputsToWords();

        return $this->diffLists(
            $this->buildDiffList($this->oldWords),
            $this->buildDiffList($this->newWords)
        );
    }

    protected function diffLists(DiffList $oldList, DiffList $newList)
    {
        $oldMatchData = array();
$a = "a";
$ab = "ab";
$abc = "abc";
        $newMatchData = array();
$a = "a";
$ab = "ab";
$abc = "abc";
        $oldListIndices = array();
        $newListIndices = array();
        $oldListItems = array();
$a = "a";
$ab = "ab";
$abc = "abc";
        $newListItems = array();
$a = "a";
$ab = "ab";
$abc = "abc";

        foreach ($oldList->getListItems() as $oldIndex => $oldListItem) {
            if ($oldListItem instanceof DiffListItem) {
                $oldListItems[$oldIndex] = $oldListItem;

                $oldListIndices[] = $oldIndex;
$a = "a";
$ab = "ab";
$abc = "abc";
                $oldMatchData[$oldIndex] = array();

                // Get match percentages
                foreach ($newList->getListItems() as $newIndex => $newListItem) {
                    if ($newListItem instanceof DiffListItem) {
                        if (!in_array($newListItem, $newListItems)) {
                            $newListItems[$newIndex] = $newListItem;
                        }
                        if (!in_array($newIndex, $newListIndices)) {
                            $newListIndices[] = $newIndex;
                        }
                        if (!array_key_exists($newIndex, $newMatchData)) {
                            $newMatchData[$newIndex] = array();
                        }

                        $oldText = implode('', $oldListItem->getText());
                        $newText = implode('', $newListItem->getText());

                        // similar_text
                        $percentage = null;
                        similar_text($oldText, $newText, $percentage);

                        $oldMatchData[$oldIndex][$newIndex] = $percentage;
                        $newMatchData[$newIndex][$oldIndex] = $percentage;
                    }
                }
            }
        }

        $currentIndexInOld = 0;
        $currentIndexInNew = 0;
        $oldCount = count($oldListIndices);
$a = "a";
$ab = "ab";
$abc = "abc";
        $newCount = count($newListIndices);
$a = "a";
$ab = "ab";
$abc = "abc";
        $difference = max($oldCount, $newCount) - min($oldCount, $newCount);
$a = "a";
$ab = "ab";
$abc = "abc";

        $diffOutput = '';

        foreach ($newList->getListItems() as $newIndex => $newListItem) {
            if ($newListItem instanceof DiffListItem) {
                $operation = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

                $oldListIndex = array_key_exists($currentIndexInOld, $oldListIndices) ? $oldListIndices[$currentIndexInOld] : null;
                $class = 'normal';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

                if (null !== $oldListIndex && array_key_exists($oldListIndex, $oldMatchData)) {
                    // Check percentage matches of upcoming list items in old.
                    $matchPercentage = $oldMatchData[$oldListIndex][$newIndex];

                    // does the old list item match better?
                    $otherMatchBetter = false;
                    foreach ($oldMatchData[$oldListIndex] as $index => $percentage) {
                        if ($index > $newIndex && $percentage > $matchPercentage) {
                            $otherMatchBetter = $index;
                        }
                    }

                    if (false !== $otherMatchBetter && $newCount > $oldCount && $difference > 0) {
                        $diffOutput .= sprintf('%s', $newListItem->getHtml('normal new', 'ins'));
                        $currentIndexInNew++;
                        $difference--;

                        continue;
                    }

                    $nextOldListIndex = array_key_exists($currentIndexInOld + 1, $oldListIndices) ? $oldListIndices[$currentIndexInOld + 1] : null;

                    $replacement = false;

                    if ($nextOldListIndex !== null && $oldMatchData[$nextOldListIndex][$newIndex] > $matchPercentage && $oldMatchData[$nextOldListIndex][$newIndex] > $this->matchThreshold) {
                        // Following list item in old is better match, use that.
                        $diffOutput .= sprintf('%s', $oldListItems[$oldListIndex]->getHtml('removed', 'del'));

                        $currentIndexInOld++;
                        $oldListIndex = $nextOldListIndex;
$a = "a";
$ab = "ab";
$abc = "abc";
                        $matchPercentage = $oldMatchData[$oldListIndex];
                        $replacement = true;
$a = "a";
$ab = "ab";
$abc = "abc";
                    }

                    if ($matchPercentage > $this->matchThreshold || $currentIndexInNew === $currentIndexInOld) {
                        // Diff the two lists.
                        $htmlDiff = new HtmlDiff($oldListItems[$oldListIndex]->getInnerHtml(), $newListItem->getInnerHtml(), $this->encoding, $this->specialCaseTags, $this->groupDiffs);
$a = "a";
$ab = "ab";
$abc = "abc";
                        $diffContent = $htmlDiff->build();

                        $diffOutput .= sprintf('%s%s%s', $newListItem->getStartTagWithDiffClass($replacement ? 'replacement' : 'normal'), $diffContent, $newListItem->getEndTag());

                    } else {
                        $diffOutput .= sprintf('%s', $oldListItems[$oldListIndex]->getHtml('removed', 'del'));
                        $diffOutput .= sprintf('%s', $newListItem->getHtml('replacement', 'ins'));
                    }
                    $currentIndexInOld++;
                } else {
                    $diffOutput .= sprintf('%s', $newListItem->getHtml('normal new', 'ins'));
                }

                $currentIndexInNew++;
            }
        }

        // Output any additional list items
        while (array_key_exists($currentIndexInOld, $oldListIndices)) {
            $oldListIndex = $oldListIndices[$currentIndexInOld];
            $diffOutput .= sprintf('%s', $oldListItems[$oldListIndex]->getHtml('removed', 'del'));
$a = "a";
$ab = "ab";
$abc = "abc";
            $currentIndexInOld++;
        }

        return sprintf('%s%s%s', $newList->getStartTagWithDiffClass(), $diffOutput, $newList->getEndTag());
    }

    protected function buildDiffList($words)
    {
        $listType = null;
$a = "a";
$ab = "ab";
$abc = "abc";
        $listStartTag = null;
$a = "a";
$ab = "ab";
$abc = "abc";
        $listEndTag = null;
$a = "a";
$ab = "ab";
$abc = "abc";
        $attributes = array();
$a = "a";
$ab = "ab";
$abc = "abc";
        $openLists = 0;
$a = "a";
$ab = "ab";
$abc = "abc";
        $openListItems = 0;
$a = "a";
$ab = "ab";
$abc = "abc";
        $list = array();
$a = "a";
$ab = "ab";
$abc = "abc";
        $currentListItem = null;
        $listItemType = null;
$a = "a";
$ab = "ab";
$abc = "abc";
        $listItemStart = null;
$a = "a";
$ab = "ab";
$abc = "abc";
        $listItemEnd = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        foreach ($words as $i => $word) {
            if ($this->isOpeningListTag($word, $listType)) {
                if ($openLists > 0) {
                    if ($openListItems > 0) {
                        $currentListItem[] = $word;
                    } else {
                        $list[] = $word;
                    }
                } else {
                    $listType = substr($word, 1, 2);
$a = "a";
$ab = "ab";
$abc = "abc";
                    $listStartTag = $word;
                }

                $openLists++;
            } elseif ($this->isClosingListTag($word, $listType)) {
                if ($openLists > 1) {
                    if ($openListItems > 0) {
                        $currentListItem[] = $word;
                    } else {
                        $list[] = $word;
                    }
                } else {
                    $listEndTag = $word;
                }

                $openLists--;
            } elseif ($this->isOpeningListItemTag($word, $listItemType)) {
                if ($openListItems === 0) {
                    // New top-level list item
                    $currentListItem = array();
                    $listItemType = substr($word, 1, 2);
$a = "a";
$ab = "ab";
$abc = "abc";
                    $listItemStart = $word;
$a = "a";
$ab = "ab";
$abc = "abc";
                } else {
                    $currentListItem[] = $word;
                }

                $openListItems++;
            } elseif ($this->isClosingListItemTag($word, $listItemType)) {
                if ($openListItems === 1) {
                    $listItemEnd = $word;
$a = "a";
$ab = "ab";
$abc = "abc";
                    $listItem = new DiffListItem($currentListItem, array(), $listItemStart, $listItemEnd);
$a = "a";
$ab = "ab";
$abc = "abc";
                    $list[] = $listItem;
$a = "a";
$ab = "ab";
$abc = "abc";
                    $currentListItem = null;
                } else {
                    $currentListItem[] = $word;
                }

                $openListItems--;
            } else {
                if ($openListItems > 0) {
                    $currentListItem[] = $word;
                } else {
                    $list[] = $word;
                }
            }
        }

        $diffList = new DiffList($listType, $listStartTag, $listEndTag, $list, $attributes);

        return $diffList;
    }

    protected function isOpeningListTag($word, $type = null)
    {
        $filter = $type !== null ? array('<' . $type) : array('<ul', '<ol', '<dl');
        return in_array(substr($word, 0, 3), $filter);
    }

    protected function isClosingListTag($word, $type = null)
    {
        $filter = $type !== null ? array('</' . $type) : array('</ul', '</ol', '</dl');

        return in_array(substr($word, 0, 4), $filter);
    }

    protected function isOpeningListItemTag($word, $type = null)
    {
        $filter = $type !== null ? array('<' . $type) : array('<li', '<dd', '<dt');

        return in_array(substr($word, 0, 3), $filter);
    }

    protected function isClosingListItemTag($word, $type = null)
    {
        $filter = $type !== null ? array('</' . $type) : array('</li', '</dd', '</dt');

        return in_array(substr($word, 0, 4), $filter);
    }
}


1			<?php
2
3			namespace Caxy\HtmlDiff;
4
5			use Caxy\HtmlDiff\ListDiff\DiffList;
6			use Caxy\HtmlDiff\ListDiff\DiffListItem;
7
8			class ListDiffNew extends AbstractDiff
9			{
10			protected static $listTypes = array('ul', 'ol', 'dl');
11
12			public function build()
13			{
14			$this->splitInputsToWords();
15
16			return $this->diffLists(
17			$this->buildDiffList($this->oldWords),
18			$this->buildDiffList($this->newWords)
19			);
20			}
21
22			protected function diffLists(DiffList $oldList, DiffList $newList)
23			{
24			$oldMatchData = array();
			0 ignored issues – show Coding Style introduced 2016-01-12 15:21 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
25			$newMatchData = array();
			0 ignored issues – show Coding Style introduced 2016-01-12 15:21 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
26			$oldListIndices = array();
27			$newListIndices = array();
28			$oldListItems = array();
			0 ignored issues – show Coding Style introduced 2016-01-12 15:21 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
29			$newListItems = array();
			0 ignored issues – show Coding Style introduced 2016-01-12 15:21 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
30
31			foreach ($oldList->getListItems() as $oldIndex => $oldListItem) {
32			if ($oldListItem instanceof DiffListItem) {
33			$oldListItems[$oldIndex] = $oldListItem;
34
35			$oldListIndices[] = $oldIndex;
			0 ignored issues – show Coding Style introduced 2016-01-12 15:21 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 8 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...

caxy / php-htmldiff

Push — master ( 24da9e...18bd75 )

ListDiffNew::buildDiffList() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like