TableCell::setRow() - Code Metrics - Inspection of "New Feature: Table Diffing" - caxy/php-htmldiff - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#31)

by Josh

created 2016-02-26 00:25 UTC

TableCell::setRow() A

↳ Parent: TableCell

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	10
ccs	0
cts	6
cp	0
rs	9.4285
cc	2
eloc	5
nc	2
nop	1
crap	6

<?php

namespace Caxy\HtmlDiff\Table;

/**
 * Class TableCell
 * @package Caxy\HtmlDiff\Table
 */
class TableCell extends AbstractTableElement
{
    /**
     * @var TableRow
     */
    protected $row;

    /**
     * @return TableRow
     */
    public function getRow()
    {
        return $this->row;
    }

    /**
     * @param TableRow|null $row
     *
     * @return $this
     */
    public function setRow(TableRow $row = null)
    {
        $this->row = $row;

        if (!in_array($this, $row->getCells())) {
            $row->addCell($this);
function someFunction(A $objectMaybe = null)
{
    if ($objectMaybe instanceof A) {
        $objectMaybe->doSomething();
    }
}
        }

        return $this;
    }

    /**
     * @return int

     */
    public function getColspan()
    {
        return $this->getAttribute('colspan') ?: 1;
    }

    /**
     * @return int

     */
    public function getRowspan()
    {
        return $this->getAttribute('rowspan') ?: 1;
    }
}


1			<?php
2
3			namespace Caxy\HtmlDiff\Table;
4
5			/**
6			* Class TableCell
7			* @package Caxy\HtmlDiff\Table
8			*/
9			class TableCell extends AbstractTableElement
10			{
11			/**
12			* @var TableRow
13			*/
14			protected $row;
15
16			/**
17			* @return TableRow
18			*/
19			public function getRow()
20			{
21			return $this->row;
22			}
23
24			/**
25			* @param TableRow\|null $row
26			*
27			* @return $this
28			*/
29			public function setRow(TableRow $row = null)
30			{
31			$this->row = $row;
32
33			if (!in_array($this, $row->getCells())) {
34			$row->addCell($this);
			0 ignored issues – show Bug introduced 2016-02-23 20:32 UTC by Report Bug Copy Issue Report It seems like `$row` is not always an object, but can also be of type `null`. Maybe add an additional type check? If a variable is not always an object, we recommend to add an additional type check to ensure your method call is safe: function someFunction(A $objectMaybe = null) { if ($objectMaybe instanceof A) { $objectMaybe->doSomething(); } } Loading history...
35			}
36
37			return $this;
38			}
39
40			/**
41			* @return int
			0 ignored issues – show Documentation introduced 2016-02-26 00:28 UTC by Report Bug Copy Issue Report Should the return type not be `string\|integer`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
42			*/
43			public function getColspan()
44			{
45			return $this->getAttribute('colspan') ?: 1;
46			}
47
48			/**
49			* @return int
			0 ignored issues – show Documentation introduced 2016-02-26 00:28 UTC by Report Bug Copy Issue Report Should the return type not be `string\|integer`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
50			*/
51			public function getRowspan()
52			{
53			return $this->getAttribute('rowspan') ?: 1;
54			}
55			}
56

caxy / php-htmldiff

Pull Request — master (#31)

TableCell::setRow() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like