ListDiffLines::processOperations() - Code Metrics - Inspection of "Implement new List Diffing algorithm for matching..." - caxy/php-htmldiff - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 755472...23808d )

by Adam

created 2016-05-19 16:16 UTC

ListDiffLines::processOperations() F

↳ Parent: ListDiffLines

Complexity

Conditions	20
Paths	333

Size

Total Lines	97
Code Lines	67

Duplication

Lines	24
Ratio	24.74 %

Code Coverage

Tests	80
CRAP Score	20.0058

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	20
eloc	67
c	1
b	0
f	1
nc	333
nop	3
dl	24
loc	97
ccs	80
cts	82
cp	0.9756
crap	20.0058
rs	3.6338

How to fix Long Method Complexity

<?php

namespace Caxy\HtmlDiff;

use Caxy\HtmlDiff\Strategy\ListItemMatchStrategy;
use Sunra\PhpSimple\HtmlDomParser;

class ListDiffLines extends AbstractDiff
{
    const CLASS_LIST_ITEM_ADDED = 'normal new';
    const CLASS_LIST_ITEM_DELETED = 'removed';
    const CLASS_LIST_ITEM_CHANGED = 'replacement';
    const CLASS_LIST_ITEM_NONE = 'normal';

    protected static $listTypes = array('ul', 'ol', 'dl');

    /**
     * List of tags that should be included when retrieving
     * text from a single list item that will be used in
     * matching logic (and only in matching logic).
     *
     * @see getRelevantNodeText()
     *
     * @var array
     */
    protected static $listContentTags = array(
        'h1','h2','h3','h4','h5','pre','div','br','hr','code',
        'input','form','img','span','a','i','b','strong','em',
        'font','big','del','tt','sub','sup','strike',
    );

    /**
     * @var LcsService
     */
    protected $lcsService;

    /**
     * @param string              $oldText
     * @param string              $newText
     * @param HtmlDiffConfig|null $config
     *
     * @return ListDiffLines
     */
    public static function create($oldText, $newText, HtmlDiffConfig $config = null)

    {
        $diff = new self($oldText, $newText);

        if (null !== $config) {
            $diff->setConfig($config);
        }

        return $diff;
    }

    /**
     * {@inheritDoc}
     */
    public function build()
    {
        if ($this->hasDiffCache() && $this->getDiffCache()->contains($this->oldText, $this->newText)) {
            $this->content = $this->getDiffCache()->fetch($this->oldText, $this->newText);

            return $this->content;
        }

        $matchStrategy = new ListItemMatchStrategy($this->config->getMatchThreshold());
        $this->lcsService = new LcsService($matchStrategy);

        return $this->listByLines($this->oldText, $this->newText);
    }

    /**
     * @param string $old
     * @param string $new
     *
     * @return string
     */
    protected function listByLines($old, $new)
    {
        /* @var $newDom \simple_html_dom */
        $newDom = HtmlDomParser::str_get_html($new);
        /* @var $oldDom \simple_html_dom */
        $oldDom = HtmlDomParser::str_get_html($old);

        $newListNode = $this->findListNode($newDom);
        $oldListNode = $this->findListNode($oldDom);

        $operations = $this->getListItemOperations($oldListNode, $newListNode);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        return $this->processOperations($operations, $oldListNode, $newListNode);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     * @param \simple_html_dom|\simple_html_dom_node $dom
     *
     * @return \simple_html_dom_node[]|\simple_html_dom_node|null
     */
    protected function findListNode($dom)
    {
        return $dom->find(implode(', ', static::$listTypes), 0);
    }

    /**
     * @param \simple_html_dom_node $oldListNode
     * @param \simple_html_dom_node $newListNode
     *
     * @return array|Operation[]
     */
    protected function getListItemOperations(\simple_html_dom_node $oldListNode, \simple_html_dom_node $newListNode)
    {
        // Prepare arrays of list item content to use in LCS algorithm
        $oldListText = $this->getListTextArray($oldListNode);
        $newListText = $this->getListTextArray($newListNode);

        $lcsMatches = $this->lcsService->longestCommonSubsequence($oldListText, $newListText);

        $oldLength = count($oldListText);
        $newLength = count($newListText);

        $operations = [];
        $currentLineInOld = 0;
        $currentLineInNew = 0;
        $lcsMatches[$oldLength + 1] = $newLength + 1;
        foreach ($lcsMatches as $matchInOld => $matchInNew) {
            // No matching line in new list
            if ($matchInNew === 0) {
                continue;
            }

            $nextLineInOld = $currentLineInOld + 1;
            $nextLineInNew = $currentLineInNew + 1;

            if ($matchInNew > $nextLineInNew && $matchInOld > $nextLineInOld) {
                // Change
                $operations[] = new Operation(
                    Operation::CHANGED,
                    $nextLineInOld,
                    $matchInOld - 1,
                    $nextLineInNew,
                    $matchInNew - 1
                );
            } elseif ($matchInNew > $nextLineInNew && $matchInOld === $nextLineInOld) {
                // Add items before this
                $operations[] = new Operation(
                    Operation::ADDED,
                    $currentLineInOld,
                    $currentLineInOld,
                    $nextLineInNew,
                    $matchInNew - 1
                );
            } elseif ($matchInNew === $nextLineInNew && $matchInOld > $nextLineInOld) {
                // Delete items before this
                $operations[] = new Operation(
                    Operation::DELETED,
                    $nextLineInOld,
                    $matchInOld - 1,
                    $currentLineInNew,
                    $currentLineInNew
                );
            }

            $currentLineInNew = $matchInNew;
            $currentLineInOld = $matchInOld;
        }

        return $operations;
    }

    /**
     * @param \simple_html_dom_node $listNode
     *
     * @return array
     */
    protected function getListTextArray($listNode)
    {
        $output = array();
        foreach ($listNode->children() as $listItem) {
            $output[] = $this->getRelevantNodeText($listItem);
        }

        return $output;
    }

    /**
     * @param \simple_html_dom_node $node
     *
     * @return string
     */
    protected function getRelevantNodeText(\simple_html_dom_node $node)
    {
        if (!$node->hasChildNodes()) {
            return $node->innertext();
        }

        $output = '';
        foreach ($node->nodes as $child) {
            /* @var $child \simple_html_dom_node */
            if (!$child->hasChildNodes()) {
                $output .= $child->outertext();
            } elseif (in_array($child->nodeName(), static::$listContentTags, true)) {
                $output .= sprintf('<%1$s>%2$s</%1$s>', $child->nodeName(), $this->getRelevantNodeText($child));
            }
        }

        return $output;
    }

    /**
     * @param \simple_html_dom_node $li
     *
     * @return string
     */
    protected function deleteListItem($li)

    {
        $this->addClassToNode($li, self::CLASS_LIST_ITEM_DELETED);
        $li->innertext = sprintf('<del>%s</del>', $li->innertext);

        return $li->outertext;
    }

    /**
     * @param \simple_html_dom_node $li
     * @param bool                  $replacement
     *
     * @return string
     */
    protected function addListItem($li, $replacement = false)

    {
        $this->addClassToNode($li, $replacement ? self::CLASS_LIST_ITEM_CHANGED : self::CLASS_LIST_ITEM_ADDED);
        $li->innertext = sprintf('<ins>%s</ins>', $li->innertext);

        return $li->outertext;
    }

    /**
     * @param Operation[]|array     $operations
     * @param \simple_html_dom_node $oldListNode
     * @param \simple_html_dom_node $newListNode
     *
     * @return string
     */
    protected function processOperations($operations, $oldListNode, $newListNode)
    {
        $output = '';

        $indexInOld = 0;
        $indexInNew = 0;
        $lastOperation = null;

        foreach ($operations as $operation) {
            $replaced = false;
            while ($operation->startInOld > ($operation->action === Operation::ADDED ? $indexInOld : $indexInOld + 1)) {
                $li = $oldListNode->children($indexInOld);
                $matchingLi = null;
                if ($operation->startInNew > ($operation->action === Operation::DELETED ? $indexInNew
                        : $indexInNew + 1)
                ) {
                    $matchingLi = $newListNode->children($indexInNew);
                }
                if (null !== $matchingLi) {

                    $htmlDiff = HtmlDiff::create($li->innertext, $matchingLi->innertext, $this->config);
                    $li->innertext = $htmlDiff->build();
                    $indexInNew++;
                }
                $class = self::CLASS_LIST_ITEM_NONE;

                if ($lastOperation === Operation::DELETED && !$replaced) {
                    $class = self::CLASS_LIST_ITEM_CHANGED;
                    $replaced = true;
                }
                $li->setAttribute('class', trim($li->getAttribute('class').' '.$class));

                $output .= $li->outertext;
                $indexInOld++;
            }

            switch ($operation->action) {
                case Operation::ADDED:
                    for ($i = $operation->startInNew; $i <= $operation->endInNew; $i++) {

                        $output .= $this->addListItem($newListNode->children($i - 1));
                    }
                    $indexInNew = $operation->endInNew;
                    break;

                case Operation::DELETED:
                    for ($i = $operation->startInOld; $i <= $operation->endInOld; $i++) {

                        $output .= $this->deleteListItem($oldListNode->children($i - 1));
                    }
                    $indexInOld = $operation->endInOld;
                    break;

                case Operation::CHANGED:
                    $changeDelta = 0;
                    for ($i = $operation->startInOld; $i <= $operation->endInOld; $i++) {

                        $output .= $this->deleteListItem($oldListNode->children($i - 1));
                        $changeDelta--;
                    }
                    for ($i = $operation->startInNew; $i <= $operation->endInNew; $i++) {

                        $output .= $this->addListItem($newListNode->children($i - 1), $changeDelta < 0);
                        $changeDelta++;
                    }
                    $indexInOld = $operation->endInOld;
                    $indexInNew = $operation->endInNew;
                    break;
            }

            $lastOperation = $operation->action;
        }

        $oldCount = count($oldListNode->children());
        $newCount = count($newListNode->children());
        while ($indexInOld < $oldCount) {
            $li = $oldListNode->children($indexInOld);
            $matchingLi = null;
            if ($indexInNew < $newCount) {
                $matchingLi = $newListNode->children($indexInNew);
            }
            if (null !== $matchingLi) {

                $htmlDiff = HtmlDiff::create($li->innertext(), $matchingLi->innertext(), $this->config);
                $li->innertext = $htmlDiff->build();
                $indexInNew++;
            }
            $class = self::CLASS_LIST_ITEM_NONE;

            if ($lastOperation === Operation::DELETED) {
                $class = self::CLASS_LIST_ITEM_CHANGED;
            }
            $li->setAttribute('class', trim($li->getAttribute('class').' '.$class));

            $output .= $li->outertext;
            $indexInOld++;
        }

        $newListNode->innertext = $output;
        $newListNode->setAttribute('class', trim($newListNode->getAttribute('class').' diff-list'));

        return $newListNode->outertext;
    }

    /**
     * @param \simple_html_dom_node $node
     * @param string                $class
     */
    protected function addClassToNode(\simple_html_dom_node $node, $class)
    {
        $node->setAttribute('class', trim(sprintf('%s %s', $node->getAttribute('class'), $class)));
    }
}


1			<?php
2
3			namespace Caxy\HtmlDiff;
4
5			use Caxy\HtmlDiff\Strategy\ListItemMatchStrategy;
6			use Sunra\PhpSimple\HtmlDomParser;
7
8			class ListDiffLines extends AbstractDiff
9			{
10			const CLASS_LIST_ITEM_ADDED = 'normal new';
11			const CLASS_LIST_ITEM_DELETED = 'removed';
12			const CLASS_LIST_ITEM_CHANGED = 'replacement';
13			const CLASS_LIST_ITEM_NONE = 'normal';
14
15			protected static $listTypes = array('ul', 'ol', 'dl');
16
17			/**
18			* List of tags that should be included when retrieving
19			* text from a single list item that will be used in
20			* matching logic (and only in matching logic).
21			*
22			* @see getRelevantNodeText()
23			*
24			* @var array
25			*/
26			protected static $listContentTags = array(
27			'h1','h2','h3','h4','h5','pre','div','br','hr','code',
28			'input','form','img','span','a','i','b','strong','em',
29			'font','big','del','tt','sub','sup','strike',
30			);
31
32			/**
33			* @var LcsService
34			*/
35			protected $lcsService;
36
37			/**
38			* @param string $oldText
39			* @param string $newText
40			* @param HtmlDiffConfig\|null $config
41			*
42			* @return ListDiffLines
43			*/
44	7	View Code Duplication	public static function create($oldText, $newText, HtmlDiffConfig $config = null)
			0 ignored issues – show Duplication introduced 2016-05-18 21:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45			{
46	7		$diff = new self($oldText, $newText);
47
48	7		if (null !== $config) {
49	7		$diff->setConfig($config);
50	7		}
51
52	7		return $diff;
53			}
54
55			/**
56			* {@inheritDoc}
57			*/
58	7		public function build()
59			{
60	7		if ($this->hasDiffCache() && $this->getDiffCache()->contains($this->oldText, $this->newText)) {
61			$this->content = $this->getDiffCache()->fetch($this->oldText, $this->newText);
62
63			return $this->content;
64			}
65
66	7		$matchStrategy = new ListItemMatchStrategy($this->config->getMatchThreshold());
67	7		$this->lcsService = new LcsService($matchStrategy);
68
69	7		return $this->listByLines($this->oldText, $this->newText);
70			}
71
72			/**
73			* @param string $old
74			* @param string $new
75			*
76			* @return string
77			*/
78	7		protected function listByLines($old, $new)
79			{
80			/* @var $newDom \simple_html_dom */
81	7		$newDom = HtmlDomParser::str_get_html($new);
82			/* @var $oldDom \simple_html_dom */
83	7		$oldDom = HtmlDomParser::str_get_html($old);
84
85	7		$newListNode = $this->findListNode($newDom);
86	7		$oldListNode = $this->findListNode($oldDom);
87
88	7		$operations = $this->getListItemOperations($oldListNode, $newListNode);
			0 ignored issues – show Bug introduced 2016-05-18 21:18 UTC by Report Bug Copy Issue Report It seems like `$oldListNode` defined by `$this->findListNode($oldDom)` on line `86` can also be of type `array<integer,object<simple_html_dom_node>>` or `null`; however, `Caxy\HtmlDiff\ListDiffLi...getListItemOperations()` does only seem to accept `object<simple_html_dom_node>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string / function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2016-05-18 21:18 UTC by Report Bug Copy Issue Report It seems like `$newListNode` defined by `$this->findListNode($newDom)` on line `85` can also be of type `array<integer,object<simple_html_dom_node>>` or `null`; however, `Caxy\HtmlDiff\ListDiffLi...getListItemOperations()` does only seem to accept `object<simple_html_dom_node>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /* * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
89
90	7		return $this->processOperations($operations, $oldListNode, $newListNode);
			0 ignored issues – show Bug introduced 2016-05-18 22:55 UTC by Report Bug Copy Issue Report It seems like `$oldListNode` defined by `$this->findListNode($oldDom)` on line `86` can also be of type `array<integer,object<simple_html_dom_node>>` or `null`; however, `Caxy\HtmlDiff\ListDiffLines::processOperations()` does only seem to accept `object<simple_html_dom_node>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string / function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2016-05-18 22:55 UTC by Report Bug Copy Issue Report It seems like `$newListNode` defined by `$this->findListNode($newDom)` on line `85` can also be of type `array<integer,object<simple_html_dom_node>>` or `null`; however, `Caxy\HtmlDiff\ListDiffLines::processOperations()` does only seem to accept `object<simple_html_dom_node>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /* * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
91			}
92
93			/**
94			* @param \simple_html_dom\|\simple_html_dom_node $dom
95			*
96			* @return \simple_html_dom_node[]\|\simple_html_dom_node\|null
97			*/
98	7		protected function findListNode($dom)
99			{
100	7		return $dom->find(implode(', ', static::$listTypes), 0);
101			}
102
103			/**
104			* @param \simple_html_dom_node $oldListNode
105			* @param \simple_html_dom_node $newListNode
106			*
107			* @return array\|Operation[]
108			*/
109	7		protected function getListItemOperations(\simple_html_dom_node $oldListNode, \simple_html_dom_node $newListNode)
110			{
111			// Prepare arrays of list item content to use in LCS algorithm
112	7		$oldListText = $this->getListTextArray($oldListNode);
113	7		$newListText = $this->getListTextArray($newListNode);
114
115	7		$lcsMatches = $this->lcsService->longestCommonSubsequence($oldListText, $newListText);
116
117	7		$oldLength = count($oldListText);
118	7		$newLength = count($newListText);
119
120	7		$operations = [];
121	7		$currentLineInOld = 0;
122	7		$currentLineInNew = 0;
123	7		$lcsMatches[$oldLength + 1] = $newLength + 1;
124	7		foreach ($lcsMatches as $matchInOld => $matchInNew) {
125			// No matching line in new list
126	7		if ($matchInNew === 0) {
127	7		continue;
128			}
129
130	7		$nextLineInOld = $currentLineInOld + 1;
131	7		$nextLineInNew = $currentLineInNew + 1;
132
133	7		if ($matchInNew > $nextLineInNew && $matchInOld > $nextLineInOld) {
134			// Change
135	1		$operations[] = new Operation(
136	1		Operation::CHANGED,
137	1		$nextLineInOld,
138	1		$matchInOld - 1,
139	1		$nextLineInNew,
140			$matchInNew - 1
141	1		);
142	7		} elseif ($matchInNew > $nextLineInNew && $matchInOld === $nextLineInOld) {
143			// Add items before this
144	3		$operations[] = new Operation(
145	3		Operation::ADDED,
146	3		$currentLineInOld,
147	3		$currentLineInOld,
148	3		$nextLineInNew,
149			$matchInNew - 1
150	3		);
151	7		} elseif ($matchInNew === $nextLineInNew && $matchInOld > $nextLineInOld) {
152			// Delete items before this
153	2		$operations[] = new Operation(
154	2		Operation::DELETED,
155	2		$nextLineInOld,
156	2		$matchInOld - 1,
157	2		$currentLineInNew,
158			$currentLineInNew
159	2		);
160	2		}
161
162	7		$currentLineInNew = $matchInNew;
163	7		$currentLineInOld = $matchInOld;
164	7		}
165
166	7		return $operations;
167			}
168
169			/**
170			* @param \simple_html_dom_node $listNode
171			*
172			* @return array
173			*/
174	7		protected function getListTextArray($listNode)
175			{
176	7		$output = array();
177	7		foreach ($listNode->children() as $listItem) {
178	7		$output[] = $this->getRelevantNodeText($listItem);
179	7		}
180
181	7		return $output;
182			}
183
184			/**
185			* @param \simple_html_dom_node $node
186			*
187			* @return string
188			*/
189	7		protected function getRelevantNodeText(\simple_html_dom_node $node)
190			{
191	7		if (!$node->hasChildNodes()) {
192	3		return $node->innertext();
193			}
194
195	5		$output = '';
196	5		foreach ($node->nodes as $child) {
197			/* @var $child \simple_html_dom_node */
198	5		if (!$child->hasChildNodes()) {
199	5		$output .= $child->outertext();
200	5		} elseif (in_array($child->nodeName(), static::$listContentTags, true)) {
201			$output .= sprintf('<%1$s>%2$s</%1$s>', $child->nodeName(), $this->getRelevantNodeText($child));
202			}
203	5		}
204
205	5		return $output;
206			}
207
208			/**
209			* @param \simple_html_dom_node $li
210			*
211			* @return string
212			*/
213	3	View Code Duplication	protected function deleteListItem($li)
			0 ignored issues – show Duplication introduced 2016-05-18 21:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
214			{
215	3		$this->addClassToNode($li, self::CLASS_LIST_ITEM_DELETED);
216	3		$li->innertext = sprintf('<del>%s</del>', $li->innertext);
217
218	3		return $li->outertext;
219			}
220
221			/**
222			* @param \simple_html_dom_node $li
223			* @param bool $replacement
224			*
225			* @return string
226			*/
227	4	View Code Duplication	protected function addListItem($li, $replacement = false)
			0 ignored issues – show Duplication introduced 2016-05-18 21:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
228			{
229	4		$this->addClassToNode($li, $replacement ? self::CLASS_LIST_ITEM_CHANGED : self::CLASS_LIST_ITEM_ADDED);
230	4		$li->innertext = sprintf('<ins>%s</ins>', $li->innertext);
231
232	4		return $li->outertext;
233			}
234
235			/**
236			* @param Operation[]\|array $operations
237			* @param \simple_html_dom_node $oldListNode
238			* @param \simple_html_dom_node $newListNode
239			*
240			* @return string
241			*/
242	7		protected function processOperations($operations, $oldListNode, $newListNode)
243			{
244	7		$output = '';
245
246	7		$indexInOld = 0;
247	7		$indexInNew = 0;
248	7		$lastOperation = null;
249
250	7		foreach ($operations as $operation) {
251	5		$replaced = false;
252	5		while ($operation->startInOld > ($operation->action === Operation::ADDED ? $indexInOld : $indexInOld + 1)) {
253	4		$li = $oldListNode->children($indexInOld);
254	4		$matchingLi = null;
255	4		if ($operation->startInNew > ($operation->action === Operation::DELETED ? $indexInNew
256	4		: $indexInNew + 1)
257	4		) {
258	4		$matchingLi = $newListNode->children($indexInNew);
259	4		}
260	4	View Code Duplication	if (null !== $matchingLi) {
			0 ignored issues – show Duplication introduced 2016-05-18 21:18 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
261	4		$htmlDiff = HtmlDiff::create($li->innertext, $matchingLi->innertext, $this->config);
262	4		$li->innertext = $htmlDiff->build();
263	4		$indexInNew++;
264	4		}
265	4		$class = self::CLASS_LIST_ITEM_NONE;
266
267	4		if ($lastOperation === Operation::DELETED && !$replaced) {
268	1		$class = self::CLASS_LIST_ITEM_CHANGED;
269	1		$replaced = true;
270	1		}
271	4		$li->setAttribute('class', trim($li->getAttribute('class').' '.$class));
272
273	4		$output .= $li->outertext;
274	4		$indexInOld++;
275	4		}
276
277	5		switch ($operation->action) {
278	5		case Operation::ADDED:
279	3	View Code Duplication	for ($i = $operation->startInNew; $i <= $operation->endInNew; $i++) {
			0 ignored issues – show Duplication introduced 2016-05-18 21:18 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
280	3		$output .= $this->addListItem($newListNode->children($i - 1));
281	3		}
282	3		$indexInNew = $operation->endInNew;
283	3		break;
284
285	3		case Operation::DELETED:
286	2	View Code Duplication	for ($i = $operation->startInOld; $i <= $operation->endInOld; $i++) {
			0 ignored issues – show Duplication introduced 2016-05-18 21:18 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
287	2		$output .= $this->deleteListItem($oldListNode->children($i - 1));
288	2		}
289	2		$indexInOld = $operation->endInOld;
290	2		break;
291
292	1		case Operation::CHANGED:
293	1		$changeDelta = 0;
294	1	View Code Duplication	for ($i = $operation->startInOld; $i <= $operation->endInOld; $i++) {
			0 ignored issues – show Duplication introduced 2016-05-18 21:18 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
295	1		$output .= $this->deleteListItem($oldListNode->children($i - 1));
296	1		$changeDelta--;
297	1		}
298	1	View Code Duplication	for ($i = $operation->startInNew; $i <= $operation->endInNew; $i++) {
			0 ignored issues – show Duplication introduced 2016-05-18 21:18 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
299	1		$output .= $this->addListItem($newListNode->children($i - 1), $changeDelta < 0);
300	1		$changeDelta++;
301	1		}
302	1		$indexInOld = $operation->endInOld;
303	1		$indexInNew = $operation->endInNew;
304	1		break;
305	5		}
306
307	5		$lastOperation = $operation->action;
308	7		}
309
310	7		$oldCount = count($oldListNode->children());
311	7		$newCount = count($newListNode->children());
312	7		while ($indexInOld < $oldCount) {
313	4		$li = $oldListNode->children($indexInOld);
314	4		$matchingLi = null;
315	4		if ($indexInNew < $newCount) {
316	4		$matchingLi = $newListNode->children($indexInNew);
317	4		}
318	4	View Code Duplication	if (null !== $matchingLi) {
			0 ignored issues – show Duplication introduced 2016-05-18 21:18 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
319	4		$htmlDiff = HtmlDiff::create($li->innertext(), $matchingLi->innertext(), $this->config);
320	4		$li->innertext = $htmlDiff->build();
321	4		$indexInNew++;
322	4		}
323	4		$class = self::CLASS_LIST_ITEM_NONE;
324
325	4		if ($lastOperation === Operation::DELETED) {
326			$class = self::CLASS_LIST_ITEM_CHANGED;
327			}
328	4		$li->setAttribute('class', trim($li->getAttribute('class').' '.$class));
329
330	4		$output .= $li->outertext;
331	4		$indexInOld++;
332	4		}
333
334	7		$newListNode->innertext = $output;
335	7		$newListNode->setAttribute('class', trim($newListNode->getAttribute('class').' diff-list'));
336
337	7		return $newListNode->outertext;
338			}
339
340			/**
341			* @param \simple_html_dom_node $node
342			* @param string $class
343			*/
344	5		protected function addClassToNode(\simple_html_dom_node $node, $class)
345			{
346	5		$node->setAttribute('class', trim(sprintf('%s %s', $node->getAttribute('class'), $class)));
347	5		}
348			}
349

caxy / php-htmldiff

Push — master ( 755472...23808d )

ListDiffLines::processOperations() F

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like