TablePosition::__toString() - Code Metrics - Inspection of "New Feature: Table Diffing" - caxy/php-htmldiff - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#31)

by Josh

created 2016-02-23 22:08 UTC

TablePosition::__toString() A

↳ Parent: TablePosition

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	4
ccs	0
cts	2
cp	0
rs	10
cc	1
eloc	2
nc	1
nop	0
crap	2

<?php

namespace Caxy\HtmlDiff\Table;

class TablePosition extends AbstractTableElement
{
    public $row;
    public $cell;

    public function __construct($row, $cell)
    {
        $this->row = $row;
        $this->cell = $cell;
    }

    public function getRow()

    {
        return $this->row;
    }

    public function getCell()

    {
        return $this->cell;
    }

    public function __toString()
    {
        return $this->row.':'.$this->cell;
    }

    public static function compare($a, $b)
    {
        if ($a->getRow() == $b->getRow()) {
            return $a->getCell() - $b->getCell();
        }

        return $a->getRow() - $b->getRow();
    }
}


1			<?php
2
3			namespace Caxy\HtmlDiff\Table;
4
5			class TablePosition extends AbstractTableElement
6			{
7			public $row;
8			public $cell;
9
10			public function __construct($row, $cell)
11			{
12			$this->row = $row;
13			$this->cell = $cell;
14			}
15
16			public function getRow()
			0 ignored issues – show Documentation introduced 2016-02-23 20:32 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
17			{
18			return $this->row;
19			}
20
21			public function getCell()
			0 ignored issues – show Documentation introduced 2016-02-23 20:32 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
22			{
23			return $this->cell;
24			}
25
26			public function __toString()
27			{
28			return $this->row.':'.$this->cell;
29			}
30
31			public static function compare($a, $b)
32			{
33			if ($a->getRow() == $b->getRow()) {
34			return $a->getCell() - $b->getCell();
35			}
36
37			return $a->getRow() - $b->getRow();
38			}
39			}
40

caxy / php-htmldiff

Pull Request — master (#31)

TablePosition::__toString() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like