Caxy\HtmlDiff\Table\TableCell

Complexity

Total Complexity

7

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes	5
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getRow()	0	4	1
A	setRow()	0	10	2
A	getColspan()	0	4	2
A	getRowspan()	0	4	2

<?php

namespace Caxy\HtmlDiff\Table;

/**
 * Class TableCell
 * @package Caxy\HtmlDiff\Table
 */
class TableCell extends AbstractTableElement
{
    /**
     * @var TableRow
     */
    protected $row;

    /**
     * @return TableRow
     */
    public function getRow()
    {
        return $this->row;
    }

    /**
     * @param TableRow|null $row
     *
     * @return $this
     */
    public function setRow(TableRow $row = null)
    {
        $this->row = $row;

        if (!in_array($this, $row->getCells())) {
            $row->addCell($this);

It seems like $row is not always an object, but can also be of type null. Maybe add an additional type check?

        }

        return $this;
    }

    /**
     * @return int

Should the return type not be string|integer?

     */
    public function getColspan()
    {
        return $this->getAttribute('colspan') ?: 1;
    }

    /**
     * @return int

Should the return type not be string|integer?

     */
    public function getRowspan()
    {
        return $this->getAttribute('rowspan') ?: 1;
    }
}