app\modules\v1\controllers\TelegramController::actionHook()

Complexity

Conditions	13
Paths	12

Size

Total Lines	151
Code Lines	94

Duplication

Lines	0
Ratio	0 %

Importance

Changes	7
Bugs	3	Features	4

<?php
    public function actionHook()
    {
        try {
            $bot = TelegramService::newClient();

            $bot->callbackQuery(function (CallbackQuery $message) use ($bot) {
                $bot->answerCallbackQuery($message->getId(), "Loading...");
                $user = $this->userService->getUserByClientId(
                    AuthClientType::TELEGRAM,
                    $message->getFrom()->getId()
                );
                if ($user) {

$user is of type app\core\models\User, thus it always evaluated to true.

                    \Yii::$app->user->setIdentity($user);
                    $this->telegramService->callbackQuery($message, $bot);
                }
            });

            $bot->command(ltrim(TelegramKeyword::REPORT, '/'), function (Message $message) use ($bot) {
                $keyboard = new ReplyKeyboardMarkup(
                    [[TelegramKeyword::TODAY, TelegramKeyword::YESTERDAY, TelegramKeyword::LAST_MONTH]],
                    true
                );
                /** @var BotApi $bot */
                $bot->sendMessage($message->getChat()->getId(), '请选择统计范围', null, false, null, $keyboard);
            });

            $bot->command(ltrim(TelegramKeyword::CMD, '/'), function (Message $message) use ($bot) {
                $keyboard = new ReplyKeyboardMarkup(
                    [[TelegramKeyword::REPORT]],
                    true
                );
                /** @var BotApi $bot */
                $bot->sendMessage($message->getChat()->getId(), '请选择指令', null, false, null, $keyboard);
            });

            $bot->command(ltrim(TelegramKeyword::HELP, '/'), function (Message $message) use ($bot) {
                $text = "我能做什么？\n /help - 查看帮助 \n /cmd - 列出所有指令 \n /start - 开始使用 \n \n 绑定账号成功之后发送文字直接记账";
                /** @var BotApi $bot */
                $bot->sendMessage($message->getChat()->getId(), $text);
            });

            $bot->command('ping', function (Message $message) use ($bot) {
                $keyboard = new ReplyKeyboardMarkup(
                    [["one", "two", "three"]],
                    true
                ); // true for one-time keyboard
                /** @var BotApi $bot */
                $bot->sendMessage($message->getChat()->getId(), 'pong!', null, false, null, $keyboard);
            });

            $bot->command(ltrim(TelegramKeyword::START, '/'), function (Message $message) use ($bot) {
                $text = "您还未绑定账号，请先访问「个人设置」中的「账号绑定」进行绑定账号，然后才能快速记账。";
                $user = $this->userService->getUserByClientId(
                    AuthClientType::TELEGRAM,
                    $message->getFrom()->getId()
                );
                if ($user) {

$user is of type app\core\models\User, thus it always evaluated to true.

                    $text = '欢迎回来👏';
                }
                /** @var BotApi $bot */
                $bot->sendMessage($message->getChat()->getId(), $text);
            });

            $bot->on(function (Update $Update) use ($bot) {
                $message = $Update->getMessage();
                $user = $this->userService->getUserByClientId(
                    AuthClientType::TELEGRAM,
                    $message->getFrom()->getId()
                );
                if ($user) {

$user is of type app\core\models\User, thus it always evaluated to true.

                    \Yii::$app->user->setIdentity($user);
                    $type = ltrim($message->getText(), '/');
                    $text = $this->telegramService->getReportTextByType($type);
                } else {
                    $text = '请先绑定您的账号';
                }
                /** @var BotApi $bot */
                $bot->sendMessage($message->getChat()->getId(), $text);
            }, function (Update $message) {
                $msg = $message->getMessage();
                $report = [TelegramKeyword::TODAY, TelegramKeyword::YESTERDAY, TelegramKeyword::LAST_MONTH];
                if ($msg && in_array($msg->getText(), $report)) {
                    return true;
                }
                return false;
            });

//            $bot->on(function (Update $Update) use ($bot) {
//                $message = $Update->getMessage();
//                /** @var BotApi $bot */
//                $bot->sendMessage($message->getChat()->getId(), "hi");
//            }, function (Update $message) {
//                if ($message->getMessage() && $message->getMessage()->getText() == '/login') {
//                    return true;
//                }
//                return false;
//            });

            $bot->on(function (Update $Update) use ($bot) {
                $message = $Update->getMessage();
                $token = StringHelper::after(TelegramKeyword::BIND . '/', $message->getText());
                try {
                    $user = $this->userService->getUserByResetToken($token);
                    $this->telegramService->bind($user, $token, $message);

It seems like $user can also be of type array and null; however, parameter $user of app\core\services\TelegramService::bind() does only seem to accept app\core\models\User, maybe add an additional type check?

                    $text = '成功绑定账号【' . data_get($user, 'username') . '】！';
                } catch (\Exception $e) {
                    $text = $e->getMessage();
                }
                /** @var BotApi $bot */
                $bot->sendMessage($message->getChat()->getId(), $text);
            }, function (Update $message) {
                $msg = $message->getMessage();
                if ($msg && strpos($msg->getText(), TelegramKeyword::BIND) === 0) {
                    return true;
                }
                return false;
            });

            $bot->on(function (Update $Update) use ($bot) {
                $message = $Update->getMessage();
                $keyboard = null;
                try {
                    $user = $this->userService->getUserByClientId(
                        AuthClientType::TELEGRAM,
                        $message->getFrom()->getId()
                    );
                    \Yii::$app->user->setIdentity($user);
                    $model = $this->transactionService->createByDesc($message->getText(), RecordSource::TELEGRAM);
                    $keyboard = $this->telegramService->getRecordMarkup($model);
                    $text = $this->telegramService->getMessageTextByTransaction($model);
                } catch (\Exception $e) {
                    $text = $e->getMessage();
                }
                /** @var BotApi $bot */
                $bot->sendMessage($message->getChat()->getId(), $text, null, false, null, $keyboard);
            }, function (Update $message) {
                if ($message->getMessage()) {
                    if (ArrayHelper::strPosArr($message->getMessage()->getText(), TelegramKeyword::items()) === 0) {
                        return false;
                    }
                    return true;
                }
                return false;
            });

            $bot->run();
        } catch (\TelegramBot\Api\Exception $e) {
            Log::error('webHook error' . $e->getMessage(), (string)$e);
            throw $e;
        }
        return '';
    }