app\modules\v1\controllers\AccountController

Complexity

Total Complexity

12

Size/Duplication

Total Lines	100
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	actionTypes()	0	8	2
A	actionOverview()	0	24	4
A	actions()	0	6	1
A	actionCreate()	0	12	2
A	actionUpdate()	0	14	3

<?php

namespace app\modules\v1\controllers;

use app\core\models\Account;
use app\core\services\AccountService;
use app\core\traits\ServiceTrait;
use app\core\types\AccountStatus;
use app\core\types\AccountType;
use Exception;
use Yii;
use yii\web\NotFoundHttpException;
use yiier\helpers\Setup;

/**
 * Account controller for the `v1` module
 */
class AccountController extends ActiveController
{
    use ServiceTrait;

    public $modelClass = Account::class;
    public $noAuthActions = [];
    public $defaultOrder = ['sort' => SORT_ASC, 'id' => SORT_DESC];
    public $partialMatchAttributes = ['name'];
    public $stringToIntAttributes = ['type' => AccountType::class, 'status' => AccountStatus::class];

    public function actions()
    {
        $actions = parent::actions();
        // 注销系统自带的实现方法
        unset($actions['update'], $actions['create']);
        return $actions;
    }

    /**
     * @return Account
     * @throws Exception
     */
    public function actionCreate()
    {
        $params = Yii::$app->request->bodyParams;
        $model = new Account();
        $model->user_id = 0;
        if (data_get($params, 'type') == AccountType::CREDIT_CARD) {
            $model->setScenario(AccountType::CREDIT_CARD);
        }
        /** @var Account $model */
        $model = $this->validate($model, $params);

        return $this->accountService->createUpdate($model);
    }

    /**
     * @param int $id
     * @return Account
     * @throws NotFoundHttpException
     * @throws Exception
     */
    public function actionUpdate(int $id)
    {
        $params = Yii::$app->request->bodyParams;
        if (!$model = AccountService::findCurrentOne($id)) {
            throw new NotFoundHttpException();
        }

        if (data_get($params, 'type') == AccountType::CREDIT_CARD) {
            $model->setScenario(AccountType::CREDIT_CARD);
        }
        /** @var Account $model */
        $model = $this->validate($model, $params);

        return $this->accountService->createUpdate($model);
    }


    /**
     * @return array
     * @throws Exception
     */
    public function actionTypes()
    {
        $items = [];
        $texts = AccountType::texts();
        foreach (AccountType::names() as $key => $name) {
            $items[] = ['type' => $name, 'name' => data_get($texts, $key)];
        }
        return $items;
    }

    /**
     * @return array
     */
    public function actionOverview()
    {
        $balanceCentSum = Account::find()
            ->where(['user_id' => Yii::$app->user->id, 'exclude_from_stats' => false])
            ->sum('balance_cent');
        $items['net_asset'] = $balanceCentSum ? Setup::toYuan($balanceCentSum) : 0;

$items was never initialized. Although not strictly required by PHP, it is generally a good practice to add $items = array(); before regardless.

        $balanceCentSum = Account::find()
            ->where(['user_id' => Yii::$app->user->id, 'exclude_from_stats' => false])
            ->andWhere(['>', 'balance_cent', 0])
            ->sum('balance_cent');
        $items['total_assets'] = $balanceCentSum ? Setup::toYuan($balanceCentSum) : 0;

        $balanceCentSum = Account::find()
            ->where(['user_id' => Yii::$app->user->id, 'exclude_from_stats' => false])
            ->andWhere(['<', 'balance_cent', 0])
            ->sum('balance_cent');
        $items['liabilities'] = $balanceCentSum ? Setup::toYuan($balanceCentSum) : 0;

        $items['count'] = Account::find()
            ->where(['user_id' => Yii::$app->user->id, 'exclude_from_stats' => false])
            ->count('id');

        return $items;
    }
}