app\commands\GenerateController

Complexity

Total Complexity

3

Size/Duplication

Total Lines	18
Duplicated Lines	0 %

Importance

Changes	2
Bugs	1	Features	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	actionKey()	0	16	3

<?php

namespace app\commands;

use Yii;
use yii\console\Controller;
use yii\helpers\Console;
use yiier\helpers\Security;
use yiithings\dotenv\Loader;

class GenerateController extends Controller
{
    public function actionKey(bool $dryRun = false, string $filename = '.env')
    {
        $environmentFilePath = Yii::getAlias('@app/' . $filename);
        Loader::load('', $filename, true);
        foreach (['COOKIE_VALIDATION_KEY', 'JWT_SECRET'] as $item) {
            $escaped = preg_quote('=' . env($item), '/');

Are you sure env($item) of type false|string can be used in concatenation?

            $keyReplacementPattern = "/^{$item}{$escaped}/m";
            $key = Security::generateRealUniqId(32);
            if (!$dryRun) {
                file_put_contents($environmentFilePath, preg_replace(

It seems like $environmentFilePath can also be of type false; however, parameter $filename of file_put_contents() does only seem to accept string, maybe add an additional type check?

                    $keyReplacementPattern,
                    "{$item}={$key}",
                    file_get_contents($environmentFilePath)

It seems like $environmentFilePath can also be of type false; however, parameter $filename of file_get_contents() does only seem to accept string, maybe add an additional type check?

                ));
            }
            $this->stdout("{$item} key [{$key}] set successfully.\n", Console::FG_GREEN);
        }
    }
}