COG\ChronoShifter\Period\Month

Complexity

Total Complexity

7

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getStartDate()	0	4	1
A	getEndDate()	0	4	1
A	next()	0	5	1
A	previous()	0	5	1
A	getNumberOfDays()	0	7	1
A	setFromTimestamp()	0	6	1

<?php

namespace COG\ChronoShifter\Period;

/**
 * @author Kristjan Siimson <kristjan.siimson@cashongo.co.uk>
 * @package Period\Domain
 */
class Month implements Period
{
    /**
     * @var int
     */
    private $month;

    /**
     * @var int
     */
    private $year;

    /**
     * @var int
     */
    private $daysInMonth;

    /**
     * @param string $date
     */
    public function __construct($date)
    {
        $this->setFromTimestamp(strtotime($date));
    }

    /**
     * @return string
     */
    public function getStartDate()
    {
        return sprintf('%04d-%02d-01', $this->year, $this->month);
    }

    /**
     * @return string
     */
    public function getEndDate()
    {
        return sprintf('%04d-%02d-%02d', $this->year, $this->month, $this->daysInMonth);
    }

    public function next()
    {
        $timestamp = strtotime('first day of +1 month', strtotime($this->getStartDate()));
        $this->setFromTimestamp($timestamp);
    }

    public function previous()
    {
        $timestamp = strtotime('first day of -1 month', strtotime($this->getStartDate()));
        $this->setFromTimestamp($timestamp);
    }

    /**
     * @return int
     */
    public function getNumberOfDays()
    {
        $end = new \DateTime($this->getEndDate());
        $start = new \DateTime($this->getStartDate());

        return $end->diff($start)->days;

The expression $end->diff($start)->days; of type integer|false adds false to the return on line 70 which is incompatible with the return type declared by the interface COG\ChronoShifter\Period\Period::getNumberOfDays of type integer. It seems like you forgot to handle an error condition.

    }

    /**
     * @param int $timestamp
     */
    private function setFromTimestamp($timestamp)
    {
        $this->year = (int)date('Y', $timestamp);
        $this->month = (int)date('n', $timestamp);
        $this->daysInMonth = (int)date('t', strtotime($this->getStartDate()));
    }
}