Conditions | 1 |
Paths | 1 |
Total Lines | 60 |
Code Lines | 51 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
28 | public function dayOfWeekProvider() |
||
29 | { |
||
30 | return array( |
||
31 | array('2015-01-26', DayOfWeek::MONDAY, true), |
||
32 | array('2015-01-26', DayOfWeek::TUESDAY, false), |
||
33 | array('2015-01-26', DayOfWeek::WEDNESDAY, false), |
||
34 | array('2015-01-26', DayOfWeek::THURSDAY, false), |
||
35 | array('2015-01-26', DayOfWeek::FRIDAY, false), |
||
36 | array('2015-01-26', DayOfWeek::SATURDAY, false), |
||
37 | array('2015-01-26', DayOfWeek::SUNDAY, false), |
||
38 | |||
39 | array('2015-01-27', DayOfWeek::MONDAY, false), |
||
40 | array('2015-01-27', DayOfWeek::TUESDAY, true), |
||
41 | array('2015-01-27', DayOfWeek::WEDNESDAY, false), |
||
42 | array('2015-01-27', DayOfWeek::THURSDAY, false), |
||
43 | array('2015-01-27', DayOfWeek::FRIDAY, false), |
||
44 | array('2015-01-27', DayOfWeek::SATURDAY, false), |
||
45 | array('2015-01-27', DayOfWeek::SUNDAY, false), |
||
46 | |||
47 | array('2015-01-28', DayOfWeek::MONDAY, false), |
||
48 | array('2015-01-28', DayOfWeek::TUESDAY, false), |
||
49 | array('2015-01-28', DayOfWeek::WEDNESDAY, true), |
||
50 | array('2015-01-28', DayOfWeek::THURSDAY, false), |
||
51 | array('2015-01-28', DayOfWeek::FRIDAY, false), |
||
52 | array('2015-01-28', DayOfWeek::SATURDAY, false), |
||
53 | array('2015-01-28', DayOfWeek::SUNDAY, false), |
||
54 | |||
55 | array('2015-01-29', DayOfWeek::MONDAY, false), |
||
56 | array('2015-01-29', DayOfWeek::TUESDAY, false), |
||
57 | array('2015-01-29', DayOfWeek::WEDNESDAY, false), |
||
58 | array('2015-01-29', DayOfWeek::THURSDAY, true), |
||
59 | array('2015-01-29', DayOfWeek::FRIDAY, false), |
||
60 | array('2015-01-29', DayOfWeek::SATURDAY, false), |
||
61 | array('2015-01-29', DayOfWeek::SUNDAY, false), |
||
62 | |||
63 | array('2015-01-30', DayOfWeek::MONDAY, false), |
||
64 | array('2015-01-30', DayOfWeek::TUESDAY, false), |
||
65 | array('2015-01-30', DayOfWeek::WEDNESDAY, false), |
||
66 | array('2015-01-30', DayOfWeek::THURSDAY, false), |
||
67 | array('2015-01-30', DayOfWeek::FRIDAY, true), |
||
68 | array('2015-01-30', DayOfWeek::SATURDAY, false), |
||
69 | array('2015-01-30', DayOfWeek::SUNDAY, false), |
||
70 | |||
71 | array('2015-01-31', DayOfWeek::MONDAY, false), |
||
72 | array('2015-01-31', DayOfWeek::TUESDAY, false), |
||
73 | array('2015-01-31', DayOfWeek::WEDNESDAY, false), |
||
74 | array('2015-01-31', DayOfWeek::THURSDAY, false), |
||
75 | array('2015-01-31', DayOfWeek::FRIDAY, false), |
||
76 | array('2015-01-31', DayOfWeek::SATURDAY, true), |
||
77 | array('2015-01-31', DayOfWeek::SUNDAY, false), |
||
78 | |||
79 | array('2015-02-01', DayOfWeek::MONDAY, false), |
||
80 | array('2015-02-01', DayOfWeek::TUESDAY, false), |
||
81 | array('2015-02-01', DayOfWeek::WEDNESDAY, false), |
||
82 | array('2015-02-01', DayOfWeek::THURSDAY, false), |
||
83 | array('2015-02-01', DayOfWeek::FRIDAY, false), |
||
84 | array('2015-02-01', DayOfWeek::SATURDAY, false), |
||
85 | array('2015-02-01', DayOfWeek::SUNDAY, true) |
||
86 | ); |
||
87 | } |
||
88 | |||
113 |