OnOrAfter - Code Metrics - cashongo/chronoShifter - Measure and Improve Code Quality continuously with Scrutinizer

OnOrAfter A
last analyzed 2016-05-11 12:19 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	28
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	2
c	1
b	0
f	0
lcom	1
cbo	0
dl	28
loc	28
ccs	8
cts	8
cp	1
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	5	5	1
A	accept()	7	7	1

How to fix Duplicated Code

<?php

namespace COG\ChronoShifter\Iterator\Filter;

/**
 * @author Kristjan Siimson <[email protected]>
 * @package Iterator\Filter\Domain
 */
class OnOrAfter extends \FilterIterator

{
    /**
     * @var string
     */
    private $date;

    /**
     * @param \Iterator $iterator
     * @param string $date
     */
    public function __construct(\Iterator $iterator, $date)
    {
        parent::__construct($iterator);
        $this->date = substr($date, 0, 10);
    }

    /**
     * @return bool
     */
    public function accept()
    {
        $current = new \DateTime(parent::current());
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $current->setTime(0, 0, 0);

        return $current >= new \DateTime($this->date);
    }
}


1			<?php
2
3			namespace COG\ChronoShifter\Iterator\Filter;
4
5			/**
6			* @author Kristjan Siimson <[email protected]>
7			* @package Iterator\Filter\Domain
8			*/
9		View Code Duplication	class OnOrAfter extends \FilterIterator
			0 ignored issues – show Duplication introduced 2016-05-10 11:37 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
10			{
11			/**
12			* @var string
13			*/
14			private $date;
15
16			/**
17			* @param \Iterator $iterator
18			* @param string $date
19			*/
20	1		public function __construct(\Iterator $iterator, $date)
21			{
22	1		parent::__construct($iterator);
23	1		$this->date = substr($date, 0, 10);
24	1		}
25
26			/**
27			* @return bool
28			*/
29	1		public function accept()
30			{
31	1		$current = new \DateTime(parent::current());
			0 ignored issues – show Comprehensibility Bug introduced 2016-05-10 11:37 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`current()` instead of `accept()`). Are you sure this is correct? If so, you might want to change this to `$this->current()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
32	1		$current->setTime(0, 0, 0);
33
34	1		return $current >= new \DateTime($this->date);
35			}
36			}
37

cashongo / chronoShifter

GitHub Access Token became invalid

OnOrAfter A last analyzed 2016-05-11 12:19 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

OnOrAfter A
last analyzed 2016-05-11 12:19 UTC