TickersResponseItem::getClosePrice() - Code Metrics - Inspection of "v.3.1.0 Implement Workerman instead TextTalk. Add..." - carpenstar/bybitapi-sdk-websockets - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#10)

by Vladislav

created 2024-08-29 22:04 UTC

TickersResponseItem::getClosePrice() A

↳ Parent: TickersResponseItem

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	1
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	3
rs	10

<?php

namespace Carpenstar\ByBitAPI\WebSockets\Channels\Spot\PublicChannels\Tickers\Entities;

use Carpenstar\ByBitAPI\Core\Helpers\DateTimeHelper;
use Carpenstar\ByBitAPI\Core\Objects\AbstractResponse;

/**
 * https://bybit-exchange.github.io/docs/derivatives/ws-public/ticker
 */
class TickersResponseItem extends AbstractResponse
{
    /**
     * Trading pair
     * @var string $symbol
     */
    private string $symbol;

    /**
     * Timestamp (trading time in the match box)
     * @var null|\DateTime $timestamp
     */
    private ?\DateTime $timestamp;

    /**
     * Open price
     * @var float $openPrice
     */
    private float $openPrice;

    /**
     * High price
     * @var float $highPrice
     */
    private float $highPrice;

    /**
     * Low price
     * @var float $lowPrice
     */
    private float $lowPrice;

    /**
     * Close price
     * @var float $closePrice
     */
    private float $closePrice;

    /**
     * Trading volume
     * @var float $tradingVolume
     */
    private float $tradingVolume;

    /**
     * Trading quote volume
     * @var float $tradinguoteVolume
     */
    private float $tradinqQuoteVolume;

    /**
     * Change
     * @var float $change
     */
    private float $change;

    /**
     * USD index price. It can be empty
     * @var null|string $usdIndexPrice
     */
    private ?string $usdIndexPrice;

    public function __construct(array $data)
    {
        $this->timestamp =  DateTimeHelper::makeFromTimestamp($data['t']);
        $this->symbol = $data['s'];
        $this->openPrice = $data['o'];
        $this->highPrice = $data['h'];
        $this->lowPrice = $data['l'];
        $this->closePrice = $data['c'];
        $this->tradingVolume = $data['v'];
        $this->tradinqQuoteVolume = $data['qv'];
        $this->change = $data['m'];
        $this->usdIndexPrice = $data['xp'];
    }

    /**
     * @return string|null
     */
    public function getSymbol(): ?string
    {
        return $this->symbol;
    }

    /**
     * @return string|null
     */
    public function getOpenPrice(): ?float
    {
        return $this->openPrice;
    }

    /**
     * @return float|null
     */
    public function getHighPrice(): ?float
    {
        return $this->highPrice;
    }

    /**
     * @return float|null
     */
    public function getLowPrice(): ?float
    {
        return $this->lowPrice;
    }

    /**
     * @return float|null
     */
    public function getClosePrice(): ?float
    {
        return $this->closePrice;
    }

    /**
     * @return float|null
     */
    public function getTradingVolume(): ?float
    {
        return $this->tradingVolume;
    }

    /**
     * @return float|null
     */
    public function getTradingQuoteVolume(): ?float
    {
        return $this->tradinqQuoteVolume;
    }

    /**
     * @return float|null
     */
    public function getChange(): ?float
    {
        return $this->change;
    }

    /**
     * @return float|null
     */
    public function getUsdIndexPrice(): ?string
    {
        return $this->usdIndexPrice;

    }

    /**
     * @return \DateTime|null
     */
    public function getTimestamp(): ?\DateTime
    {
        return $this->timestamp;
    }
}


1			<?php
2
3			namespace Carpenstar\ByBitAPI\WebSockets\Channels\Spot\PublicChannels\Tickers\Entities;
4
5			use Carpenstar\ByBitAPI\Core\Helpers\DateTimeHelper;
6			use Carpenstar\ByBitAPI\Core\Objects\AbstractResponse;
7
8			/**
9			* https://bybit-exchange.github.io/docs/derivatives/ws-public/ticker
10			*/
11			class TickersResponseItem extends AbstractResponse
12			{
13			/**
14			* Trading pair
15			* @var string $symbol
16			*/
17			private string $symbol;
18
19			/**
20			* Timestamp (trading time in the match box)
21			* @var null\|\DateTime $timestamp
22			*/
23			private ?\DateTime $timestamp;
24
25			/**
26			* Open price
27			* @var float $openPrice
28			*/
29			private float $openPrice;
30
31			/**
32			* High price
33			* @var float $highPrice
34			*/
35			private float $highPrice;
36
37			/**
38			* Low price
39			* @var float $lowPrice
40			*/
41			private float $lowPrice;
42
43			/**
44			* Close price
45			* @var float $closePrice
46			*/
47			private float $closePrice;
48
49			/**
50			* Trading volume
51			* @var float $tradingVolume
52			*/
53			private float $tradingVolume;
54
55			/**
56			* Trading quote volume
57			* @var float $tradinguoteVolume
58			*/
59			private float $tradinqQuoteVolume;
60
61			/**
62			* Change
63			* @var float $change
64			*/
65			private float $change;
66
67			/**
68			* USD index price. It can be empty
69			* @var null\|string $usdIndexPrice
70			*/
71			private ?string $usdIndexPrice;
72
73			public function __construct(array $data)
74			{
75			$this->timestamp = DateTimeHelper::makeFromTimestamp($data['t']);
76			$this->symbol = $data['s'];
77			$this->openPrice = $data['o'];
78			$this->highPrice = $data['h'];
79			$this->lowPrice = $data['l'];
80			$this->closePrice = $data['c'];
81			$this->tradingVolume = $data['v'];
82			$this->tradinqQuoteVolume = $data['qv'];
83			$this->change = $data['m'];
84			$this->usdIndexPrice = $data['xp'];
85			}
86
87			/**
88			* @return string\|null
89			*/
90			public function getSymbol(): ?string
91			{
92			return $this->symbol;
93			}
94
95			/**
96			* @return string\|null
97			*/
98			public function getOpenPrice(): ?float
99			{
100			return $this->openPrice;
101			}
102
103			/**
104			* @return float\|null
105			*/
106			public function getHighPrice(): ?float
107			{
108			return $this->highPrice;
109			}
110
111			/**
112			* @return float\|null
113			*/
114			public function getLowPrice(): ?float
115			{
116			return $this->lowPrice;
117			}
118
119			/**
120			* @return float\|null
121			*/
122			public function getClosePrice(): ?float
123			{
124			return $this->closePrice;
125			}
126
127			/**
128			* @return float\|null
129			*/
130			public function getTradingVolume(): ?float
131			{
132			return $this->tradingVolume;
133			}
134
135			/**
136			* @return float\|null
137			*/
138			public function getTradingQuoteVolume(): ?float
139			{
140			return $this->tradinqQuoteVolume;
141			}
142
143			/**
144			* @return float\|null
145			*/
146			public function getChange(): ?float
147			{
148			return $this->change;
149			}
150
151			/**
152			* @return float\|null
153			*/
154			public function getUsdIndexPrice(): ?string
155			{
156			return $this->usdIndexPrice;
			0 ignored issues – show Bug Best Practice introduced 2023-05-13 21:58 UTC by Report Bug Copy Issue Report The expression `return $this->usdIndexPrice` also could return the type `string` which is incompatible with the documented return type `double\|null`. Loading history...
157			}
158
159			/**
160			* @return \DateTime\|null
161			*/
162			public function getTimestamp(): ?\DateTime
163			{
164			return $this->timestamp;
165			}
166			}
167

carpenstar / bybitapi-sdk-websockets

Pull Request — master (#10)

TickersResponseItem::getClosePrice() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like