BoocktickerResponseItem::__construct() - Code Metrics - Inspection of "v.3.1.0 Implement Workerman instead TextTalk. Add..." - carpenstar/bybitapi-sdk-websockets - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#10)

by Vladislav

created 2024-08-29 22:04 UTC

BoocktickerResponseItem::__construct() A

↳ Parent: BoocktickerResponseItem

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	6
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	8
rs	10

<?php

namespace Carpenstar\ByBitAPI\WebSockets\Channels\Spot\PublicChannels\Bookticker\Entities;

use Carpenstar\ByBitAPI\Core\Helpers\DateTimeHelper;
use Carpenstar\ByBitAPI\Core\Objects\AbstractResponse;

class BoocktickerResponseItem extends AbstractResponse
{
    private string $symbol;
    private ?float $bestBidPrice;
    private ?float $bidQuantity;
    private ?float $bestAskPrice;
    private ?float $askQuantity;
    private \DateTime $responseTimestamp;


    public function __construct(array $data)
    {
        $this->responseTimestamp = DateTimeHelper::makeFromTimestamp($data['t']);
        $this->bestBidPrice = $data['bp'] ?? null;
        $this->bidQuantity = $data['bq'] ?? null;
        $this->bestAskPrice = $data['ap'] ?? null;
        $this->askQuantity = $data['aq'] ?? null;
        $this->symbol = $data['s'];
    }

    /**
     * @return \DateTime
     */
    public function getResponseTimestamp(): \DateTime
    {
        return $this->responseTimestamp;
    }

    /**
     * @return float
     */
    public function getBestBidPrice(): float
    {
        return $this->bestBidPrice;

    }

    /**
     * @return float
     */
    public function getBidQuantity(): float
    {
        return $this->bidQuantity;

    }

    /**
     * @return float
     */
    public function getBestAskPrice(): float
    {
        return $this->bestAskPrice;

    }

    /**
     * @return float
     */
    public function getAskQuantity(): float
    {
        return $this->askQuantity;

    }

    /**
     * @return string
     */
    public function getSymbol(): string
    {
        return $this->symbol;
    }
}


1			<?php
2
3			namespace Carpenstar\ByBitAPI\WebSockets\Channels\Spot\PublicChannels\Bookticker\Entities;
4
5			use Carpenstar\ByBitAPI\Core\Helpers\DateTimeHelper;
6			use Carpenstar\ByBitAPI\Core\Objects\AbstractResponse;
7
8			class BoocktickerResponseItem extends AbstractResponse
9			{
10			private string $symbol;
11			private ?float $bestBidPrice;
12			private ?float $bidQuantity;
13			private ?float $bestAskPrice;
14			private ?float $askQuantity;
15			private \DateTime $responseTimestamp;
16
17
18			public function __construct(array $data)
19			{
20			$this->responseTimestamp = DateTimeHelper::makeFromTimestamp($data['t']);
21			$this->bestBidPrice = $data['bp'] ?? null;
22			$this->bidQuantity = $data['bq'] ?? null;
23			$this->bestAskPrice = $data['ap'] ?? null;
24			$this->askQuantity = $data['aq'] ?? null;
25			$this->symbol = $data['s'];
26			}
27
28			/**
29			* @return \DateTime
30			*/
31			public function getResponseTimestamp(): \DateTime
32			{
33			return $this->responseTimestamp;
34			}
35
36			/**
37			* @return float
38			*/
39			public function getBestBidPrice(): float
40			{
41			return $this->bestBidPrice;
			0 ignored issues – show Bug Best Practice introduced 2024-08-29 22:20 UTC by Report Bug Copy Issue Report The expression `return $this->bestBidPrice` could return the type `null` which is incompatible with the type-hinted return `double`. Consider adding an additional type-check to rule them out. Loading history...
42			}
43
44			/**
45			* @return float
46			*/
47			public function getBidQuantity(): float
48			{
49			return $this->bidQuantity;
			0 ignored issues – show Bug Best Practice introduced 2024-08-29 22:20 UTC by Report Bug Copy Issue Report The expression `return $this->bidQuantity` could return the type `null` which is incompatible with the type-hinted return `double`. Consider adding an additional type-check to rule them out. Loading history...
50			}
51
52			/**
53			* @return float
54			*/
55			public function getBestAskPrice(): float
56			{
57			return $this->bestAskPrice;
			0 ignored issues – show Bug Best Practice introduced 2024-08-29 22:20 UTC by Report Bug Copy Issue Report The expression `return $this->bestAskPrice` could return the type `null` which is incompatible with the type-hinted return `double`. Consider adding an additional type-check to rule them out. Loading history...
58			}
59
60			/**
61			* @return float
62			*/
63			public function getAskQuantity(): float
64			{
65			return $this->askQuantity;
			0 ignored issues – show Bug Best Practice introduced 2024-08-29 22:20 UTC by Report Bug Copy Issue Report The expression `return $this->askQuantity` could return the type `null` which is incompatible with the type-hinted return `double`. Consider adding an additional type-check to rule them out. Loading history...
66			}
67
68			/**
69			* @return string
70			*/
71			public function getSymbol(): string
72			{
73			return $this->symbol;
74			}
75			}
76

carpenstar / bybitapi-sdk-websockets

Pull Request — master (#10)

BoocktickerResponseItem::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like