Carpenstar\ByBitAPI\WebSockets\Channels\Spot\PublicChannels\Tickers\Entities\TickersAbstract

Complexity

Total Complexity

10

Size/Duplication

Total Lines	84
Duplicated Lines	0 %

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	setTopic()	0	4	1
A	setData()	0	6	2
A	setType()	0	4	1
A	setTimestamp()	0	4	1
A	getTopic()	0	3	1
A	getType()	0	3	1
A	getTimestamp()	0	3	1
A	__construct()	0	8	1
A	getData()	0	3	1

<?php
namespace Carpenstar\ByBitAPI\WebSockets\Channels\Spot\PublicChannels\Tickers\Entities;

use Carpenstar\ByBitAPI\Core\Builders\ResponseBuilder;
use Carpenstar\ByBitAPI\Core\Helpers\DateTimeHelper;
use Carpenstar\ByBitAPI\Core\Interfaces\ICollectionInterface;
use Carpenstar\ByBitAPI\Core\Objects\Collection\EntityCollection;
use Carpenstar\ByBitAPI\Core\Objects\AbstractResponse;

/**
 * https://bybit-exchange.github.io/docs/derivatives/ws-public/ticker
 * Get latest information of the symbol
 * Future has snapshot and delta types. If a key does not exist in the field, it means the value is not changed.
 * Option has snapshot data only.
 *
 * Topic: tickers.{symbol}
 *
 * Push frequency: 100ms
 */
class TickersAbstract extends AbstractResponse
{
    private ?string $topic;

    private ?string $type;

    private \DateTime $timestamp;

    private ?ICollectionInterface $data;

    public function __construct(array $data)
    {
        $this->data = new EntityCollection();
        $this
            ->setTopic($data['topic'])
            ->setType($data['type'])
            ->setData($data['data'])
            ->setTimestamp($data['ts']);
    }

    /**
     * @param string|null $topic
     * @return self
     */
    private function setTopic(?string $topic): self
    {
        $this->topic = $topic;
        return $this;
    }

    /**
     * @return string
     */
    public function getTopic(): ?string
    {
        return $this->topic;
    }

    /**
     * @param string|null $type
     * @return self
     */
    private function setType(?string $type): self
    {
        $this->type = $type;
        return $this;
    }
    /**
     * @return string
     */
    public function getType(): ?string
    {
        return $this->type;
    }

    /**
     * @param string $timestamp
     * @return self
     */
    private function setTimestamp(string $timestamp): self
    {
        $this->timestamp = DateTimeHelper::makeFromTimestamp($timestamp);

$timestamp of type string is incompatible with the type integer expected by parameter $timestamp of Carpenstar\ByBitAPI\Core\Helpers\DateTimeHelper::makeFromTimestamp().

        return $this;
    }

    /**
     * @return \DateTime
     */
    public function getTimestamp(): \DateTime
    {
        return $this->timestamp;
    }

    private function setData(array $data): self
    {
        if (!empty($data)) {
            $this->data->push(ResponseBuilder::make(TickersItemAbstract::class, $data));

The method push() does not exist on null.

The call to Carpenstar\ByBitAPI\Core\Interfaces\ICollectionInterface::push() has too many arguments starting with Carpenstar\ByBitAPI\Core\Builders\ResponseBuilder::make(Carpenstar\ByBitAPI\WebSockets\Channels\Spot\PublicChannels\Tickers\Entities\TickersItemAbstract::class, $data).

        }
        return $this;
    }

    public function getData(): ICollectionInterface
    {
        return $this->data;

The expression return $this->data could return the type null which is incompatible with the type-hinted return Carpenstar\ByBitAPI\Core\Interfaces\ICollectionInterface. Consider adding an additional type-check to rule them out.

    }
}