Carpenstar\ByBitAPI\WebSockets\Objects\WebSockets\WebSocketArgument

Complexity

Total Complexity

5

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getReqId()	0	3	1
A	getSymbols()	0	3	1
A	setReqId()	0	4	1
A	setSymbols()	0	4	1
A	__construct()	0	5	1

<?php
namespace Carpenstar\ByBitAPI\WebSockets\Objects\WebSockets;

use Carpenstar\ByBitAPI\WebSockets\Interfaces\IWebSocketArgumentInterface;

abstract class WebSocketArgument implements IWebSocketArgumentInterface
{
    protected ?string $reqId;

    protected array $symbols;

    public function __construct(string $symbol, ?string $reqId = null)
    {
        $this
            ->setSymbols($symbol)
            ->setReqId($reqId);
    }

    abstract public function getOperation(): string;

    /**
     * @param string|null $reqId
     * @return self
     */
    protected function setReqId(?string $reqId): self
    {
        $this->reqId = $reqId;
        return $this;
    }

    /**
     * @return string
     */
    public function getReqId(): string
    {
        return $this->reqId;

The expression return $this->reqId could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }

    /**
     * @param string $symbol
     * @return self
     */
    protected function setSymbols(string $symbol): self
    {
        $this->symbols = explode(',', $symbol);
        return $this;
    }

    /**
     * @return string
     */
    public function getSymbols(): array
    {
        return $this->symbols;

The expression return $this->symbols returns the type array which is incompatible with the documented return type string.

    }
}