OrderBookPriceItemResponse::getPrice() - Code Metrics - Inspection of "Version v.3.0.0" - carpenstar/bybitapi-sdk-spot - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#3)

by Vladislav

created 2023-07-22 19:59 UTC

OrderBookPriceItemResponse::getPrice() A

↳ Parent: OrderBookPriceItemResponse

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	1
dl	0
loc	3
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php
namespace Carpenstar\ByBitAPI\Spot\MarketData\OrderBook\Response;

use Carpenstar\ByBitAPI\Core\Objects\ResponseEntity;
use Carpenstar\ByBitAPI\Spot\MarketData\OrderBook\Interfaces\IOrderBookPriceResponse;

class OrderBookPriceItemResponse extends ResponseEntity implements IOrderBookPriceResponse
{
    /**
     * Price position value
     * @var float
     */
    private float $price;

    /**
     * Quantity position value
     * @var float
     */
    private float $quantity;


    /**
     * @param array $data
     */
    public function __construct(array $data)
    {
        $this
            ->setPrice($data[0])
            ->setQuantity($data[1]);
    }

    /**
     * @param float $price
     * @return $this
     */
    private function setPrice(float $price): self
    {
        $this->price = $price;
        return $this;
    }

    /**
     * @return float
     */
    public function getPrice(): float
    {
        return $this->price;
    }

    /**
     * @param float $quantity
     * @return MergedOrderBookResponseItem
filter:
    dependency_paths: ["lib/*"]
     */
    private function setQuantity(float $quantity): self
    {
        $this->quantity = $quantity;
        return $this;

    }

    /**
     * @return float
     */
    public function getQuantity(): float
    {
        return $this->quantity;
    }
}

1			<?php
2			namespace Carpenstar\ByBitAPI\Spot\MarketData\OrderBook\Response;
3
4			use Carpenstar\ByBitAPI\Core\Objects\ResponseEntity;
5			use Carpenstar\ByBitAPI\Spot\MarketData\OrderBook\Interfaces\IOrderBookPriceResponse;
6
7			class OrderBookPriceItemResponse extends ResponseEntity implements IOrderBookPriceResponse
8			{
9			/**
10			* Price position value
11			* @var float
12			*/
13			private float $price;
14
15			/**
16			* Quantity position value
17			* @var float
18			*/
19			private float $quantity;
20
21
22			/**
23			* @param array $data
24			*/
25			public function __construct(array $data)
26			{
27			$this
28			->setPrice($data[0])
29			->setQuantity($data[1]);
30			}
31
32			/**
33			* @param float $price
34			* @return $this
35			*/
36			private function setPrice(float $price): self
37			{
38			$this->price = $price;
39			return $this;
40			}
41
42			/**
43			* @return float
44			*/
45			public function getPrice(): float
46			{
47			return $this->price;
48			}
49
50			/**
51			* @param float $quantity
52			* @return MergedOrderBookResponseItem
			0 ignored issues – show Bug introduced 2023-07-22 20:02 UTC by Report Bug Copy Issue Report The type `Carpenstar\ByBitAPI\Spot...edOrderBookResponseItem` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
53			*/
54			private function setQuantity(float $quantity): self
55			{
56			$this->quantity = $quantity;
57			return $this;
			0 ignored issues – show Bug Best Practice introduced 2023-07-22 20:02 UTC by Report Bug Copy Issue Report The expression `return $this` returns the type `Carpenstar\ByBitAPI\Spot...erBookPriceItemResponse` which is incompatible with the documented return type `Carpenstar\ByBitAPI\Spot...edOrderBookResponseItem`. Loading history...
58			}
59
60			/**
61			* @return float
62			*/
63			public function getQuantity(): float
64			{
65			return $this->quantity;
66			}
67			}

carpenstar / bybitapi-sdk-spot

Pull Request — master (#3)

OrderBookPriceItemResponse::getPrice() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like