Carpenstar\ByBitAPI\Spot\MarketData\PublicTradingRecords\Response\PublicTradingRecordsResponseItem

Complexity

Total Complexity

11

Size/Duplication

Total Lines	133
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	setIsBuyerMaker()	0	4	1
A	setPrice()	0	4	1
A	getPrice()	0	3	1
A	getIsBuyerMaker()	0	3	1
A	setTime()	0	4	1
A	setType()	0	4	1
A	setQty()	0	4	1
A	getTime()	0	3	1
A	getType()	0	3	1
A	getQuantity()	0	3	1

<?php

namespace Carpenstar\ByBitAPI\Spot\MarketData\PublicTradingRecords\Response;

use Carpenstar\ByBitAPI\Core\Helpers\DateTimeHelper;
use Carpenstar\ByBitAPI\Core\Objects\AbstractResponse;
use Carpenstar\ByBitAPI\Spot\MarketData\PublicTradingRecords\Interfaces\IPublicTradingRecordsResponseItemInterface;

class PublicTradingRecordsResponseItem extends AbstractResponse implements IPublicTradingRecordsResponseItemInterface
{
    /**
     * Order price
     * @var null|float $price
     */
    private ?float $price;

    /**
     * Current timestamp
     * @var \DateTime $time
     */
    private \DateTime $time;

    /**
     * Order quantity
     * @var float $quantity
     */
    private float $qty;

    /**
     * 0：Sell or taker order, 1：Buy maker order
     * @var bool $isBuyerMaker
     */
    private bool $isBuyerMaker;

    /**
     * 0：normal trade, 1：Paradigm block trade
     * @var int $type
     */
    private int $type;

    /**
     * @param array $data
     */
    public function __construct(array $data)
    {
        $this
            ->setPrice($data['price'])
            ->setQty($data['qty'])
            ->setTime($data['time'])
            ->setIsBuyerMaker((bool)$data['isBuyerMaker'])
            ->setType($data['type']);
    }

    /**
     * @param string $type
     * @return self
     */
    private function setType(string $type): self
    {
        $this->type = $type;

The property $type was declared of type integer, but $type is of type string. Maybe add a type cast?

        return $this;
    }

    /**
     * @return int
     */
    public function getType(): int
    {
        return $this->type;
    }

    /**
     * @param float|null $price
     * @return PublicTradingRecordsResponseItem
     */
    private function setPrice(?float $price = null): self
    {
        $this->price = $price;
        return $this;
    }

    /**
     * @return float
     */
    public function getPrice(): float
    {
        return $this->price;

The expression return $this->price could return the type null which is incompatible with the type-hinted return double. Consider adding an additional type-check to rule them out.

    }

    /**
     * @param float $quantity
     * @return PublicTradingRecordsResponseItem
     */
    private function setQty(?float $quantity = null): self
    {
        $this->qty = $quantity;
        return $this;
    }

    /**
     * @return float
     */
    public function getQuantity(): float
    {
        return $this->qty;
    }

    /**
     * @param int $time
     * @return PublicTradingRecordsResponseItem
     */
    private function setTime(int $time): self
    {
        $this->time = DateTimeHelper::makeFromTimestamp($time);
        return $this;
    }

    /**
     * @return \DateTime
     */
    public function getTime(): \DateTime
    {
        return $this->time;
    }

    /**
     * @param bool $isBuyerMaker
     * @return PublicTradingRecordsResponseItem
     */
    private function setIsBuyerMaker(bool $isBuyerMaker): self
    {
        $this->isBuyerMaker = $isBuyerMaker;
        return $this;
    }

    /**
     * @return bool
     */
    public function getIsBuyerMaker(): bool
    {
        return $this->isBuyerMaker;
    }
}