WalletBalanceResponse::setCumRealisedPnl() - Code Metrics - Inspection of "Update for compatibility with bybitapi-sdk-core v...." - carpenstar/bybitapi-sdk-derivatives - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#20)

by Vladislav

created 2024-06-23 21:39 UTC

WalletBalanceResponse::setCumRealisedPnl() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	2
nc	1
nop	1
dl	0
loc	4
rs	10
c	1
b	0
f	0

<?php
namespace Carpenstar\ByBitAPI\Derivatives\Contract\Account\WalletBalance\Response;

use Carpenstar\ByBitAPI\Core\Builders\ResponseDtoBuilder;
use Carpenstar\ByBitAPI\Core\Objects\AbstractResponse;
use Carpenstar\ByBitAPI\Core\Objects\Collection\EntityCollection;
use Carpenstar\ByBitAPI\Derivatives\Contract\Account\WalletBalance\Interfaces\IWalletBalanceResponseInterface;
use Carpenstar\ByBitAPI\Derivatives\Contract\Account\WalletBalance\Interfaces\IWalletBalanceResponseItemInterface;

class WalletBalanceResponse extends AbstractResponse implements IWalletBalanceResponseInterface
{
    /**
     * @var IWalletBalanceResponseItemInterface[]
     */
    private EntityCollection $list;

    public function __construct(array $data)
    {
        $list = new EntityCollection();

        if (!empty($data['list'])) {
            array_map(function ($item) use ($list) {
                $list->push(ResponseDtoBuilder::make(WalletBalanceResponseItem::class, $item));
            }, $data['list']);
        }

        $this->list = $list;

    }

    /**
     * @return IWalletBalanceResponseItemInterface[]
     */
    public function getBalances(): array
    {
        return $this->list->all();
    }
}

1			<?php
2			namespace Carpenstar\ByBitAPI\Derivatives\Contract\Account\WalletBalance\Response;
3
4			use Carpenstar\ByBitAPI\Core\Builders\ResponseDtoBuilder;
5			use Carpenstar\ByBitAPI\Core\Objects\AbstractResponse;
6			use Carpenstar\ByBitAPI\Core\Objects\Collection\EntityCollection;
7			use Carpenstar\ByBitAPI\Derivatives\Contract\Account\WalletBalance\Interfaces\IWalletBalanceResponseInterface;
8			use Carpenstar\ByBitAPI\Derivatives\Contract\Account\WalletBalance\Interfaces\IWalletBalanceResponseItemInterface;
9
10			class WalletBalanceResponse extends AbstractResponse implements IWalletBalanceResponseInterface
11			{
12			/**
13			* @var IWalletBalanceResponseItemInterface[]
14			*/
15			private EntityCollection $list;
16
17			public function __construct(array $data)
18			{
19			$list = new EntityCollection();
20
21			if (!empty($data['list'])) {
22			array_map(function ($item) use ($list) {
23			$list->push(ResponseDtoBuilder::make(WalletBalanceResponseItem::class, $item));
24			}, $data['list']);
25			}
26
27			$this->list = $list;
			0 ignored issues – show Documentation Bug introduced 2024-06-17 21:10 UTC by Report Bug Copy Issue Report It seems like `$list` of type `Carpenstar\ByBitAPI\Core...ection\EntityCollection` is incompatible with the declared type `Carpenstar\ByBitAPI\Deri...ResponseItemInterface[]` of property `$list`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
28			}
29
30			/**
31			* @return IWalletBalanceResponseItemInterface[]
32			*/
33			public function getBalances(): array
34			{
35			return $this->list->all();
36			}
37			}

carpenstar / bybitapi-sdk-derivatives

Pull Request — master (#20)

WalletBalanceResponse::setCumRealisedPnl() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like