Conditions | 3 |
Paths | 2 |
Total Lines | 62 |
Code Lines | 48 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
14 | public function testSuccessEndpoint() |
||
15 | { |
||
16 | echo "\n //// --- //// \n"; |
||
17 | |||
18 | $bybitApi = (new BybitAPI())->setCredentials('https://api-testnet.bybit.com', 'fL02oi5qo8i2jDxlum', 'Ne1EE35XTprIWrId9vGEAc1ZYJTmodA4qFzZ'); |
||
19 | |||
20 | $response = $bybitApi->privateEndpoint(GetOpenOrders::class, (new GetOpenOrdersRequest())->setSymbol('BTCUSDT')->setLimit(2))->execute(); |
||
21 | |||
22 | if ($response->getReturnCode() == 0) { |
||
23 | |||
24 | echo "CODE: {$response->getReturnCode()} \n"; |
||
25 | echo "MESSAGE: {$response->getReturnMessage()} \n"; |
||
26 | |||
27 | /** @var GetOpenOrdersResponse $openOrderInfo */ |
||
28 | $openOrderInfo = $response->getResult(); |
||
29 | |||
30 | echo "Category: {$openOrderInfo->getCategory()}\n"; |
||
31 | echo "Next Page Cursor: {$openOrderInfo->getNextPageCursor()}\n"; |
||
32 | echo "List:\n"; |
||
33 | /** @var GetOpenOrdersResponseItem $order */ |
||
34 | foreach ($openOrderInfo->getOpenOrders() as $order) { |
||
35 | echo " -----\n"; |
||
36 | echo " Symbol: {$order->getSymbol()}\n"; |
||
37 | echo " Order ID: {$order->getOrderId()}\n"; |
||
38 | echo " Order Link ID {$order->getOrderLinkId()}\n"; |
||
39 | echo " Order Side: {$order->getSide()}\n"; |
||
40 | echo " Order Type {$order->getOrderType()}\n"; |
||
41 | echo " Order Price: {$order->getPrice()}\n"; |
||
42 | echo " Order Quantity: {$order->getQty()}\n"; |
||
43 | echo " Time in force: {$order->getTimeInForce()}\n"; |
||
44 | echo " Order Status: {$order->getOrderStatus()}\n"; |
||
45 | echo " Last Price On Created: {$order->getLastPriceOnCreated()}\n"; |
||
46 | echo " Create Time: {$order->getCreatedTime()->format('Y-m-d H:i:s')}\n"; |
||
47 | echo " Update Time {$order->getUpdatedTime()->format('Y-m-d H:i:s')}\n"; |
||
48 | echo " Cancel Type: {$order->getCancelType()}\n"; |
||
49 | echo " Stop Order Type: {$order->getStopOrderType()}\n"; |
||
50 | echo " Trigger Direction: {$order->getTriggerDirection()}\n"; |
||
51 | echo " Trigger By {$order->getTriggerBy()}\n"; |
||
52 | echo " Trigger Price: {$order->getTriggerPrice()}\n"; |
||
53 | echo " Cumulative Execution Value: {$order->getCumExecValue()}\n"; |
||
54 | echo " Cumulative Execution Fee: {$order->getCumExecFee()}\n"; |
||
55 | echo " Cumulative Execution Quantity: {$order->getCumExecQty()}\n"; |
||
56 | echo " Leaves Value: {$order->getLeavesValue()}\n"; |
||
57 | echo " Leaves Quantity: {$order->getLeavesQty()}\n"; |
||
58 | echo " Take Profit Price: {$order->getTakeProfit()}\n"; |
||
59 | echo " Stop Loss Price: {$order->getStopLoss()} {}\n"; |
||
60 | echo " TP/SL Mode: {$order->getTpslMode()}\n"; |
||
61 | echo " Take Profit Limit Price: {$order->getTpLimitPrice()}\n"; |
||
62 | echo " Stop Loss Limit Price: {$order->getSlLimitPrice()}\n"; |
||
63 | echo " Take Profit Trigger By: {$order->getTpTriggerBy()}\n"; |
||
64 | echo " Stop Loss Trigger By: {$order->getSlTriggerBy()}\n"; |
||
65 | echo " Reduce Only: {$order->isReduceOnly()}\n"; |
||
66 | } |
||
67 | } else { |
||
68 | echo "API ERORR: " . get_class($this) . "\n"; |
||
69 | echo "CODE: {$response->getReturnCode()} \n"; |
||
70 | echo "MESSAGE: {$response->getReturnMessage()} \n"; |
||
71 | echo "EXTENDED:" . implode(";\n", $response->getExtendedInfo()) . "\n"; |
||
72 | } |
||
73 | |||
74 | |||
75 | $this->assertTrue(true); |
||
76 | } |
||
78 |