GetTradingFeeRateResponse::__construct() - Code Metrics - Inspection of "Update for compatibility with bybitapi-sdk-core v...." - carpenstar/bybitapi-sdk-derivatives - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#20)

by Vladislav

created 2024-06-17 21:08 UTC

GetTradingFeeRateResponse::__construct() A

↳ Parent: GetTradingFeeRateResponse

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	6
c	1
b	0
f	0
nc	2
nop	1
dl	0
loc	11
rs	10

<?php

namespace Carpenstar\ByBitAPI\Derivatives\Contract\Account\GetTradingFeeRate\Response;

use Carpenstar\ByBitAPI\Core\Builders\ResponseDtoBuilder;
use Carpenstar\ByBitAPI\Core\Objects\AbstractResponse;
use Carpenstar\ByBitAPI\Core\Objects\Collection\EntityCollection;
use Carpenstar\ByBitAPI\Derivatives\Contract\Account\GetTradingFeeRate\Interfaces\IGetTradingFeeRateResponseInterface;
use Carpenstar\ByBitAPI\Derivatives\Contract\Account\GetTradingFeeRate\Interfaces\IGetTradingFeeRateResponseItemInterface;

class GetTradingFeeRateResponse extends AbstractResponse implements IGetTradingFeeRateResponseInterface
{
    /**
     * @var IGetTradingFeeRateResponseItemInterface[]
     */
    private EntityCollection $list;

    public function __construct(array $data)
    {
        $list = new EntityCollection();

        if (!empty($data['list'])) {
            array_map(function ($item) use ($list) {
                $list->push(ResponseDtoBuilder::make(GetTradingFeeRateResponseItem::class, $item));
            }, $data['list']);
        }

        $this->list = $list;

    }

    /**
     * @return IGetTradingFeeRateResponseItemInterface[]
     */
    public function getFeeRates(): array
    {
        return $this->list->all();
    }
}

1			<?php
2
3			namespace Carpenstar\ByBitAPI\Derivatives\Contract\Account\GetTradingFeeRate\Response;
4
5			use Carpenstar\ByBitAPI\Core\Builders\ResponseDtoBuilder;
6			use Carpenstar\ByBitAPI\Core\Objects\AbstractResponse;
7			use Carpenstar\ByBitAPI\Core\Objects\Collection\EntityCollection;
8			use Carpenstar\ByBitAPI\Derivatives\Contract\Account\GetTradingFeeRate\Interfaces\IGetTradingFeeRateResponseInterface;
9			use Carpenstar\ByBitAPI\Derivatives\Contract\Account\GetTradingFeeRate\Interfaces\IGetTradingFeeRateResponseItemInterface;
10
11			class GetTradingFeeRateResponse extends AbstractResponse implements IGetTradingFeeRateResponseInterface
12			{
13			/**
14			* @var IGetTradingFeeRateResponseItemInterface[]
15			*/
16			private EntityCollection $list;
17
18			public function __construct(array $data)
19			{
20			$list = new EntityCollection();
21
22			if (!empty($data['list'])) {
23			array_map(function ($item) use ($list) {
24			$list->push(ResponseDtoBuilder::make(GetTradingFeeRateResponseItem::class, $item));
25			}, $data['list']);
26			}
27
28			$this->list = $list;
			0 ignored issues – show Documentation Bug introduced 2024-06-16 20:32 UTC by Report Bug Copy Issue Report It seems like `$list` of type `Carpenstar\ByBitAPI\Core...ection\EntityCollection` is incompatible with the declared type `Carpenstar\ByBitAPI\Deri...ResponseItemInterface[]` of property `$list`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
29			}
30
31			/**
32			* @return IGetTradingFeeRateResponseItemInterface[]
33			*/
34			public function getFeeRates(): array
35			{
36			return $this->list->all();
37			}
38			}

carpenstar / bybitapi-sdk-derivatives

Pull Request — master (#20)

GetTradingFeeRateResponse::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like