PublicTradingHistoryResponse::getSide() - Code Metrics - Inspection of "Merge pull request #20 from carpenstar/v.3.1.0" - carpenstar/bybitapi-sdk-derivatives - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( f1d563...1fab6c )

by Vladislav

created 2024-07-15 16:03 UTC

PublicTradingHistoryResponse::getSide() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php
namespace Carpenstar\ByBitAPI\Derivatives\MarketData\PublicTradingHistory\Response;

use Carpenstar\ByBitAPI\Core\Builders\ResponseDtoBuilder;
use Carpenstar\ByBitAPI\Core\Objects\AbstractResponse;
use Carpenstar\ByBitAPI\Core\Objects\Collection\EntityCollection;
use Carpenstar\ByBitAPI\Derivatives\MarketData\PublicTradingHistory\Interfaces\IPublicTradingHistoryResponseInterface;
use Carpenstar\ByBitAPI\Derivatives\MarketData\PublicTradingHistory\Interfaces\IPublicTradingHistoryResponseItemInterface;

class PublicTradingHistoryResponse extends AbstractResponse implements IPublicTradingHistoryResponseInterface
{
    /** @var IPublicTradingHistoryResponseItemInterface[] */
    private EntityCollection $list;

    public function __construct(array $data)
    {
        $list = new EntityCollection();

        if (!empty($data['list'])) {
            array_map(function ($item) use ($list) {
                $list->push(ResponseDtoBuilder::make(PublicTradingHistoryResponseItem::class, $item));
            }, $data['list']);
        }

        $this->list = $list;

    }

    public function getTradingList(): array
    {
        return $this->list->all();
    }
}

1			<?php
2			namespace Carpenstar\ByBitAPI\Derivatives\MarketData\PublicTradingHistory\Response;
3
4			use Carpenstar\ByBitAPI\Core\Builders\ResponseDtoBuilder;
5			use Carpenstar\ByBitAPI\Core\Objects\AbstractResponse;
6			use Carpenstar\ByBitAPI\Core\Objects\Collection\EntityCollection;
7			use Carpenstar\ByBitAPI\Derivatives\MarketData\PublicTradingHistory\Interfaces\IPublicTradingHistoryResponseInterface;
8			use Carpenstar\ByBitAPI\Derivatives\MarketData\PublicTradingHistory\Interfaces\IPublicTradingHistoryResponseItemInterface;
9
10			class PublicTradingHistoryResponse extends AbstractResponse implements IPublicTradingHistoryResponseInterface
11			{
12			/** @var IPublicTradingHistoryResponseItemInterface[] */
13			private EntityCollection $list;
14
15			public function __construct(array $data)
16			{
17			$list = new EntityCollection();
18
19			if (!empty($data['list'])) {
20			array_map(function ($item) use ($list) {
21			$list->push(ResponseDtoBuilder::make(PublicTradingHistoryResponseItem::class, $item));
22			}, $data['list']);
23			}
24
25			$this->list = $list;
			0 ignored issues – show Documentation Bug introduced 2024-07-14 18:46 UTC by Report Bug Copy Issue Report It seems like `$list` of type `Carpenstar\ByBitAPI\Core...ection\EntityCollection` is incompatible with the declared type `Carpenstar\ByBitAPI\Deri...ResponseItemInterface[]` of property `$list`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
26			}
27
28			public function getTradingList(): array
29			{
30			return $this->list->all();
31			}
32			}

carpenstar / bybitapi-sdk-derivatives

Push — master ( f1d563...1fab6c )

PublicTradingHistoryResponse::getSide() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like