GetOpenOrdersResponse::getOrderId() - Code Metrics - Inspection of "Update for compatibility with bybitapi-sdk-core v...." - carpenstar/bybitapi-sdk-derivatives - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#20)

by Vladislav

created 2024-06-20 22:34 UTC

GetOpenOrdersResponse::getOrderId() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	1
eloc	1
c	2
b	0
f	0
nc	1
nop	0
dl	0
loc	3
rs	10

<?php
namespace Carpenstar\ByBitAPI\Derivatives\Contract\Order\GetOpenOrders\Response;


use Carpenstar\ByBitAPI\Core\Builders\ResponseDtoBuilder;
use Carpenstar\ByBitAPI\Core\Objects\AbstractResponse;
use Carpenstar\ByBitAPI\Core\Objects\Collection\EntityCollection;
use Carpenstar\ByBitAPI\Derivatives\Contract\Account\GetTradingFeeRate\Interfaces\IGetTradingFeeRateResponseItemInterface;
use Carpenstar\ByBitAPI\Derivatives\Contract\Order\GetOpenOrders\Interfaces\IGetOpenOrdersResponseInterface;
use Carpenstar\ByBitAPI\Derivatives\Contract\Order\GetOpenOrders\Interfaces\IGetOpenOrdersResponseItemInterface;

class GetOpenOrdersResponse extends AbstractResponse implements IGetOpenOrdersResponseInterface
{
    /**
     * @var string
     */
    private string $category;

    /**
     * @var string
     */
    private string $nextPageCursor;

    /**
     * @var IGetTradingFeeRateResponseItemInterface[]
     */
    private EntityCollection $list;

    public function __construct(array $data)
    {
        $this->category = $data['category'];
        $this->nextPageCursor = $data['nextPageCursor'];

        $list = new EntityCollection();

        if (!empty($data['list'])) {
            array_map(function ($item) use ($list) {
                $list->push(ResponseDtoBuilder::make(GetOpenOrdersResponseItem::class, $item));
            }, $data['list']);
        }

        $this->list = $list;

    }

    /**
     * @return IGetOpenOrdersResponseItemInterface[]
     */
    public function getOpenOrders(): array
    {
        return $this->list->all();
    }

    public function getNextPageCursor(): string
    {
        return $this->nextPageCursor;
    }

    public function getCategory(): string
    {
        return $this->category;
    }
}


1			<?php
2			namespace Carpenstar\ByBitAPI\Derivatives\Contract\Order\GetOpenOrders\Response;
3
4
5			use Carpenstar\ByBitAPI\Core\Builders\ResponseDtoBuilder;
6			use Carpenstar\ByBitAPI\Core\Objects\AbstractResponse;
7			use Carpenstar\ByBitAPI\Core\Objects\Collection\EntityCollection;
8			use Carpenstar\ByBitAPI\Derivatives\Contract\Account\GetTradingFeeRate\Interfaces\IGetTradingFeeRateResponseItemInterface;
9			use Carpenstar\ByBitAPI\Derivatives\Contract\Order\GetOpenOrders\Interfaces\IGetOpenOrdersResponseInterface;
10			use Carpenstar\ByBitAPI\Derivatives\Contract\Order\GetOpenOrders\Interfaces\IGetOpenOrdersResponseItemInterface;
11
12			class GetOpenOrdersResponse extends AbstractResponse implements IGetOpenOrdersResponseInterface
13			{
14			/**
15			* @var string
16			*/
17			private string $category;
18
19			/**
20			* @var string
21			*/
22			private string $nextPageCursor;
23
24			/**
25			* @var IGetTradingFeeRateResponseItemInterface[]
26			*/
27			private EntityCollection $list;
28
29			public function __construct(array $data)
30			{
31			$this->category = $data['category'];
32			$this->nextPageCursor = $data['nextPageCursor'];
33
34			$list = new EntityCollection();
35
36			if (!empty($data['list'])) {
37			array_map(function ($item) use ($list) {
38			$list->push(ResponseDtoBuilder::make(GetOpenOrdersResponseItem::class, $item));
39			}, $data['list']);
40			}
41
42			$this->list = $list;
			0 ignored issues – show Documentation Bug introduced 2024-06-20 21:41 UTC by Report Bug Copy Issue Report It seems like `$list` of type `Carpenstar\ByBitAPI\Core...ection\EntityCollection` is incompatible with the declared type `Carpenstar\ByBitAPI\Deri...ResponseItemInterface[]` of property `$list`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
43			}
44
45			/**
46			* @return IGetOpenOrdersResponseItemInterface[]
47			*/
48			public function getOpenOrders(): array
49			{
50			return $this->list->all();
51			}
52
53			public function getNextPageCursor(): string
54			{
55			return $this->nextPageCursor;
56			}
57
58			public function getCategory(): string
59			{
60			return $this->category;
61			}
62			}
63

carpenstar / bybitapi-sdk-derivatives

Pull Request — master (#20)

GetOpenOrdersResponse::getOrderId() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like