Carpenstar\ByBitAPI\Core\Objects\WebSockets\WebSocketArgument

Complexity

Total Complexity

3

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getReqId()	0	3	1
A	getSymbols()	0	3	1
A	__construct()	0	4	1

<?php

namespace Carpenstar\ByBitAPI\Core\Objects\WebSockets;

use Carpenstar\ByBitAPI\Core\Interfaces\IWebSocketArgumentInterface;

abstract class WebSocketArgument implements IWebSocketArgumentInterface
{
    protected ?string $reqId;

    protected string $symbols;

    public function __construct(string $symbol, ?string $reqId = null)
    {
        $this->symbols = $symbol;
        $this->reqId = $reqId;
    }

    /**
     * @return string
     */
    public function getReqId(): string
    {
        return $this->reqId;

The expression return $this->reqId could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }

    /**
     * @return string
     */
    public function getSymbols(): string
    {
        return $this->symbols;
    }
}