carono\yii2file\behaviors\PivotFileSaveBehavior

Complexity

Total Complexity

20

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	canSetProperty()	0	3	1
A	getModelClass()	0	3	1
B	setPivots()	0	23	9
A	__set()	0	6	2
A	savePivots()	0	9	5
A	getStoredPivots()	0	7	2

<?php


namespace carono\yii2file\behaviors;


use carono\yii2file\FileUploadTrait;
use carono\yii2migrate\traits\PivotTrait;
use Closure;
use yii\db\ActiveRecord;
use yii\web\UploadedFile;

/**
 * Class PivotFileSaveBehavior
 *
 * @package backend\behaviors
 * @property PivotTrait|ActiveRecord $owner
 */
class PivotFileSaveBehavior extends \yii\base\Behavior
{
    protected $_pivots;
    public $attribute;
    public $pivotClass;
    public $fileProcess;
    public $fileClass;
    public $pivotAttributes;

    public function canSetProperty($name, $checkVars = true)
    {
        return $name === $this->attribute;
    }

    public function __set($name, $value)
    {
        if ($this->canSetProperty($name)) {
            $this->setPivots($value);
        } else {
            parent::__set($name, $value);
        }
    }

    public function getStoredPivots($attribute)
    {
        if ($attribute === $this->attribute) {
            return $this->_pivots;
        }

        return null;
    }

    /**
     * @return ActiveRecord|FileUploadTrait
     */
    protected function getModelClass()
    {
        return $this->fileClass;
    }

    protected function setPivots($values)
    {
        if (empty(array_filter((array)$values))) {
            $values = UploadedFile::getInstances($this->owner, $this->attribute);

It seems like $this->owner can also be of type carono\yii2migrate\traits\PivotTrait; however, parameter $model of yii\web\UploadedFile::getInstances() does only seem to accept yii\base\Model, maybe add an additional type check?

        }
        $class = $this->getModelClass();
        $this->_pivots = [];
        foreach ((array)$values as $value) {
            if (is_numeric($value)) {
                $this->_pivots[] = $class::findOne($value);
            } elseif ($this->fileProcess instanceof \Closure) {
                $value = call_user_func_array($this->fileProcess, [$value, $class]);
                if (is_array($value)) {
                    $this->_pivots = array_merge($this->_pivots, $value);
                } else {
                    $this->_pivots[] = $value;
                }
            } elseif ($value instanceof UploadedFile || is_string($value)) {
                $this->_pivots[] = $class::startUpload($value)->process();

The method startUpload() does not exist on yii\db\ActiveRecord. Are you sure you never get this type here, but always one of the subclasses?

            }
        }
        $eventName = $this->owner->isNewRecord ? ActiveRecord::EVENT_AFTER_INSERT : ActiveRecord::EVENT_AFTER_UPDATE;
        $this->owner->on($eventName, [$this, 'savePivots']);

It seems like on() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function savePivots()
    {
        foreach ((array)$this->_pivots as $index => $pv) {
            if ($this->pivotAttributes instanceof Closure) {
                $attributes = call_user_func_array($this->pivotAttributes, [$pv, $index]);
            } else {
                $attributes = $this->pivotAttributes ?: [];
            }
            $this->owner->addPivot($pv, $this->pivotClass, $attributes ?: []);
        }
    }
}