carono\yii2crud\actions\UpdateAction::run()

Complexity

Conditions	6
Paths	5

Size

Total Lines	24
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	1	Features	0

<?php
    public function run()
    {
        $model = $this->findModel($this->modelClass ?: $this->controller->updateClass);
        $this->controller->trigger(CrudController::EVENT_BEFORE_UPDATE_LOAD, new Event(['model' => $model]));
        if ($model->load(Yii::$app->request->post())) {

It seems like Yii::app->request->post() can also be of type object; however, parameter $data of yii\base\Model::load() does only seem to accept array, maybe add an additional type check?

            $this->controller->trigger(CrudController::EVENT_AFTER_UPDATE_LOAD, new Event(['model' => $model]));
            if ($model->save()) {
                $this->controller->trigger(CrudController::EVENT_AFTER_UPDATE, new Event(['model' => $model]));
                Yii::$app->session->setFlash('success', $this->getMessageOnUpdate($model));

The method setFlash() does not exist on null.

                if ($this->redirect instanceof \Closure) {
                    $url = call_user_func($this->redirect, $model);
                } else {
                    return $this->controller->refresh();
                }
                if (Yii::$app->request->isPjax) {
                    return Yii::$app->response->redirect($url, 302, false);
                }
                return $this->controller->redirect($url);
            } else {
                $this->controller->trigger(CrudController::EVENT_ERROR_UPDATE, new Event(['model' => $model]));
            }
            Yii::$app->session->setFlash('error', Html::errorSummary($model));
        }
        return $this->render($this->view, ['model' => $model]);
    }
}