Breadcrumbs::crumbArticleIndex() - Code Metrics - Inspection of "scrutinizer fix" - carono/yii2-1c-exchange - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( de9f16...6836c0 )

by Aleksandr

created 2018-02-06 11:35 UTC

Breadcrumbs::crumbArticleIndex() A

↳ Parent: Breadcrumbs

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php

namespace carono\exchange1c\components;

use carono\exchange1c\models\Article;
use yii\base\Action;
use yii\helpers\ArrayHelper;
use yii\helpers\Html;
use yii\helpers\Inflector;
use yii\helpers\Url;

class Breadcrumbs
{
    /**
     * @param Action $action
     * @param $params
     */
    public static function formCrumbs($action, $params)
    {
        $name = 'crumb' . Inflector::camelize($action->controller->id . '-' . $action->id);
        $class = get_called_class();
        if (method_exists($class, $name)) {
            $reflectionMethod = new \ReflectionMethod($class, $name);
            $data = [];
            foreach ($reflectionMethod->getParameters() as $p) {
                $data[] = isset($params[$p->getName()]) ? $params[$p->getName()] : null;
            }
            $action->controller->getView()->params['breadcrumbs'] = call_user_func_array([$class, "$name"], $data);
        }

        $name = 'button' . Inflector::camelize($action->controller->id . '-' . $action->id);
        $class = get_called_class();
        if (method_exists($class, $name)) {
            $reflectionMethod = new \ReflectionMethod($class, $name);
            $data = [];
            foreach ($reflectionMethod->getParameters() as $p) {
                $data[] = isset($params[$p->getName()]) ? $params[$p->getName()] : null;
            }
            foreach ($buttons = call_user_func_array([$class, "$name"], $data) as &$button) {
foreach ($array as &$itemValue) { }
                Html::addCssClass($button['options'], 'btn-xs');
                $button['options']['href'] = Url::to(ArrayHelper::remove($button, 'url'));
                $button['options']['tag'] = 'a';
            }
            $action->controller->getView()->params['buttons'] = $buttons;
        }
    }

    public static function buttonArticleIndex()
    {
        return [
            [
                'label' => 'Добавить статью',
                'url' => ['article/create'],
                'options' => ['class' => 'btn btn-primary', 'tag' => 'a']
            ]
        ];
    }

    /**
     * @param Article $article
     * @return array
     */
    public static function buttonArticleView($article)
    {
        return [
            [
                'label' => 'Редактировать',
                'url' => ['article/update', 'id' => $article->id],
                'options' => ['class' => 'btn btn-primary']
            ],
            [
                'label' => 'Добавить подстатью',
                'url' => ['article/create', 'parent' => $article->id],
                'options' => ['class' => 'btn btn-primary']
            ],
            [
                'label' => 'Удалить',
                'url' => ['article/delete', 'id' => $article->id],
                'options' => ['class' => 'btn btn-danger', 'data-confirm' => 'Удалить статью?']
            ]
        ];
    }

    #############################################################################

    public static function crumbTestingIndex()
    {
        return [
            'Тестирование модуля',
        ];
    }

    /**
     * @param Article $article
     * @return array
     */
    public static function crumbArticleView($article)
    {
        $items = [
            ['label' => 'Старт', 'url' => ['article/index']]
        ];
        $parent = $article;
        while ($parent = $parent->parent) {
            $items[] = ['label' => $parent->name, 'url' => ['article/view', 'id' => $parent->id]];
        }
        $items[] = $article->name;
        return $items;
    }

    public static function crumbArticleUpdate($article)
    {
        $items = [
            ['label' => 'Старт', 'url' => ['article/index']]
        ];
        $parent = $article;
        while ($parent = $parent->parent) {
            $items[] = ['label' => $parent->name, 'url' => ['article/view', 'id' => $parent->id]];
        }
        $items[] = ['label' => $article->name, 'url' => ['article/view', 'id' => $article->id]];
        $items [] = 'Редактирование';
        return $items;
    }


    public static function crumbInterfaceCheck($variable, $class, $interfaceTest)
    {
        return [
            ['label' => 'Интерфейсы', 'url' => ['default/interfaces']],
            $class,
        ];
    }

    public static function crumbDefaultInterfaces()
    {
        return [
            'Интерфейсы',
        ];
    }

    public static function crumbDefaultFiles()
    {
        return [
            'Временные файлы',
        ];
    }

    public static function crumbDefaultSettings()
    {
        return [
            'Настройки модуля',
        ];
    }

    public static function crumbDefaultDocumentation()
    {
        return [
            'Документация по CommerceML',
        ];
    }

    public static function crumbDefaultExport()
    {
        return [
            'Экспорт',
        ];
    }


    public static function crumbDefaultImport()
    {
        return [
            'Импорт',
        ];
    }

    public static function crumbArticleIndex()
    {
        return [
            'Старт',
        ];
    }
}

1			<?php
2
3			namespace carono\exchange1c\components;
4
5			use carono\exchange1c\models\Article;
6			use yii\base\Action;
7			use yii\helpers\ArrayHelper;
8			use yii\helpers\Html;
9			use yii\helpers\Inflector;
10			use yii\helpers\Url;
11
12			class Breadcrumbs
13			{
14			/**
15			* @param Action $action
16			* @param $params
17			*/
18			public static function formCrumbs($action, $params)
19			{
20			$name = 'crumb' . Inflector::camelize($action->controller->id . '-' . $action->id);
21			$class = get_called_class();
22			if (method_exists($class, $name)) {
23			$reflectionMethod = new \ReflectionMethod($class, $name);
24			$data = [];
25			foreach ($reflectionMethod->getParameters() as $p) {
26			$data[] = isset($params[$p->getName()]) ? $params[$p->getName()] : null;
27			}
28			$action->controller->getView()->params['breadcrumbs'] = call_user_func_array([$class, "$name"], $data);
29			}
30
31			$name = 'button' . Inflector::camelize($action->controller->id . '-' . $action->id);
32			$class = get_called_class();
33			if (method_exists($class, $name)) {
34			$reflectionMethod = new \ReflectionMethod($class, $name);
35			$data = [];
36			foreach ($reflectionMethod->getParameters() as $p) {
37			$data[] = isset($params[$p->getName()]) ? $params[$p->getName()] : null;
38			}
39			foreach ($buttons = call_user_func_array([$class, "$name"], $data) as &$button) {
			0 ignored issues – show Bug introduced 2018-02-06 11:38 UTC by Report Bug Copy Issue Report The expression `$buttons = call_user_fun..., EncapsedNode), $data)` cannot be used as a reference. Let?s assume that you have the following `foreach` statement: foreach ($array as &$itemValue) { } `$itemValue` is assigned by reference. This is possible because the expression (in the example `$array`) can be used as a reference target. However, if we were to replace `$array` with something different like the result of a function call as in foreach (getArray() as &$itemValue) { } then assigning by reference is not possible anymore as there is no target that could be modified. Available Fixes 1. Do not assign by reference foreach (getArray() as $itemValue) { } 2. Assign to a local variable first $array = getArray(); foreach ($array as &$itemValue) {} 3. Return a reference function &getArray() { $array = array(); return $array; } foreach (getArray() as &$itemValue) { } Loading history...
40			Html::addCssClass($button['options'], 'btn-xs');
41			$button['options']['href'] = Url::to(ArrayHelper::remove($button, 'url'));
42			$button['options']['tag'] = 'a';
43			}
44			$action->controller->getView()->params['buttons'] = $buttons;
45			}
46			}
47
48			public static function buttonArticleIndex()
49			{
50			return [
51			[
52			'label' => 'Добавить статью',
53			'url' => ['article/create'],
54			'options' => ['class' => 'btn btn-primary', 'tag' => 'a']
55			]
56			];
57			}
58
59			/**
60			* @param Article $article
61			* @return array
62			*/
63			public static function buttonArticleView($article)
64			{
65			return [
66			[
67			'label' => 'Редактировать',
68			'url' => ['article/update', 'id' => $article->id],
69			'options' => ['class' => 'btn btn-primary']
70			],
71			[
72			'label' => 'Добавить подстатью',
73			'url' => ['article/create', 'parent' => $article->id],
74			'options' => ['class' => 'btn btn-primary']
75			],
76			[
77			'label' => 'Удалить',
78			'url' => ['article/delete', 'id' => $article->id],
79			'options' => ['class' => 'btn btn-danger', 'data-confirm' => 'Удалить статью?']
80			]
81			];
82			}
83
84			#############################################################################
85
86			public static function crumbTestingIndex()
87			{
88			return [
89			'Тестирование модуля',
90			];
91			}
92
93			/**
94			* @param Article $article
95			* @return array
96			*/
97			public static function crumbArticleView($article)
98			{
99			$items = [
100			['label' => 'Старт', 'url' => ['article/index']]
101			];
102			$parent = $article;
103			while ($parent = $parent->parent) {
104			$items[] = ['label' => $parent->name, 'url' => ['article/view', 'id' => $parent->id]];
105			}
106			$items[] = $article->name;
107			return $items;
108			}
109
110			public static function crumbArticleUpdate($article)
111			{
112			$items = [
113			['label' => 'Старт', 'url' => ['article/index']]
114			];
115			$parent = $article;
116			while ($parent = $parent->parent) {
117			$items[] = ['label' => $parent->name, 'url' => ['article/view', 'id' => $parent->id]];
118			}
119			$items[] = ['label' => $article->name, 'url' => ['article/view', 'id' => $article->id]];
120			$items [] = 'Редактирование';
121			return $items;
122			}
123
124
125			public static function crumbInterfaceCheck($variable, $class, $interfaceTest)
126			{
127			return [
128			['label' => 'Интерфейсы', 'url' => ['default/interfaces']],
129			$class,
130			];
131			}
132
133			public static function crumbDefaultInterfaces()
134			{
135			return [
136			'Интерфейсы',
137			];
138			}
139
140			public static function crumbDefaultFiles()
141			{
142			return [
143			'Временные файлы',
144			];
145			}
146
147			public static function crumbDefaultSettings()
148			{
149			return [
150			'Настройки модуля',
151			];
152			}
153
154			public static function crumbDefaultDocumentation()
155			{
156			return [
157			'Документация по CommerceML',
158			];
159			}
160
161			public static function crumbDefaultExport()
162			{
163			return [
164			'Экспорт',
165			];
166			}
167
168
169			public static function crumbDefaultImport()
170			{
171			return [
172			'Импорт',
173			];
174			}
175
176			public static function crumbArticleIndex()
177			{
178			return [
179			'Старт',
180			];
181			}
182			}

carono / yii2-1c-exchange

Push — master ( de9f16...6836c0 )

Breadcrumbs::crumbArticleIndex() A

Complexity

Size

Duplication

Importance

Available Fixes

1. Do not assign by reference

2. Assign to a local variable first

3. Return a reference

Duplication Side-by-Side

Filter issues like