RequestAbstract::methods() - Code Metrics - Inspection of "readme" - carono/turbotext-api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( b917eb...fefbb9 )

by Aleksandr

created 2017-10-25 21:23 UTC

RequestAbstract::methods() B

↳ Parent: RequestAbstract

Complexity

Conditions	7
Paths	13

Size

Total Lines	53
Code Lines	45

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	53
rs	7.5251
cc	7
eloc	45
nc	13
nop	0

How to fix Long Method

<?php

namespace carono\turbotext\codegen;

use carono\codegen\ClassGenerator;

class RequestAbstract extends ClassGenerator
{
    /**
     * @return string
     */
    protected function formExtends()
    {
        return 'carono\turbotext\RequestAbstract';
    }

    /**
     * @return string
     */
    protected function formClassName()
    {
        return ucfirst($this->params['name']) . 'Request';
    }

    /**
     * @return string
     */
    protected function formClassNamespace()
    {
        return 'carono\turbotext\request';
    }

    /**
     * @return string
     */
    protected function formOutputPath()
    {
        return dirname(__DIR__) . DIRECTORY_SEPARATOR . 'src' . DIRECTORY_SEPARATOR . 'request' . DIRECTORY_SEPARATOR . $this->formClassName() . '.php';
    }

    /**
     * @return bool
     */
    public function methods()
    {
        foreach ($this->params['methods'] as $methodData) {
            $methodName = formMethodName($methodData['name']);
            $method = $this->phpClass->addMethod($methodName);
            $method->addComment(trim($methodData['description']));
            $params = [];
            $params['action'] = $methodData['name'];
            if (count($methodData['params']) > 4) {
                $config = new ConfigAbstract();
                $config->renderToFile($methodData);
                $className = '\\' . $config->formClassNamespace() . '\\' . $config->formClassName();
                $method->addParameter('config');
                $method->addComment("@param $className|array \$config");

                $body = <<<PHP
foreach ((\$config instanceof \carono\\turbotext\ConfigAbstract ? \$config->toArray() : \$config) as \$key => \$value) {
    \$params[\$key] = \$value;
}
PHP;
                $paramsStr = self::arrayAsPhpVar($params);
                $method->addBody("\$params = $paramsStr;");
                $method->addBody($body);
            } else {
                foreach ($methodData['params'] as $param) {
                    $type = formParamType($param['type']);
                    $method->addComment("@param {$type} \${$param['name']} {$param['description']}");
                    $params[$param['name']] = '$' . $param['name'];
                    if ($param['required']) {
                        $method->addParameter($param['name']);
                    } else {
                        $method->addParameter($param['name'], null);
                    }
                }
                $paramsStr = self::arrayAsPhpVar($params);
                $method->addBody("\$params = $paramsStr;");
            }
            $response = new ResponseAbstract();
            if (isset($methodData['returns'][0]['result'])) {
                $response->renderToFile($methodData['returns'][0]);
                $className = $response->formClassNamespace() . '\\' . $response->formClassName();
            } elseif ($methodData['returns']) {
                $methodData['returns']['name'] = $methodData['name'];
                $response->properties['asd'] = 213;
                $response->renderToFile($methodData['returns']);
                $className = $response->formClassNamespace() . '\\' . $response->formClassName();
            } else {
                $className = 'carono\turbotext\Response';
            }
            $method->addComment("@return \\$className|string|\stdClass|\SimpleXMLElement");
            $method->addBody("return \$this->getClient()->getContent('api', \$params, '$className');");
        }
        return false;
    }

    protected static function arrayAsPhpVar($array)
    {
        $export = [];
        foreach ($array as $key => $value) {
            $export[] = "'$key' => " . (strpos($value, '$') === false ? "'$value'" : $value);
        }
        $export = join(",\n\t", $export);
        if ($array) {
            $result = "[\n\t$export\n]";
        } else {
            $result = "[]";
        }
        return $result;
    }
}

1			<?php
2
3			namespace carono\turbotext\codegen;
4
5			use carono\codegen\ClassGenerator;
6
7			class RequestAbstract extends ClassGenerator
8			{
9			/**
10			* @return string
11			*/
12			protected function formExtends()
13			{
14			return 'carono\turbotext\RequestAbstract';
15			}
16
17			/**
18			* @return string
19			*/
20			protected function formClassName()
21			{
22			return ucfirst($this->params['name']) . 'Request';
23			}
24
25			/**
26			* @return string
27			*/
28			protected function formClassNamespace()
29			{
30			return 'carono\turbotext\request';
31			}
32
33			/**
34			* @return string
35			*/
36			protected function formOutputPath()
37			{
38			return dirname(__DIR__) . DIRECTORY_SEPARATOR . 'src' . DIRECTORY_SEPARATOR . 'request' . DIRECTORY_SEPARATOR . $this->formClassName() . '.php';
39			}
40
41			/**
42			* @return bool
43			*/
44			public function methods()
45			{
46			foreach ($this->params['methods'] as $methodData) {
47			$methodName = formMethodName($methodData['name']);
48			$method = $this->phpClass->addMethod($methodName);
49			$method->addComment(trim($methodData['description']));
50			$params = [];
51			$params['action'] = $methodData['name'];
52			if (count($methodData['params']) > 4) {
53			$config = new ConfigAbstract();
54			$config->renderToFile($methodData);
55			$className = '\\' . $config->formClassNamespace() . '\\' . $config->formClassName();
56			$method->addParameter('config');
57			$method->addComment("@param $className\|array \$config");
58
59			$body = <<<PHP
60			foreach ((\$config instanceof \carono\\turbotext\ConfigAbstract ? \$config->toArray() : \$config) as \$key => \$value) {
61			\$params[\$key] = \$value;
62			}
63			PHP;
64			$paramsStr = self::arrayAsPhpVar($params);
65			$method->addBody("\$params = $paramsStr;");
66			$method->addBody($body);
67			} else {
68			foreach ($methodData['params'] as $param) {
69			$type = formParamType($param['type']);
70			$method->addComment("@param {$type} \${$param['name']} {$param['description']}");
71			$params[$param['name']] = '$' . $param['name'];
72			if ($param['required']) {
73			$method->addParameter($param['name']);
74			} else {
75			$method->addParameter($param['name'], null);
76			}
77			}
78			$paramsStr = self::arrayAsPhpVar($params);
79			$method->addBody("\$params = $paramsStr;");
80			}
81			$response = new ResponseAbstract();
82			if (isset($methodData['returns'][0]['result'])) {
83			$response->renderToFile($methodData['returns'][0]);
84			$className = $response->formClassNamespace() . '\\' . $response->formClassName();
85			} elseif ($methodData['returns']) {
86			$methodData['returns']['name'] = $methodData['name'];
87			$response->properties['asd'] = 213;
88			$response->renderToFile($methodData['returns']);
89			$className = $response->formClassNamespace() . '\\' . $response->formClassName();
90			} else {
91			$className = 'carono\turbotext\Response';
92			}
93			$method->addComment("@return \\$className\|string\|\stdClass\|\SimpleXMLElement");
94			$method->addBody("return \$this->getClient()->getContent('api', \$params, '$className');");
95			}
96			return false;
97			}
98
99			protected static function arrayAsPhpVar($array)
100			{
101			$export = [];
102			foreach ($array as $key => $value) {
103			$export[] = "'$key' => " . (strpos($value, '$') === false ? "'$value'" : $value);
104			}
105			$export = join(",\n\t", $export);
106			if ($array) {
107			$result = "[\n\t$export\n]";
108			} else {
109			$result = "[]";
110			}
111			return $result;
112			}
113			}

carono / turbotext-api

Push — master ( b917eb...fefbb9 )

RequestAbstract::methods() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like